[ 
https://issues.apache.org/jira/browse/NIFI-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344932#comment-15344932
 ] 

ASF GitHub Bot commented on NIFI-2063:
--------------------------------------

GitHub user apiri opened a pull request:

    https://github.com/apache/nifi/pull/561

    NIFI-2063 Adjusting handling of service install by using script that …

    …delegates to installed nifi.sh at NIFI_HOME. Only prohibit installation of 
service for Cygwin and Darwin environments that are guaranteed to not support 
it.
    
    This is an alternative approach the work of #553 which will delegate 
service calls to the core nifi.sh and the associated nifi-env.sh.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apiri/incubator-nifi linux-service

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/561.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #561
    
----
commit 11985a05dac703f7374ed13d9e403c8956e7b4c9
Author: Aldrin Piri <[email protected]>
Date:   2016-06-22T17:09:40Z

    NIFI-2063 Adjusting handling of service install by using script that 
delegates to installed nifi.sh at NIFI_HOME. Only prohibit installation of 
service for Cygwin and Darwin environments that are guaranteed to not support 
it.

----


> Install Script Relative Path Mismatch from Init Dir
> ---------------------------------------------------
>
>                 Key: NIFI-2063
>                 URL: https://issues.apache.org/jira/browse/NIFI-2063
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Configuration
>    Affects Versions: 1.0.0, 0.7.0
>         Environment: Linux/Unix with SysVInit
>            Reporter: James Wing
>            Assignee: Yolanda M. Davis
>             Fix For: 0.7.0
>
>
> Ryan Hendrickson noticed that installing and running NiFi as a service in 
> 0.7.0-SNAPSHOT is not working right.  Running commands like the following:
> {code}
> $ sudo /opt/nifi/nifi-0.7.0-SNAPSHOT/bin/nifi.sh install
> Service nifi installed
> $ sudo service nifi start
> /etc/init.d/nifi: line 28: /etc/init.d/nifi-env.sh: No such file or directory
> {code}
> Results in errors loading nifi-env.sh
> *Used-To-Be*
> As I understand it, {{nifi.sh install}} used to:
> 1. copy bin/nifi.sh to /etc/init.d/nifi
> 2. Run sed to change NIFI_HOME initializations to the path to nifi.sh, where 
> install was invoked
> 3. When {{service nifi start}} was run, the NIFI_HOME path was hard-coded in 
> the service script file.
> *As-Is*
> 1. nifi.sh now gets NIFI_HOME from bin/nifi-env.sh, which is stored alongside 
> nifi.sh.
> 2. install() still calls sed to update NIFI_HOME=, but the initialization is 
> now in nifi-env.sh, so nothing is replaced.
> 3. When {{service nifi start}} is called, relative path to 
> {{SCRIPT_DIR/nifi-env.sh}} resolves to {{/etc/init.d/nifi-env.sh}}, which 
> does not exist.
> *To-Be*
> A possible solution might be to have sed update SCRIPT_DIR to be hard-coded, 
> and change to that directory to run nifi-env.sh.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to