[ 
https://issues.apache.org/jira/browse/NIFI-2027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15348579#comment-15348579
 ] 

ASF GitHub Bot commented on NIFI-2027:
--------------------------------------

Github user mcgilman commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/577#discussion_r68449184
  
    --- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/summary/nf-summary.js
 ---
    @@ -180,6 +180,16 @@ nf.Summary = (function () {
                                     'width': $(window).width() + 'px'
                                 });
     
    +                            var summaryTableHeight = 
$('#summary').outerHeight() -
    +                                ($('#summary-header-text').outerHeight() + 
30) - //30 for margin-bottom on summary-header-text
    +                                ($('#summary-tabs').outerHeight() + 20) - 
//20 for margin-bottom on tab-container
    +                                
$('#summary-filter-controls').outerHeight() -
    +                                
$('#flow-summary-refresh-container').outerHeight();
    +                            if (top === window) {
    +                                summaryTableHeight -= 80; //80 for padding
    +                            }
    +                            
$('.summary-table').height(summaryTableHeight).show();
    --- End diff --
    
    I think this logic is unnecessary as the provenance table is bound from the 
bottom using position absolute. The height should adjust due to the CSS rules.


> Properties Tables
> -----------------
>
>                 Key: NIFI-2027
>                 URL: https://issues.apache.org/jira/browse/NIFI-2027
>             Project: Apache NiFi
>          Issue Type: Sub-task
>          Components: Core UI
>            Reporter: Scott Aslan
>            Assignee: Scott Aslan
>             Fix For: 1.0.0
>
>
> - Non-EL Property editor, cannot resize horizontally
> - EL Property editor, resize renders too slowly
> - Is empty check box positioning is off
> - window resize event needs to resize any visible properties tables
> - Property table heights are too short
> - GoTo icon is right aligned



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to