[
https://issues.apache.org/jira/browse/NIFI-1838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15349723#comment-15349723
]
ASF GitHub Bot commented on NIFI-1838:
--------------------------------------
Github user PuspenduBanerjee commented on a diff in the pull request:
https://github.com/apache/nifi/pull/534#discussion_r68490863
--- Diff:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java
---
@@ -92,11 +92,10 @@
logger.error(message, t);
}
}
- } else {
- // Return defaults for now
- relationships.add(REL_SUCCESS);
- relationships.add(REL_FAILURE);
}
+ // Add defaults
+ relationships.add(REL_SUCCESS);
+ relationships.add(REL_FAILURE);
--- End diff --
Even in original state of `InvokeScriptedProcesor`, the documentation says
> SUCCESS and FAILURE are always returned, and if the script
processor has defined additional relationships, those will be added as
well
```
/**
* Returns the valid relationships for this processor. SUCCESS and
FAILURE are always returned, and if the script
* processor has defined additional relationships, those will be added
as well.
*
* @return a Set of Relationships supported by this processor
*/
@Override
public Set<Relationship> getRelationships()
```
So, ideally those test cases does not require modification, they are there
as per contract stated in the java-doc and this piece is valid.
I strongly believe we should not break that contract as that may create
implication for scripted-processor in production.
Please correct me otherwise.
> Groovy Test Scripts will require refactoring if we implement NIFI-1152
> ----------------------------------------------------------------------
>
> Key: NIFI-1838
> URL: https://issues.apache.org/jira/browse/NIFI-1838
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.0.0, 0.6.1
> Reporter: Puspendu Banerjee
> Labels: patch
> Fix For: 1.0.0
>
> Attachments:
> 0001-Fix-for-NIFI-1838-NIFI-1152-Code-modification-for-ty.patch
>
>
> Groovy Test Scripts will require refractoring we implement NIFI-1152 as they
> don't define Relationships properly
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
