[ 
https://issues.apache.org/jira/browse/NIFI-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15349823#comment-15349823
 ] 

James Wing commented on NIFI-2115:
----------------------------------

I tested building from a source zip.  There are two concerns -- building 
outside a Git repo that provides commit and branch info, and building without 
Git tools installed at all.  The plugin included in this PR, 
buildnumber-maven-plugin, has a {{revisionOnScmFailure}} property configured to 
"unknown source" when there is no git environment.  The plugin will log 
warnings like the following:

{code}
[WARNING] Cannot get the revision information from the scm repository, 
proceeding with revision of unknown source :
Exception while executing SCM command.
[INFO] Storing buildNumber: unknown source at timestamp: 1466883469071
[WARNING] Cannot get the branch information from the git repository:
Error while executing command.
{code}

For a source build, the timestamp is the only useful addition, and the data 
captured looks like this (as seen in nifi.properties):

{code}
nifi.build.number=unknown source
nifi.build.branch=UNKNOWN_BRANCH
nifi.build.timestamp=2016-06-25T20:16:40Z
{code}

I admit it's not elegant, but it does not break.  Testing is complicated by the 
requirement for Git to support Bower in nifi-web-ui (see NIFI-1846).

> Enhanced About Box Version Information
> --------------------------------------
>
>                 Key: NIFI-2115
>                 URL: https://issues.apache.org/jira/browse/NIFI-2115
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core UI, Tools and Build
>    Affects Versions: 1.0.0
>            Reporter: James Wing
>            Assignee: James Wing
>            Priority: Minor
>
> The UI's About dialog and underlying API provide the version of NiFi, like 
> "0.7.0-SNAPSHOT".  For many bug reports and troubleshooting requests, this is 
> not very precise, especially around rapidly changing code or 
> platform-dependent behavior.  It would help if NiFi captured and displayed 
> additional information:  
> * NiFi build commit hash
> * NiFi build branch
> * NiFi build date/time
> * Java Version
> * Java Vendor (Oracle, OpenJDK)
> * OS
> Then a simple copy/paste from the about box would provide very specific 
> information about a particular NiFi installation and which code it was 
> derived from.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to