[ 
https://issues.apache.org/jira/browse/MINIFI-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351195#comment-15351195
 ] 

ASF GitHub Bot commented on MINIFI-40:
--------------------------------------

Github user JPercivall commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi/pull/19#discussion_r68591275
  
    --- Diff: minifi-bootstrap/pom.xml ---
    @@ -43,6 +43,10 @@ limitations under the License.
             </dependency>
             <dependency>
                 <groupId>org.apache.nifi</groupId>
    +            <artifactId>nifi-properties</artifactId>
    --- End diff --
    
    Instead of adding another pom dependency for one static helper method I 
would prefer to just create a new private one that does it:
        private static boolean nullOrEmpty(String input) {
            return input == null || input.isEmpty();
        }


> SecurityPropertiesSchema doesn't properly handle empty security properties
> --------------------------------------------------------------------------
>
>                 Key: MINIFI-40
>                 URL: https://issues.apache.org/jira/browse/MINIFI-40
>             Project: Apache NiFi MiNiFi
>          Issue Type: Bug
>            Reporter: Joseph Percivall
>
> The SecurityPropertiesSchema class uses the getOptionalKeyAsType method with 
> a default value of null for each of the keystore, truststore and sslProtcol 
> properties. This ends up getting translated to "null" in the nifi.properties 
> file. 
> The correct default should be "". 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to