[
https://issues.apache.org/jira/browse/MINIFI-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15664328#comment-15664328
]
ASF GitHub Bot commented on MINIFI-115:
---------------------------------------
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/43#discussion_r87827996
--- Diff:
minifi-nar-bundles/minifi-framework-bundle/minifi-framework-nar/pom.xml ---
@@ -34,51 +34,70 @@ limitations under the License.
<source.skip>true</source.skip>
</properties>
<dependencies>
- <!-- mark these nifi artifacts as provided since it is included in
the lib -->
+ <dependency>
+ <groupId>org.apache.nifi.minifi</groupId>
+ <artifactId>minifi-framework-core</artifactId>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.nifi.minifi</groupId>
+ <artifactId>minifi-api</artifactId>
+ <scope>provided</scope>
+ </dependency>
+
+ <!-- NiFi Framework level dependencies -->
<dependency>
<groupId>org.apache.nifi</groupId>
<artifactId>nifi-api</artifactId>
- <scope>provided</scope>
+ <scope>compile</scope>
</dependency>
<dependency>
<groupId>org.apache.nifi</groupId>
<artifactId>nifi-runtime</artifactId>
- <scope>provided</scope>
+ <scope>compile</scope>
</dependency>
<dependency>
<groupId>org.apache.nifi</groupId>
<artifactId>nifi-nar-utils</artifactId>
- <scope>provided</scope>
+ <scope>compile</scope>
</dependency>
<dependency>
<groupId>org.apache.nifi</groupId>
<artifactId>nifi-properties</artifactId>
- <scope>provided</scope>
+ <scope>compile</scope>
</dependency>
<dependency>
- <groupId>org.apache.nifi.minifi</groupId>
- <artifactId>minifi-framework-core</artifactId>
- <scope>provided</scope>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-security</artifactId>
+ <scope>compile</scope>
+ <version>1.0.0</version>
</dependency>
<dependency>
- <groupId>org.apache.nifi</groupId>
- <artifactId>nifi-administration</artifactId>
- <scope>provided</scope>
+ <groupId>org.eclipse.jetty</groupId>
+ <artifactId>jetty-server</artifactId>
</dependency>
<dependency>
- <groupId>org.apache.nifi.minifi</groupId>
- <artifactId>minifi-api</artifactId>
- <scope>provided</scope>
+ <groupId>org.eclipse.jetty</groupId>
+ <artifactId>jetty-servlet</artifactId>
</dependency>
<dependency>
- <groupId>org.apache.nifi</groupId>
- <artifactId>nifi-framework-core</artifactId>
- <scope>provided</scope>
+ <groupId>org.eclipse.jetty</groupId>
+ <artifactId>jetty-webapp</artifactId>
--- End diff --
Why are Jetty deps being added to the MiNiFi-framework-nar? I don't see any
other changes to the module that would warrant the additions.
> Upgrade NiFi dependencies to 1.0
> --------------------------------
>
> Key: MINIFI-115
> URL: https://issues.apache.org/jira/browse/MINIFI-115
> Project: Apache NiFi MiNiFi
> Issue Type: Task
> Components: Core Framework
> Affects Versions: 0.0.1
> Reporter: Aldrin Piri
> Assignee: Aldrin Piri
> Fix For: 0.1.0
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
