[ 
https://issues.apache.org/jira/browse/MINIFI-175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15821870#comment-15821870
 ] 

ASF GitHub Bot commented on MINIFI-175:
---------------------------------------

Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/38#discussion_r96006591
  
    --- Diff: CMakeLists.txt ---
    @@ -88,3 +88,10 @@ set(CPACK_ARCHIVE_COMPONENT_INSTALL ON)
     set(CPACK_COMPONENTS_ALL bin)
     
     include(CPack)
    +
    +# Create a custom build target called "docker" that will invoke 
DockerBuild.sh and create the NiFi-MiNiFi-CPP Docker image
    +add_custom_target(
    +    docker
    +    COMMAND ${CMAKE_SOURCE_DIR}/docker/DockerBuild.sh 1000 1000 0.2.0 
nifi-minifi-cpp-0.2.0-bin.tar.gz ${CMAKE_SOURCE_DIR}
    --- End diff --
    
    Would be good to to make use of the defined project version variables to 
avoid having to update this.  A bit more verbose, but would automatically be 
taken care of on release/version incrementing.


> Create official Apache NiFi MiNiFi C++ Dockerfile
> -------------------------------------------------
>
>                 Key: MINIFI-175
>                 URL: https://issues.apache.org/jira/browse/MINIFI-175
>             Project: Apache NiFi MiNiFi
>          Issue Type: Improvement
>          Components: C++
>    Affects Versions: 0.1.0
>            Reporter: Jeremy Dyer
>            Assignee: Jeremy Dyer
>             Fix For: 0.2.0
>
>
> Docker containers make testing, examples, and production all easier. Creating 
> an official Docker image hosted a http://www.dockerhub.com would vastly 
> increase the user experience. Having this image would allow for users to 
> quickly experiment, allow contributors and committers to quickly test 
> enhancements, add support for testing features that require more than a 
> single instance which most cases do, and help bring a polished edge to the 
> project.
> The Dockerfile itself would also be helpful to new users by self describing 
> to them the manner in which MiNiFi should be installed on their devices even 
> if they chose to not use the Docker image itself.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to