[ 
https://issues.apache.org/jira/browse/MINIFI-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15856341#comment-15856341
 ] 

ASF GitHub Bot commented on MINIFI-184:
---------------------------------------

Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/41#discussion_r99357721
  
    --- Diff: libminifi/src/FlowController.cpp ---
    @@ -75,22 +78,123 @@ FlowController::FlowController(std::string name)
             }
         }
     
    -    path = realpath(adjustedFilename.c_str(), full_path);
    +   path = realpath(adjustedFilename.c_str(), full_path);
        if (!path)
        {
             _logger->log_error("Could not locate path from provided 
configuration file name (%s).  Exiting.", full_path);
             exit(1);
         }
     
    -    std::string pathString(path);
    -    _configurationFileName = pathString;
    -    _logger->log_info("FlowController NiFi Configuration file %s", 
pathString.c_str());
    +   std::string pathString(path);
    --- End diff --
    
    Would it make sense to break this out into a separate class to reduce 
coupling with the security library within the FlowController?


> Add Security Support for Site to Site
> -------------------------------------
>
>                 Key: MINIFI-184
>                 URL: https://issues.apache.org/jira/browse/MINIFI-184
>             Project: Apache NiFi MiNiFi
>          Issue Type: Improvement
>          Components: Core Framework
>    Affects Versions: cpp-0.2.0
>            Reporter: bqiu
>            Assignee: bqiu
>             Fix For: cpp-0.2.0
>
>
> Add Security Support



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to