[
https://issues.apache.org/jira/browse/MINIFI-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15859639#comment-15859639
]
ASF GitHub Bot commented on MINIFI-190:
---------------------------------------
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/47
MINIFI-190: Creating initial commit with additional tests
Additional tests will be updated in separate tickets as needed.
Resolves MINIFI-194 by using a semaphore in place of the
FlowController instance. Stop is performed outside of the
signal handler to avoid synchronicity issues.
Resolves MINIFI-192 by using lock_guard based on a conditional
Resolves issues found with MINIFI-190 regarding GetFile. Added
pragma definitions for GCC < 4.9
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFI-190
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/47.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #47
----
commit e3ed8da1739288774a018c8b2422073802362014
Author: Marc Parisi <[email protected]>
Date: 2017-02-03T14:23:42Z
MINIFI-190: Creating initial commit with changes found
Resolves MINIFI-194 by using a semaphore in place of the
FlowController instance. Stop is performed outside of the
signal handler to avoid synchronicity issues.
Resolves MINIFI-192 by using lock_guard based on a conditional
Resolves issues found with MINIFI-190 regarding GetFile. Added
pragma definitions for GCC < 4.9
----
> Decouple components to make testing easier
> ------------------------------------------
>
> Key: MINIFI-190
> URL: https://issues.apache.org/jira/browse/MINIFI-190
> Project: Apache NiFi MiNiFi
> Issue Type: Bug
> Components: C++
> Reporter: marco polo
> Assignee: marco polo
> Fix For: 0.2.0
>
>
> Decouple components to help with testing. Instead of using GMOCK I'm breaking
> apart certain components that will help with testing and help with future
> development.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
