[
https://issues.apache.org/jira/browse/MINIFI-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15863691#comment-15863691
]
ASF GitHub Bot commented on MINIFI-198:
---------------------------------------
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/49
MINIFI-198: Update root CMAKE so testing can occur
Update root CMake to bring OpenSSL location to top level. Keeping
find_package(...) in libminifi CMakeLists.txt to avoid issues building only
libminifi.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFI-198
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/49.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #49
----
commit 3d40dcf0f66b7ab107f42221fac1db65f2bd7379
Author: Marc Parisi <[email protected]>
Date: 2017-02-13T13:40:10Z
MINIFI-198: Update root CMAKE so testing can occur
Update root CMake to bring OpenSSL location to top level.
Keeping find_package(...) in libminifi CMakeLists.txt to
avoid issues building only libminifi.
----
> OpenSSL inclusions should occur at root CMake
> ---------------------------------------------
>
> Key: MINIFI-198
> URL: https://issues.apache.org/jira/browse/MINIFI-198
> Project: Apache NiFi MiNiFi
> Issue Type: Improvement
> Components: C++
> Reporter: marco polo
> Assignee: marco polo
> Priority: Minor
> Fix For: cpp-0.2.0
>
>
> Since we have a root level cmake we need OpenSSL there to be able to test.
> This should appropriately be done at the root level.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
