[ 
https://issues.apache.org/jira/browse/MINIFI-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869853#comment-15869853
 ] 

ASF GitHub Bot commented on MINIFI-183:
---------------------------------------

Github user achristianson commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/43#discussion_r101507876
  
    --- Diff: libminifi/src/ThreadedSchedulingAgent.cpp ---
    @@ -64,11 +68,18 @@ void ThreadedSchedulingAgent::schedule(Processor 
*processor)
                return;
        }
     
    +   auto processContext = std::make_shared<ProcessContext>(processor);
    --- End diff --
    
    @phrocker Mainly, creating a shared ProcessContext and SessionFactory which 
will be used in this thread as well as the threads created in the loop below. I 
wanted these objects to be cleaned up once they go out of scope in all threads. 
The raw pointers are only used to integrate with the existing Processor pointer 
that is passed-in, as well as passing raw pointers to the constructors of the 
new shared objects. I wanted to minimize function/constructor changes that 
might have impacts elsewhere in the code base. If we want to move more to 
having managed pointers across the code base, then some of this can be cleaned 
up.


> Create ListenHTTP processor
> ---------------------------
>
>                 Key: MINIFI-183
>                 URL: https://issues.apache.org/jira/browse/MINIFI-183
>             Project: Apache NiFi MiNiFi
>          Issue Type: Task
>          Components: C++
>            Reporter: Andrew Christianson
>            Assignee: Andrew Christianson
>
> Create a ListenHTTP processor of similar design/function to the ListenHTTP in 
> the parent Apache NiFi project.
> Being a part of MiNiFi, the server should be very lightweight, handle 
> requests asynchronously, have optional threading, and should support 
> streaming of request/response content to minimize memory requirements.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to