[
https://issues.apache.org/jira/browse/MINIFI-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878597#comment-15878597
]
ASF GitHub Bot commented on MINIFI-222:
---------------------------------------
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/55#discussion_r102499389
--- Diff: include/spdlog/sinks/ansicolor_sink.h ---
@@ -0,0 +1,116 @@
+//
+// Copyright(c) 2016 Kevin M. Godby (a modified version by spdlog).
--- End diff --
Seems like we would need to call this out similar to
https://github.com/apache/nifi-minifi-cpp/blob/ff7aa7fc3bf55681398427f1de6af7f352a100fa/LICENSE#L394
> upgrade spdlog
> --------------
>
> Key: MINIFI-222
> URL: https://issues.apache.org/jira/browse/MINIFI-222
> Project: Apache NiFi MiNiFi
> Issue Type: Improvement
> Components: C++
> Reporter: marco polo
> Assignee: marco polo
> Priority: Minor
> Fix For: cpp-0.2.0
>
>
> Upgrade and test more recent version of spdlog
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
