[ 
https://issues.apache.org/jira/browse/MINIFI-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15899740#comment-15899740
 ] 

ASF GitHub Bot commented on MINIFI-231:
---------------------------------------

Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/62#discussion_r104687778
  
    --- Diff: libminifi/test/unit/ProvenanceTestHelper.h ---
    @@ -20,6 +20,62 @@
     
     #include "Provenance.h"
     #include "FlowController.h"
    +#include "FlowFileRepository.h"
    +
    +/**
    + * Test repository
    + */
    +class FlowTestRepository : public FlowFileRepository
    --- End diff --
    
    These are nearly Identical, why not just make one that inherits from 
Repository?


> FlowFile Persistent 
> --------------------
>
>                 Key: MINIFI-231
>                 URL: https://issues.apache.org/jira/browse/MINIFI-231
>             Project: Apache NiFi MiNiFi
>          Issue Type: Bug
>          Components: Core Framework, Data Format
>    Affects Versions: cpp-1.0.0
>            Reporter: bqiu
>            Assignee: bqiu
>             Fix For: cpp-1.0.0
>
>
> Add FlowFile persistent support



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to