[ 
https://issues.apache.org/jira/browse/MINIFI-218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900590#comment-15900590
 ] 

ASF GitHub Bot commented on MINIFI-218:
---------------------------------------

Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/52#discussion_r104832401
  
    --- Diff: libminifi/test/unit/gps/GetGPSTests.h ---
    @@ -0,0 +1,37 @@
    +/**
    + *
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +
    +#ifndef GPS_TESTS
    +#define GPS_TESTS
    +#include "../../TestBase.h"
    +
    +#include "../ProvenanceTestHelper.h"
    +#include "../Provenance.h"
    +#include "../FlowFileRecord.h"
    +
    +
    +TEST_CASE("Test GPSD Create", "[TestGPSEventRecord]"){
    --- End diff --
    
    yeah I initially approved because I wasn't sure there was a good way to 
test this. I didn't know about gpsfake, and would love if there was a way to 
roll that in. 


> Create GetGPS processor for acquiring GPS coordinates
> -----------------------------------------------------
>
>                 Key: MINIFI-218
>                 URL: https://issues.apache.org/jira/browse/MINIFI-218
>             Project: Apache NiFi MiNiFi
>          Issue Type: New Feature
>          Components: C++
>            Reporter: Jeremy Dyer
>            Assignee: Jeremy Dyer
>
> GPSD is a popular framework for interacting with a multitude of GPS devices. 
> It drastically simplifies the interaction with vendor specific GPS devices by 
> providing a daemon service which communicates with the device, converts the 
> raw NMEA 0183 sentences into JSON objects, and then emits those JSON objects 
> over a socket for 0-N downstream devices to consume.
> This feature would create a GetGPS processor that would listen to a running 
> instance of GPSD as one of those downstream consumers. The processor would 
> provide integration with the GPSD daemon to accept the JSON objects and 
> create new flowfiles for each of the JSON objects received.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to