[
https://issues.apache.org/jira/browse/MINIFI-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15902398#comment-15902398
]
ASF GitHub Bot commented on MINIFI-217:
---------------------------------------
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/63
@jdye64 Since I moved to using auto instead of int, we are actually using a
car to iterate through the string, therefore the previous code that existed now
throws the warning. This is a placeholder for a block I submitted. I think it
is safe to treat this as UTF-8 since NiFi enforces UTF-8, but before doing so
I'd like some more testing. Therefore I leave the warning be as a placeholder.
Realistically we could just change auto to int to get rid of the warning, but I
think it serves as a warning that we weren't handling UTF correctly previously
and now. I will deal with this in a subsequent PR.
Again, I think we're okay as long as NiFi sticks with UTF-8, but I'd like
to beef up the tests.
> Move to org::apache::nifi::minifi namespace in CPP agent
> --------------------------------------------------------
>
> Key: MINIFI-217
> URL: https://issues.apache.org/jira/browse/MINIFI-217
> Project: Apache NiFi MiNiFi
> Issue Type: Bug
> Components: C++
> Affects Versions: cpp-0.1.0, cpp-0.2.0
> Reporter: marco polo
> Priority: Trivial
> Original Estimate: 504h
> Remaining Estimate: 504h
>
> Move code to a more controlled namespace. I suggest org::apache::nifi::minifi
> since that more closely reflects the JAVA package.
> Suggest Processor namespace be
> org::apache::nifi::minifi::processors
> Suggest I/O namespace be
> org::apache::nifi::minifi::io
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
