[
https://issues.apache.org/jira/browse/MINIFI-193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15930319#comment-15930319
]
ASF GitHub Bot commented on MINIFI-193:
---------------------------------------
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/68
MINIFI-193: Ensure safe UTF encoding
Since the C++ library is agnostic of UTF-8 we can safely write the bytes.
Since we won't be interpreting the UTF-8 code in the core library
we do not need any additional dependencies. Nor do we need to worry about
encoding beyond proper serialization and deserialization of the byte array.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFI-193
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/68.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #68
----
commit be5064c82d8c9c98cc06abf7ec5c9470e4dca105
Author: Marc Parisi <[email protected]>
Date: 2017-03-17T17:11:21Z
MINIFI-193: Ensure safe UTF encoding
Since the C++ library is agnostic of UTF-8 we can safely write the bytes.
Since we won't be interpreting the UTF-8 code in the core library
we do not need any additional dependencies. Nor do we need to worry about
encoding beyond proper serialization and deserialization of the byte array.
----
> writeUTF doesn't properly allow UTF-8 encoding
> ----------------------------------------------
>
> Key: MINIFI-193
> URL: https://issues.apache.org/jira/browse/MINIFI-193
> Project: Apache NiFi MiNiFi
> Issue Type: Bug
> Components: C++
> Affects Versions: cpp-0.1.0
> Reporter: marco polo
> Assignee: marco polo
> Priority: Blocker
>
> std::u16string should be used instead of std::string.
> The code that was copied and pasted into Provenance.cpp demonstrates this
> problem.
> {code:title=Provenance.cpp|borderStyle=solid}
> for (int i = 0; i < inLength; i++) {
> int c = str.at(i);
> {code}
> Since the return of std::string::at is actually a car our max size is 0-255;
> however, JAVA char is represented as a 16 bit unicode character whose value
> can actually be > 0x07ff. We lose the data in translation if we were to use
> these functions.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
