[
https://issues.apache.org/jira/browse/MINIFI-242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15934853#comment-15934853
]
ASF GitHub Bot commented on MINIFI-242:
---------------------------------------
GitHub user brosander opened a pull request:
https://github.com/apache/nifi-minifi/pull/76
MINIFI-242 - Initial integration tests focused around backwards compa…
…tibility
Thank you for submitting a contribution to Apache NiFi - MiNiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi-minifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under minifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under minifi-assembly?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/brosander/nifi-minifi MINIFI-242
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi/pull/76.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #76
----
commit 3893d61255837fb93ec9eadca376ac5c480a5b99
Author: Bryan Rosander <[email protected]>
Date: 2017-03-21T16:37:05Z
MINIFI-242 - Initial integration tests focused around backwards
compatibility
----
> Automated integration tests with docker-compose
> -----------------------------------------------
>
> Key: MINIFI-242
> URL: https://issues.apache.org/jira/browse/MINIFI-242
> Project: Apache NiFi MiNiFi
> Issue Type: Test
> Reporter: Bryan Rosander
>
> Docker-compose has a lot of potential to make integration-level tests a lot
> easier and faster to perform. As most people won't have Docker installed,
> these should only be run when the docker profile is active.
> Initial implementation can take v1 and v2 tests from
> https://github.com/brosander/minifi-testkit and modify them to run using the
> palantir docker-compose-rule-junit4 to allow for easy spin-up and down of
> minifi instances.
> This has value in ensuring that older templates can be transformed to the
> current version of the configuration schema. It also tests that the
> config.yml files from old minifi toolkits still upconvert and run properly.
> From there it should be straightforward to use docker-compose files to model
> more complex configurations.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
