[
https://issues.apache.org/jira/browse/MINIFI-213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936359#comment-15936359
]
marco polo edited comment on MINIFI-213 at 3/22/17 2:18 PM:
------------------------------------------------------------
I usually use a git submodule when pulling ExternalProjects, but there are some
cases for deps that don't have a git repo or those in which they are a little
too volatile/big, which require download by other means. When I said download
dependencies I was including things like boost, which you can do with a variety
of cmake dep managers. I usually do it with shell scripts, but some cmake dep
managers simply take to downloading things like boost ( for example ) and
building as needed.
Sorry for the edits. I was doing too many things at once and when I proofread
it I made no sense to myself.
I've seen a lot of repos rely solely on dep managers or shell scripts to
download and build dependencies. This has the advantage of making a smaller
repo. I like git submodule, but not for everything. I' ll leave the implementer
of this ticket to make his or her choice. I've edited ticket to not skew
anyone's direction toward a download only solution. I'd probably like a mix if
it makes sense.
was (Author: phrocker):
I usually use a git submodule when pulling ExternalProjects, but there are some
cases for deps that don't have a git repo or those in which they are a little
too volatile/big, which require download by other means. When I said download
dependencies I was including things like boost, which you can do with a variety
of cmake dep managers. I usually do it with shell scripts, but some cmake dep
managers simply take to downloading things like boost ( for example ) and
building as needed.
Sorry for the edits. I was doing too many things at once and when I proofread
it I made no sense to myself.
I've seen a lot of repos reply solely on dep managers or shell scripts to
download and build dependencies. This has the advantage of making a smaller
repo. I like git submodule, but not for everything. I' ll leave the implementer
of this ticket to make his or her choice.
> Move dependencies to ExternalProject
> ------------------------------------
>
> Key: MINIFI-213
> URL: https://issues.apache.org/jira/browse/MINIFI-213
> Project: Apache NiFi MiNiFi
> Issue Type: Improvement
> Reporter: marco polo
>
> Could we move the libs in thirdparty to ExternalProject? Would this cause an
> impact to any users?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
