[ 
https://issues.apache.org/jira/browse/MINIFI-238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15944016#comment-15944016
 ] 

ASF GitHub Bot commented on MINIFI-238:
---------------------------------------

Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi/pull/75#discussion_r107981828
  
    --- Diff: 
minifi-c2/minifi-c2-api/src/main/java/org/apache/nifi/minifi/c2/api/properties/C2Properties.java
 ---
    @@ -0,0 +1,89 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.nifi.minifi.c2.api.properties;
    +
    +import org.eclipse.jetty.util.ssl.SslContextFactory;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import java.io.IOException;
    +import java.io.InputStream;
    +import java.nio.file.Files;
    +import java.nio.file.Path;
    +import java.nio.file.Paths;
    +import java.security.GeneralSecurityException;
    +import java.security.KeyStore;
    +import java.util.Properties;
    +
    +public class C2Properties extends Properties {
    +    public static final String MINIFI_C2_SERVER_SECURE = 
"minifi.c2.server.secure";
    +    public static final String MINIFI_C2_SERVER_KEYSTORE_TYPE = 
"minifi.c2.server.keystoreType";
    +    public static final String MINIFI_C2_SERVER_KEYSTORE = 
"minifi.c2.server.keystore";
    +    public static final String MINIFI_C2_SERVER_KEYSTORE_PASSWD = 
"minifi.c2.server.keystorePasswd";
    +    public static final String MINIFI_C2_SERVER_KEYSTORE_PASSWD1 = 
"minifi.c2.server.keystorePasswd";
    --- End diff --
    
    did you intend for this to be the keyPassword?


> MiNiFi Initial Command and Control Server Implementation
> --------------------------------------------------------
>
>                 Key: MINIFI-238
>                 URL: https://issues.apache.org/jira/browse/MINIFI-238
>             Project: Apache NiFi MiNiFi
>          Issue Type: New Feature
>            Reporter: Bryan Rosander
>
> A lot of work (MINIFI-2, MINIFI-4, MINIFI-12, MINIFI-14, MINIFI-17, 
> MINIFI-36) has gone into creating a configurable way for MiNiFi to get new 
> configuration from a defined source.
> This is one aspect of the overal [the command and control feature 
> proposoal|https://cwiki.apache.org/confluence/display/MINIFI/MiNiFi+Command+and+Control].
>   The other aspect is an endpoint that ties into the NiFi ideas of [flow 
> versioning|https://cwiki.apache.org/confluence/display/NIFI/Configuration+Management+of+Flows#ConfigurationManagementofFlows-FlowVersioning]
>  and probably the [variable 
> registry|https://cwiki.apache.org/confluence/display/NIFI/Variable+Registry].
> While the flow registry is not available for consumption yet, we can still 
> start proving out things from the MiNiFi end forward.  We can start by 
> implementing a server MiNiFi can get configuration from that is done in a 
> pluggable way such that it can be integrated with the NiFi registries 
> mentioned above when they are ready for consumption.
> This server should:
> 1. Utilize same/similar paradigms of the NiFi webserver to facilitate reuse 
> and possible future embedding.
> 2. Support pluggability for its main functions including security and logic 
> for retrieving the MiNiFi configuration.
> 3. Support both authentication of users and authorization for a given flow.
> 4. Integrate easily with the existing PullHttpChangeIngestor in MiNiFi.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to