[
https://issues.apache.org/jira/browse/MINIFI-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15949067#comment-15949067
]
ASF GitHub Bot commented on MINIFI-236:
---------------------------------------
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/71#discussion_r108926160
--- Diff: libminifi/test/TestExecuteProcess.cpp ---
@@ -0,0 +1,136 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include <uuid/uuid.h>
+#include <fstream>
+#include "FlowController.h"
+#include "unit/ProvenanceTestHelper.h"
+#include "core/logging/LogAppenders.h"
+#include "core/logging/BaseLogger.h"
+#include "processors/GetFile.h"
+#include "core/core.h"
+#include "core/FlowFile.h"
+#include "core/Processor.h"
+#include "core/ProcessContext.h"
+#include "core/ProcessSession.h"
+#include "core/ProcessorNode.h"
+
+int main(int argc, char **argv)
+{
+
+ std::ostringstream oss;
+ std::unique_ptr<logging::BaseLogger> outputLogger = std::unique_ptr<
+ logging::BaseLogger>(
+ new
org::apache::nifi::minifi::core::logging::OutputStreamAppender(oss,
+
0));
+ std::shared_ptr<logging::Logger> logger = logging::Logger::getLogger();
+ logger->updateLogger(std::move(outputLogger));
+
+
+ outputLogger = std::unique_ptr<logging::BaseLogger>(
+ new org::apache::nifi::minifi::core::logging::NullAppender());
+ logger->updateLogger(std::move(outputLogger));
+
+ std::shared_ptr<core::Processor> processor = std::make_shared<
+
org::apache::nifi::minifi::processors::ExecuteProcess>("executeProcess");
+ processor->setMaxConcurrentTasks(1);
+
+ std::shared_ptr<core::Repository> test_repo =
+ std::make_shared<TestRepository>();
+
+ std::shared_ptr<TestRepository> repo =
+ std::static_pointer_cast<TestRepository>(test_repo);
+ std::shared_ptr<minifi::FlowController> controller = std::make_shared<
+ TestFlowController>(test_repo, test_repo);
+
+ uuid_t processoruuid;
+ assert(true == processor->getUUID(processoruuid));
+
+ std::shared_ptr<minifi::Connection> connection = std::make_shared<
+ minifi::Connection>(test_repo, "executeProcessConnection");
+ connection->setRelationship(core::Relationship("success",
"description"));
+
+ // link the connections so that we can test results at the end for this
+ connection->setSource(processor);
+ connection->setDestination(processor);
+
+ connection->setSourceUUID(processoruuid);
+ connection->setDestinationUUID(processoruuid);
+
+ processor->addConnection(connection);
+ assert(processor->getName() == "executeProcess");
+
+ std::shared_ptr<core::FlowFile> record;
+ processor->setScheduledState(core::ScheduledState::RUNNING);
+
+ processor->initialize();
+
+ std::atomic<bool> is_ready(false);
+
+ std::vector<std::thread> processor_workers;
+
+ core::ProcessorNode node2(processor);
+ std::shared_ptr<core::ProcessContext> contextset = std::make_shared<
+ core::ProcessContext>(node2, test_repo);
+ core::ProcessSessionFactory factory(contextset.get());
+ // processor->onSchedule(contextset.get(), &factory);
--- End diff --
unless this should be removed.
> Ensure processors are all thread safe
> -------------------------------------
>
> Key: MINIFI-236
> URL: https://issues.apache.org/jira/browse/MINIFI-236
> Project: Apache NiFi MiNiFi
> Issue Type: Bug
> Components: C++
> Reporter: marco polo
> Assignee: marco polo
> Priority: Critical
> Fix For: cpp-0.2.0
>
>
> Found that RemoteProcessingGroup was not thread safe. Had to move peer and
> protocol to be thread local variables to successfully allow more concurrent
> threads to run onTrigger.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
