[
https://issues.apache.org/jira/browse/MINIFI-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15989507#comment-15989507
]
ASF GitHub Bot commented on MINIFI-275:
---------------------------------------
GitHub user kevdoran opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/85
MINIFI-275 Bugfix for YAML Configs without Component IDs
This commit fixes a bug in which loading config YAML that did not
specify IDs (UUIDs) for components caused an exception. The logic
previously treated component IDs as required fields by loading them
without checking for existence. This commit updates the logic to
generate IDs when they are not specified in the YAML config. As part
of this fix, the logic for loading connections from YAML config was
modified to search by name or remote port id in the absence of source
id or remote id in the YAML config.
For fields that are required, useful error messages were added when
those fields are missing to assist users in self-diagnosing issues
related to invalid config files.
Some minor tweaks to the top level .gitignore are included with this
commit.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kevdoran/nifi-minifi-cpp
bugfix/MINIFI-275-configs-without-component-ids
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/85.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #85
----
commit eb7b992872a71b8c01444ef24eeae48121559a5e
Author: Kevin Doran <[email protected]>
Date: 2017-04-28T21:43:37Z
MINIFI-275 Bugfix for YAML Configs without Component IDs
This commit fixes a bug in which loading config YAML that did not
specify IDs (UUIDs) for components caused an exception. The logic
previously treated component IDs as required fields by loading them
without checking for existence. This commit updates the logic to
generate IDs when they are not specified in the YAML config. As part
of this fix, the logic for loading connections from YAML config was
modified to search by name or remote port id in the absence of source
id or remote id in the YAML config.
For fields that are required, useful error messages were added when
those fields are missing to assist users in self-diagnosing issues
related to invalid config files.
Some minor tweaks to the top level .gitignore are included with this
commit.
----
> Configuration without IDs for components causes exceptions
> ----------------------------------------------------------
>
> Key: MINIFI-275
> URL: https://issues.apache.org/jira/browse/MINIFI-275
> Project: Apache NiFi MiNiFi
> Issue Type: Bug
> Components: C++, Processing Configuration
> Reporter: Aldrin Piri
> Assignee: Kevin Doran
> Priority: Blocker
> Fix For: cpp-0.2.0
>
> Attachments: config.yml
>
>
> One of the changes to how components are handled in C++ introduced a defect
> into the original construct over the version 1 schema of the YAML.
> The absence of this ID causes a YAML exception.
> We should provide handling to support configurations how they were created
> originally, possibly providing a default/generated ID where one isn't
> specified, and start laying the foundation for versioned schemas as provided
> in our Java implementation.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
