[
https://issues.apache.org/jira/browse/MINIFI-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012816#comment-16012816
]
ASF GitHub Bot commented on MINIFI-289:
---------------------------------------
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/97
MINIFI-289: Update test folder to apply linter and set max characters…
… to 200
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFI-289
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/97.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #97
----
commit 5874c8b3f1fa646fcf1d30795410340962354290
Author: Marc Parisi <[email protected]>
Date: 2017-05-16T17:58:28Z
MINIFI-289: Update test folder to apply linter and set max characters to 200
----
> Apply C++ Linter to Tests folder and increase line length to 200 characters
> ---------------------------------------------------------------------------
>
> Key: MINIFI-289
> URL: https://issues.apache.org/jira/browse/MINIFI-289
> Project: Apache NiFi MiNiFi
> Issue Type: Test
> Components: C++
> Reporter: marco polo
> Assignee: marco polo
> Priority: Trivial
>
> Currently the C++ Google style guide linter isn't apply to the test folder.
> Apply this, fix changes, and increase the max line length to 200 to match the
> JAVA line length requirement.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
