[ 
https://issues.apache.org/jira/browse/MINIFI-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16013400#comment-16013400
 ] 

ASF GitHub Bot commented on MINIFI-226:
---------------------------------------

Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/83#discussion_r116895225
  
    --- Diff: libminifi/include/processors/TailFile.h ---
    @@ -73,8 +74,7 @@ class TailFile : public core::Processor {
       std::string _stateFile;
       // State related to the tailed file
       std::string _currentTailFileName;
    -  uint64_t _currentTailFilePosition;
    -  bool _stateRecovered;
    +  uint64_t _currentTailFilePosition;bool _stateRecovered;
    --- End diff --
    
    minor and nitpicky, but could we split these to separate lines


> Provide support for controller services
> ---------------------------------------
>
>                 Key: MINIFI-226
>                 URL: https://issues.apache.org/jira/browse/MINIFI-226
>             Project: Apache NiFi MiNiFi
>          Issue Type: New Feature
>          Components: C++, Core Framework
>            Reporter: Aldrin Piri
>            Assignee: marco polo
>
> To facilitate feature parity in the C++ implementation, we should also 
> provided Controller Services to the framework and associated configuration as 
> provided by MINIFI-154 for Java.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to