[
https://issues.apache.org/jira/browse/MINIFI-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16032218#comment-16032218
]
ASF GitHub Bot commented on MINIFI-330:
---------------------------------------
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/109
MINIFI-330: convert const char* to std::string
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFI-330
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/109.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #109
----
commit 07e1d7ce207706d5c53822f4b1a9674f4e28decc
Author: Marc Parisi <[email protected]>
Date: 2017-05-31T23:49:14Z
MINIFI-330: convert const char* to std::string
----
> Avoid downcasting host name
> ---------------------------
>
> Key: MINIFI-330
> URL: https://issues.apache.org/jira/browse/MINIFI-330
> Project: Apache NiFi MiNiFi
> Issue Type: Bug
> Reporter: marco polo
> Assignee: marco polo
> Priority: Critical
>
> We've been storing the host name and storing it as a const char *; however,
> it appears when doing so we're storing the pointer instead of copying/moving
> it resulting it changes to the null terminator. If we use a string we avoid
> this issue entirely.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
