[ 
https://issues.apache.org/jira/browse/MINIFI-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055757#comment-16055757
 ] 

ASF GitHub Bot commented on MINIFI-337:
---------------------------------------

Github user apiri commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/113#discussion_r122976076
  
    --- Diff: README.md ---
    @@ -302,17 +302,47 @@ Additionally, users can utilize the MiNiFi Toolkit 
Converter (version 0.0.1 - sc
         nifi.security.need.ClientAuth=false
         
     ### Configuring Volatile and NO-OP Repositories
    -
    +Each of the repositories can be configured to be volatile ( state kept in 
memory and flushed
    + upon restart ) or persistent. Currently, the flow file and provenance 
repositories can persist
    + to LevelDB. The content repository will persist to the local file system 
if a volatile repo
    + is not configured. 
    + 
    + To configure the repositories:
    + 
          in minifi.properties 
          
          # For Volatile Repositories:
    -     nifi.flow.repository.class.name=VolatileRepository
    -     nifi.provenance.repository.class.name=VolatileRepository
    +     nifi.flowfile.repository.class.name=VolatileFlowFileRepository
    --- End diff --
    
    Looks like this is still 
[nifi.provenance.repository.class.name](https://github.com/apache/nifi-minifi-cpp/blob/master/libminifi/src/Configure.cpp#L34).
  Totally fair game to update, but think we should make that change in 
conjunction with this doc update.


> Better Document repo configuration options.
> -------------------------------------------
>
>                 Key: MINIFI-337
>                 URL: https://issues.apache.org/jira/browse/MINIFI-337
>             Project: Apache NiFi MiNiFi
>          Issue Type: Improvement
>          Components: C++
>            Reporter: marco polo
>            Assignee: marco polo
>              Labels: Documentation
>
> With the introduction of volatile repositories come many configuration 
> options that allow modifying the installation to account for certain 
> environments. We should document caveats with examples to show when and how 
> these repository types can be used successfully.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to