[ 
https://issues.apache.org/jira/browse/MINIFI-70?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16091863#comment-16091863
 ] 

ASF GitHub Bot commented on MINIFI-70:
--------------------------------------

GitHub user benqiu2016 opened a pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/119

    MINIFI-70: enhance site2site port negotiation

    Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced
         in the commit message?
    
    - [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
    
    - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [ ] If applicable, have you updated the LICENSE file?
    - [ ] If applicable, have you updated the NOTICE file?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/benqiu2016/nifi-minifi-cpp 
port_negotiation_merge

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi-cpp/pull/119.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #119
    
----
commit 7bf30a97907b9622addd11aaf8194f72cbbc47a4
Author: Bin Qiu <[email protected]>
Date:   2017-07-18T17:24:35Z

    MINIFI-70: enhance site2site port negotiation

----


> Enhance Site to Site to autodetermine remote port
> -------------------------------------------------
>
>                 Key: MINIFI-70
>                 URL: https://issues.apache.org/jira/browse/MINIFI-70
>             Project: Apache NiFi MiNiFi
>          Issue Type: Improvement
>          Components: Agent Configuration/Installation, C++, Data Transmission
>    Affects Versions: cpp-0.0.1
>            Reporter: Aldrin Piri
>
> Currently the C++ version requires specification of the remote input ports 
> instead of automatically negotiating these properties.  This would be a nice 
> improvement to provide a similar experience as the Java Site to Site client.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to