[
https://issues.apache.org/jira/browse/MINIFI-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16106360#comment-16106360
]
ASF GitHub Bot commented on MINIFI-357:
---------------------------------------
GitHub user dtrodrigues opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/121
MINIFI-357 fixing PutFile bug that caused all writes to fail
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dtrodrigues/nifi-minifi-cpp issue-357
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/121.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #121
----
commit 38857fb6782a0cecfb946c7e00d6e556f30fe63e
Author: Dustin Rodrigues <[email protected]>
Date: 2017-07-30T07:44:44Z
MINIFI-357 fixing PutFile bug that caused all writes to fail
----
> PutFile processor always fails
> ------------------------------
>
> Key: MINIFI-357
> URL: https://issues.apache.org/jira/browse/MINIFI-357
> Project: Apache NiFi MiNiFi
> Issue Type: Bug
> Components: C++
> Reporter: Dustin Rodrigues
> Fix For: 0.3.0
>
>
> The PutFile ReadCallback process function always returns before
> `_writeSucceeded` is ever set to `true`:
> https://github.com/apache/nifi-minifi-cpp/commit/fe63485342fc0e84250887871826b9f17b1f9a94#commitcomment-23376815
> causing the operation to always fail.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
