[ https://issues.apache.org/jira/browse/MINIFI-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115505#comment-16115505 ]
ASF GitHub Bot commented on MINIFI-366: --------------------------------------- GitHub user jzonthemtn opened a pull request: https://github.com/apache/nifi-minifi/pull/90 MINIFI-366: Adds S3ConfigurationCache. This is my attempt at creating an implementation of a ConfigurationCache for S3. I'm happy to get any feedback on it. I tested it by enabling it and settings its properties in minifi-c2-context.xml and by hitting it via curl and MiNiFi's PullHttpChangeIngestor. Thank you for submitting a contribution to Apache NiFi - MiNiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [X] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [X] Has your PR been rebased against the latest commit within the target branch (typically master)? - [X] Is your initial contribution a single, squashed commit? ### For code changes: - [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi-minifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under minifi-assembly? - [X] If applicable, have you updated the NOTICE file, including the main NOTICE file found under minifi-assembly? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jzonthemtn/nifi-minifi MINIFI-366 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-minifi/pull/90.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #90 ---- commit 7b303ccc83e1ac459c471415b41d05dc824f9268 Author: jzonthemtn <jzemer...@apache.org> Date: 2017-08-05T20:16:34Z MINIFI-366: Adds S3ConfigurationCache. ---- > Add S3 implementation of ConfigurationCache to MiNiFi C2 > -------------------------------------------------------- > > Key: MINIFI-366 > URL: https://issues.apache.org/jira/browse/MINIFI-366 > Project: Apache NiFi MiNiFi > Issue Type: Task > Components: Processing Configuration > Reporter: Jeff Zemerick > Assignee: Jeff Zemerick > Priority: Minor > > Add S3 implementation of ConfigurationCache to MiNiFi C2 that lets > configurations be stored in S3. -- This message was sent by Atlassian JIRA (v6.4.14#64029)