[
https://issues.apache.org/jira/browse/MINIFI-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16128991#comment-16128991
]
ASF GitHub Bot commented on MINIFI-376:
---------------------------------------
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/128
MINIFI-376 removed defunct references to curlbuild.h
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file?
- [x] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFI-376
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/128.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #128
----
commit a037064623bae520ab6d510653ec4b36256f82f5
Author: Andrew I. Christianson <[email protected]>
Date: 2017-08-16T15:56:34Z
MINIFI-376 removed defunct references to curlbuild.h
----
> Compilation failure in 'make docker' due to missing curlbuild.h
> ---------------------------------------------------------------
>
> Key: MINIFI-376
> URL: https://issues.apache.org/jira/browse/MINIFI-376
> Project: Apache NiFi MiNiFi
> Issue Type: Bug
> Components: C++
> Reporter: Andrew Christianson
>
> The 'make docker' target is failing due to apparent missing curlbuild.h
> header:
> {code}
> [ 3%] Performing build step for 'jsoncpp_project'
> Scanning dependencies of target jsoncpp_lib_static
> [ 25%] Building CXX object
> src/lib_json/CMakeFiles/jsoncpp_lib_static.dir/json_reader.cpp.o
> [ 50%] Building CXX object
> src/lib_json/CMakeFiles/jsoncpp_lib_static.dir/json_value.cpp.o
> [ 75%] Building CXX object
> src/lib_json/CMakeFiles/jsoncpp_lib_static.dir/json_writer.cpp.o
> [100%] Linking CXX static library libjsoncpp.a
> [100%] Built target jsoncpp_lib_static
> [ 3%] Performing install step for 'jsoncpp_project'
> [100%] Built target jsoncpp_lib_static
> Install the project...
> -- Install configuration: "Release"
> -- Installing: /opt/minifi/build/jsoncpp/lib/pkgconfig/jsoncpp.pc
> -- Installing: /opt/minifi/build/jsoncpp/lib/libjsoncpp.a
> -- Installing: /opt/minifi/build/jsoncpp/include/json/allocator.h
> -- Installing: /opt/minifi/build/jsoncpp/include/json/assertions.h
> -- Installing: /opt/minifi/build/jsoncpp/include/json/autolink.h
> -- Installing: /opt/minifi/build/jsoncpp/include/json/config.h
> -- Installing: /opt/minifi/build/jsoncpp/include/json/features.h
> -- Installing: /opt/minifi/build/jsoncpp/include/json/forwards.h
> -- Installing: /opt/minifi/build/jsoncpp/include/json/json.h
> -- Installing: /opt/minifi/build/jsoncpp/include/json/reader.h
> -- Installing: /opt/minifi/build/jsoncpp/include/json/value.h
> -- Installing: /opt/minifi/build/jsoncpp/include/json/version.h
> -- Installing: /opt/minifi/build/jsoncpp/include/json/writer.h
> [ 3%] Completed 'jsoncpp_project'
> [ 3%] Built target jsoncpp_project
> Scanning dependencies of target minifi
> [ 3%] Building CXX object
> libminifi/CMakeFiles/minifi.dir/src/core/logging/LoggerConfiguration.cpp.o
> [ 4%] Building CXX object
> libminifi/CMakeFiles/minifi.dir/src/io/AtomicEntryStream.cpp.o
> [ 4%] Building CXX object
> libminifi/CMakeFiles/minifi.dir/src/io/BaseStream.cpp.o
> [ 5%] Building CXX object
> libminifi/CMakeFiles/minifi.dir/src/io/CRCStream.cpp.o
> [ 5%] Building CXX object
> libminifi/CMakeFiles/minifi.dir/src/io/ClientSocket.cpp.o
> [ 6%] Building CXX object
> libminifi/CMakeFiles/minifi.dir/src/io/DataStream.cpp.o
> [ 6%] Building CXX object
> libminifi/CMakeFiles/minifi.dir/src/io/EndianCheck.cpp.o
> [ 6%] Building CXX object
> libminifi/CMakeFiles/minifi.dir/src/io/FileStream.cpp.o
> [ 7%] Building CXX object
> libminifi/CMakeFiles/minifi.dir/src/io/Serializable.cpp.o
> [ 7%] Building CXX object
> libminifi/CMakeFiles/minifi.dir/src/io/StreamFactory.cpp.o
> [ 8%] Building CXX object
> libminifi/CMakeFiles/minifi.dir/src/io/tls/TLSSocket.cpp.o
> [ 8%] Building CXX object
> libminifi/CMakeFiles/minifi.dir/src/core/controller/ControllerServiceNode.cpp.o
> [ 9%] Building CXX object
> libminifi/CMakeFiles/minifi.dir/src/core/controller/ControllerServiceProvider.cpp.o
> [ 9%] Building CXX object
> libminifi/CMakeFiles/minifi.dir/src/core/controller/StandardControllerServiceNode.cpp.o
> [ 9%] Building CXX object
> libminifi/CMakeFiles/minifi.dir/src/controllers/SSLContextService.cpp.o
> [ 10%] Building CXX object
> libminifi/CMakeFiles/minifi.dir/src/core/ClassLoader.cpp.o
> [ 10%] Building CXX object
> libminifi/CMakeFiles/minifi.dir/src/core/ConfigurableComponent.cpp.o
> [ 11%] Building CXX object
> libminifi/CMakeFiles/minifi.dir/src/core/ConfigurationFactory.cpp.o
> In file included from
> /opt/minifi/libminifi/include/RemoteProcessorGroupPort.h:26:0,
> from
> /opt/minifi/libminifi/include/core/FlowConfiguration.h:23,
> from
> /opt/minifi/libminifi/include/core/ConfigurationFactory.h:22,
> from
> /opt/minifi/libminifi/src/core/ConfigurationFactory.cpp:25:
> /opt/minifi/libminifi/include/utils/HTTPUtils.h:26:28: fatal error:
> curl/curlbuild.h: No such file or directory
> #include <curl/curlbuild.h>
> ^
> compilation terminated.
> make[2]: *** [libminifi/CMakeFiles/minifi.dir/build.make:471:
> libminifi/CMakeFiles/minifi.dir/src/core/ConfigurationFactory.cpp.o] Error 1
> make[1]: *** [CMakeFiles/Makefile2:1884: libminifi/CMakeFiles/minifi.dir/all]
> Error 2
> make: *** [Makefile:163: all] Error 2
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
