[
https://issues.apache.org/jira/browse/MINIFI-417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16289375#comment-16289375
]
ASF GitHub Bot commented on MINIFI-417:
---------------------------------------
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/103#discussion_r156687353
--- Diff:
minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/util/ConfigTransformer.java
---
@@ -77,7 +77,7 @@
public final class ConfigTransformer {
// Underlying version of NIFI will be using
- public static final String NIFI_VERSION = "1.2.0";
+ public static final String NIFI_VERSION = "1.4.0";
--- End diff --
There appear to be a couple of different ways[1] but most of them are
pretty hacky and not sure it's worth putting in for this one variable. If the
variable was logic that was relied on for MiNiFi to work I'd probably lean
towards adding it but it's currently only used in one place[2] and that is just
for documentation within a file that in general isn't viewed by users (the
underlying nifi.properties).
[1]
https://stackoverflow.com/questions/11500533/access-maven-properties-defined-in-the-pom
[2]
https://github.com/JPercivall/nifi-minifi/blob/baac89b1ddd7a019635bd150c0cce9a37314a371/minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/util/ConfigTransformer.java#L163
> Upgrade to NiFi 1.4.0 dependencies
> ----------------------------------
>
> Key: MINIFI-417
> URL: https://issues.apache.org/jira/browse/MINIFI-417
> Project: Apache NiFi MiNiFi
> Issue Type: Improvement
> Reporter: Joseph Percivall
> Assignee: Joseph Percivall
>
> Currently, MiNiFi Java uses the 1.2.0 release of NiFi under the hood. This
> means it is not benefitting from the improvements in processors and other
> components MiNiFi inherits from core NiFi that came in 1.3.0 or 1.4.0.
> As pointed out by [~joewitt] here[1], there is a sizeable amount of work to
> keep up with the versions and potentially other options for us to explore but
> the interim we should at least try to keep up with NiFi.
> [1]
> https://issues.apache.org/jira/browse/MINIFI-255?focusedCommentId=16003969&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16003969
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
