[ 
https://issues.apache.org/jira/browse/MINIFI-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374847#comment-16374847
 ] 

ASF GitHub Bot commented on MINIFI-438:
---------------------------------------

GitHub user kevdoran opened a pull request:

    https://github.com/apache/nifi-minifi/pull/116

    MINIFI-438 Refactor MiNiFi C2 Server

    This begins refactoring MiNiFi C2 Server to lay the groundwork
    for future commits that will add new functionality, specifically,
    NiFi Registry integration as the prefered method of deploying flows
    to agents.
    
    The goal of this refactor is to reuse patterns and best practices
    established by the NiFi Registry project, with the goal being that
    one day more code can be extracted and shared across web services
    in the NiFi ecosystem (for example, authn and authz), with a secondary
    benefit being developers working on both projects will only have to
    learn one set of frameworks and patterns.
    
    Thank you for submitting a contribution to Apache NiFi - MiNiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
    
    - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi-minifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under minifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under minifi-assembly?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kevdoran/nifi-minifi minifi-c2-server

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi/pull/116.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #116
    
----
commit f14c0330dcb986686af57471ba539324257c43da
Author: Kevin Doran <kdoran@...>
Date:   2018-02-23T18:06:40Z

    MINIFI-438 Refactor MiNiFi C2 Server
    
    This commit begins refactoring MiNiFi C2 Server to lay the groundwork
    for future commits that will add new functionality, specifically,
    NiFi Registry integration as the prefered method of deploying flows
    to agents.
    
    The goal of this refactor is to reuse patterns and best practices
    established by the NiFi Registry project, with the goal being that
    one day more code can be extracted and shared across web services
    in the NiFi ecosystem (for example, authn and authz), with a secondary
    benefit being developers working on both projects will only have to
    learn one set of frameworks and patterns.

----


> Restructure MiNiFi C2 Server REST API war to use Spring Boot
> ------------------------------------------------------------
>
>                 Key: MINIFI-438
>                 URL: https://issues.apache.org/jira/browse/MINIFI-438
>             Project: Apache NiFi MiNiFi
>          Issue Type: Improvement
>          Components: Command and Control
>            Reporter: Kevin Doran
>            Assignee: Kevin Doran
>            Priority: Major
>
> NiFi Registry leveraged Spring Boot for to remove a lot of boilerplate code 
> and configuration. It also enables some nice testability for the web api.
> This ticket is to apply some of the lessons learned from building NiFi 
> Registry to the MiNiFi C2 server.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to