[
https://issues.apache.org/jira/browse/MINIFI-424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16379692#comment-16379692
]
ASF GitHub Bot commented on MINIFI-424:
---------------------------------------
GitHub user JPercivall opened a pull request:
https://github.com/apache/nifi-minifi/pull/117
MINIFI-424 Adding the ability to evaluate bootstrap properties in the…
… config YAML prior to translation into flow.xml and nifi.properties
Thank you for submitting a contribution to Apache NiFi - MiNiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi-minifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [X] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [X] If applicable, have you updated the LICENSE file, including the main
LICENSE file under minifi-assembly?
- [X] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under minifi-assembly?
### For documentation related changes:
- [X] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JPercivall/nifi-minifi MINIFI-424
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi/pull/117.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #117
----
commit 959a7cfffe76ab3795a1bfa361c3580f1f194775
Author: Joe Percivall <jpercivall@...>
Date: 2018-02-28T02:44:39Z
MINIFI-424 Adding the ability to evaluate bootstrap properties in the
config YAML prior to translation into flow.xml and nifi.properties
----
> Expose bootstrap properties in the ConfigTransformer
> ----------------------------------------------------
>
> Key: MINIFI-424
> URL: https://issues.apache.org/jira/browse/MINIFI-424
> Project: Apache NiFi MiNiFi
> Issue Type: New Feature
> Reporter: Joseph Percivall
> Assignee: Joseph Percivall
> Priority: Major
>
> The ConfigTransformer takes in the config.yml and creates the nifi.properties
> and flow.xml. In order to better support customizations on a per MiNiFi
> instance for things that aren't able to reference EL, we could expose the
> properties listed in the bootstrap.conf.
> As an example, the bootstrap conf could have properties identifying the S2S
> URL and port UUID to use. Then when MiNiFi pulls down the new config.yml it
> would translate the keys to their proper values as identified in the
> bootstrap.conf.
> The main unknown is what the "escape" identifiers would be. In EL it is "${
> ..... }" (not sure why Jira is formatting this with new lines). This would
> need to be specific enough that it doesn't collide with anything that'd be in
> the config.yml.
> Much further down the line, this could eventually evolve to expose ENV
> variables, key/values stored in a file, and maybe even basic functions as
> needed. Essentially a basic version of EL but I hesitate to call it that b/c
> I don't want users to expect all of that functionality. This should really be
> for things that can't be done via EL.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
