Repository: nifi-minifi-cpp Updated Branches: refs/heads/master 8dd7e91f9 -> ead988683
MINIFICPP-489 Addressing linter issues. This closes #326. Signed-off-by: Aldrin Piri <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/nifi-minifi-cpp/repo Commit: http://git-wip-us.apache.org/repos/asf/nifi-minifi-cpp/commit/ead98868 Tree: http://git-wip-us.apache.org/repos/asf/nifi-minifi-cpp/tree/ead98868 Diff: http://git-wip-us.apache.org/repos/asf/nifi-minifi-cpp/diff/ead98868 Branch: refs/heads/master Commit: ead988683b1f9e2381a486ac23a7b07109898d8e Parents: 8dd7e91 Author: Aldrin Piri <[email protected]> Authored: Tue May 8 14:22:42 2018 -0400 Committer: Aldrin Piri <[email protected]> Committed: Thu May 10 15:14:11 2018 -0400 ---------------------------------------------------------------------- libminifi/src/FlowController.cpp | 1 - libminifi/src/c2/C2Payload.cpp | 4 ++-- .../src/core/controller/StandardControllerServiceNode.cpp | 6 +++--- libminifi/src/utils/ByteArrayCallback.cpp | 1 - 4 files changed, 5 insertions(+), 7 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/nifi-minifi-cpp/blob/ead98868/libminifi/src/FlowController.cpp ---------------------------------------------------------------------- diff --git a/libminifi/src/FlowController.cpp b/libminifi/src/FlowController.cpp index 688c276..8d59065 100644 --- a/libminifi/src/FlowController.cpp +++ b/libminifi/src/FlowController.cpp @@ -416,7 +416,6 @@ void FlowController::initializeC2() { auto identifier = std::dynamic_pointer_cast<state::response::AgentIdentifier>(processor); if (identifier != nullptr) { - identifier->setIdentifier(identifier_str); std::string class_str; http://git-wip-us.apache.org/repos/asf/nifi-minifi-cpp/blob/ead98868/libminifi/src/c2/C2Payload.cpp ---------------------------------------------------------------------- diff --git a/libminifi/src/c2/C2Payload.cpp b/libminifi/src/c2/C2Payload.cpp index cec2a7e..91518b3 100644 --- a/libminifi/src/c2/C2Payload.cpp +++ b/libminifi/src/c2/C2Payload.cpp @@ -179,8 +179,8 @@ void C2Payload::setRawData(const std::vector<char> &data) { } void C2Payload::setRawData(const std::vector<uint8_t> &data) { - std::transform(std::begin(data), std::end(data), std::back_inserter(raw_data_),[](uint8_t c){ - return (char)c; + std::transform(std::begin(data), std::end(data), std::back_inserter(raw_data_), [](uint8_t c){ + return static_cast<char>(c); }); } http://git-wip-us.apache.org/repos/asf/nifi-minifi-cpp/blob/ead98868/libminifi/src/core/controller/StandardControllerServiceNode.cpp ---------------------------------------------------------------------- diff --git a/libminifi/src/core/controller/StandardControllerServiceNode.cpp b/libminifi/src/core/controller/StandardControllerServiceNode.cpp index ae043da..7ada440 100644 --- a/libminifi/src/core/controller/StandardControllerServiceNode.cpp +++ b/libminifi/src/core/controller/StandardControllerServiceNode.cpp @@ -55,10 +55,10 @@ bool StandardControllerServiceNode::enable() { if (nullptr != impl) { std::lock_guard<std::mutex> lock(mutex_); std::vector<std::shared_ptr<ControllerService> > services; - for(auto service : linked_controller_services_ ){ - services.push_back ( service->getControllerServiceImplementation()); + for (auto service : linked_controller_services_) { + services.push_back(service->getControllerServiceImplementation()); } - impl->setLinkedControllerServices( services ); + impl->setLinkedControllerServices(services); impl->onEnable(); } return true; http://git-wip-us.apache.org/repos/asf/nifi-minifi-cpp/blob/ead98868/libminifi/src/utils/ByteArrayCallback.cpp ---------------------------------------------------------------------- diff --git a/libminifi/src/utils/ByteArrayCallback.cpp b/libminifi/src/utils/ByteArrayCallback.cpp index b0c0dbc..fe8397f 100644 --- a/libminifi/src/utils/ByteArrayCallback.cpp +++ b/libminifi/src/utils/ByteArrayCallback.cpp @@ -43,7 +43,6 @@ int64_t StreamOutputCallback::process(std::shared_ptr<io::BaseStream> stream) { auto written = readFully(buffer.get(), size_); stream->writeData(reinterpret_cast<uint8_t*>(buffer.get()), written); return stream->getSize(); - } void StreamOutputCallback::write(char *data, size_t size) {
