This is an automated email from the ASF dual-hosted git repository.
thenatog pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nifi.git
The following commit(s) were added to refs/heads/master by this push:
new 6be47de NIFI-6296 Improved PR template messaging around commit
process.
6be47de is described below
commit 6be47de87e6eb7570d22a79ce7f6d0ced54fb645
Author: Andy LoPresto <[email protected]>
AuthorDate: Mon May 13 19:35:01 2019 -0700
NIFI-6296 Improved PR template messaging around commit process.
---
.github/PULL_REQUEST_TEMPLATE.md | 20 +++++++++++++-------
1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 108caee..5cbcb1a 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -1,5 +1,11 @@
Thank you for submitting a contribution to Apache NiFi.
+Please provide a short description of the PR here:
+
+#### Description of PR
+
+_Enables X functionality; fixes bug NIFI-YYYY._
+
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
@@ -7,19 +13,19 @@ to ensure the following steps have been taken:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
-- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
+- [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
-- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
+- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `master`)?
-- [ ] Is your initial contribution a single, squashed commit?
+- [ ] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
-- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
+- [ ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed
in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
-- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
-- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
-- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
+- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
+- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
+- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
