This is an automated email from the ASF dual-hosted git repository.
aboda pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/nifi-minifi-cpp.git
The following commit(s) were added to refs/heads/main by this push:
new 4e47492 MINIFICPP-1502 Pass name and uuid arguments as const refs
4e47492 is described below
commit 4e474928550dc08ba021359f3eff3d3e54ccd9af
Author: Gabor Gyimesi <[email protected]>
AuthorDate: Mon Apr 26 12:00:27 2021 +0200
MINIFICPP-1502 Pass name and uuid arguments as const refs
Signed-off-by: Arpad Boda <[email protected]>
This closes #1062
---
.../aws/controllerservices/AWSCredentialsService.h | 2 +-
.../controllerservices/AzureStorageCredentialsService.h | 2 +-
extensions/bustache/ApplyTemplate.h | 2 +-
extensions/civetweb/processors/ListenHTTP.h | 2 +-
extensions/coap/controllerservice/CoapConnector.h | 2 +-
extensions/gps/GetGPS.h | 2 +-
extensions/http-curl/client/HTTPClient.cpp | 2 +-
extensions/http-curl/client/HTTPClient.h | 2 +-
extensions/http-curl/processors/InvokeHTTP.h | 2 +-
extensions/http-curl/protocols/AgentPrinter.cpp | 2 +-
extensions/http-curl/protocols/AgentPrinter.h | 2 +-
extensions/http-curl/protocols/RESTReceiver.cpp | 2 +-
extensions/http-curl/protocols/RESTReceiver.h | 2 +-
extensions/http-curl/sitetosite/HTTPProtocol.h | 2 +-
extensions/http-curl/sitetosite/PeersEntity.h | 4 ++--
extensions/jni/ExecuteJavaControllerService.h | 2 +-
extensions/jni/ExecuteJavaProcessor.h | 2 +-
extensions/jni/JVMCreator.h | 2 +-
extensions/jni/jvm/JavaControllerService.h | 2 +-
extensions/libarchive/CompressContent.h | 2 +-
extensions/libarchive/FocusArchiveEntry.h | 2 +-
extensions/libarchive/ManipulateArchive.h | 2 +-
extensions/libarchive/MergeContent.h | 2 +-
extensions/libarchive/UnfocusArchiveEntry.h | 2 +-
extensions/librdkafka/PublishKafka.h | 2 +-
.../mqtt/controllerservice/MQTTControllerService.h | 4 ++--
extensions/mqtt/processors/AbstractMQTTProcessor.h | 2 +-
extensions/mqtt/processors/ConsumeMQTT.h | 2 +-
extensions/mqtt/processors/ConvertBase.h | 2 +-
extensions/mqtt/processors/ConvertHeartBeat.h | 2 +-
extensions/mqtt/processors/ConvertJSONAck.h | 2 +-
extensions/mqtt/processors/ConvertUpdate.h | 2 +-
extensions/mqtt/processors/PublishMQTT.h | 2 +-
extensions/mqtt/protocol/MQTTC2Protocol.cpp | 2 +-
extensions/mqtt/protocol/MQTTC2Protocol.h | 2 +-
extensions/opc/include/fetchopc.h | 2 +-
extensions/opc/include/opcbase.h | 2 +-
extensions/opc/include/putopc.h | 2 +-
extensions/opencv/CaptureRTSPFrame.h | 2 +-
extensions/opencv/MotionDetector.h | 2 +-
.../processors/SourceInitiatedSubscriptionListener.cpp | 2 +-
.../processors/SourceInitiatedSubscriptionListener.h | 2 +-
extensions/pcap/CapturePacket.h | 2 +-
extensions/rocksdb-repos/DatabaseContentRepository.h | 2 +-
extensions/rocksdb-repos/FlowFileRepository.h | 2 +-
extensions/rocksdb-repos/ProvenanceRepository.h | 2 +-
.../RocksDbPersistableKeyValueStoreService.cpp | 2 +-
.../controllers/RocksDbPersistableKeyValueStoreService.h | 2 +-
extensions/script/ExecuteScript.h | 2 +-
extensions/script/python/ExecutePythonProcessor.h | 2 +-
extensions/script/python/PyProcCreator.h | 2 +-
extensions/script/python/PythonCreator.h | 2 +-
extensions/sensors/GetEnvironmentalSensors.h | 2 +-
extensions/sensors/GetMovementSensors.h | 2 +-
extensions/sensors/SensorBase.h | 2 +-
extensions/sftp/processors/FetchSFTP.cpp | 2 +-
extensions/sftp/processors/FetchSFTP.h | 2 +-
extensions/sftp/processors/ListSFTP.cpp | 2 +-
extensions/sftp/processors/ListSFTP.h | 2 +-
extensions/sftp/processors/PutSFTP.cpp | 2 +-
extensions/sftp/processors/PutSFTP.h | 2 +-
extensions/sftp/processors/SFTPProcessorBase.cpp | 2 +-
extensions/sftp/processors/SFTPProcessorBase.h | 2 +-
extensions/sql/processors/ExecuteSQL.cpp | 2 +-
extensions/sql/processors/ExecuteSQL.h | 2 +-
extensions/sql/processors/PutSQL.cpp | 2 +-
extensions/sql/processors/PutSQL.h | 4 ++--
extensions/sql/processors/QueryDatabaseTable.cpp | 2 +-
extensions/sql/processors/QueryDatabaseTable.h | 2 +-
extensions/sql/processors/SQLProcessor.h | 2 +-
extensions/sql/services/DatabaseService.h | 2 +-
extensions/sql/services/ODBCConnector.h | 6 +++---
.../controllers/UnorderedMapKeyValueStoreService.cpp | 2 +-
.../controllers/UnorderedMapKeyValueStoreService.h | 2 +-
.../UnorderedMapPersistableKeyValueStoreService.cpp | 2 +-
.../UnorderedMapPersistableKeyValueStoreService.h | 2 +-
.../standard-processors/processors/AppendHostInfo.h | 2 +-
.../standard-processors/processors/ExecuteProcess.h | 2 +-
extensions/standard-processors/processors/ExtractText.h | 2 +-
.../standard-processors/processors/GenerateFlowFile.h | 2 +-
extensions/standard-processors/processors/GetFile.h | 2 +-
extensions/standard-processors/processors/GetTCP.h | 4 ++--
extensions/standard-processors/processors/HashContent.h | 2 +-
extensions/standard-processors/processors/ListenSyslog.h | 2 +-
extensions/standard-processors/processors/LogAttribute.h | 2 +-
extensions/standard-processors/processors/PutFile.h | 2 +-
.../standard-processors/processors/RetryFlowFile.h | 2 +-
.../standard-processors/processors/RouteOnAttribute.h | 2 +-
extensions/standard-processors/processors/TailFile.h | 2 +-
.../standard-processors/processors/UpdateAttribute.h | 2 +-
.../standard-processors/tests/unit/ProcessorTests.cpp | 2 +-
extensions/tensorflow/TFApplyGraph.h | 2 +-
extensions/tensorflow/TFConvertImageToTensor.h | 2 +-
extensions/tensorflow/TFExtractTopLabels.h | 2 +-
extensions/usb-camera/GetUSBCamera.h | 2 +-
extensions/windows-event-log/ConsumeWindowsEventLog.cpp | 2 +-
extensions/windows-event-log/ConsumeWindowsEventLog.h | 2 +-
extensions/windows-event-log/TailEventLog.h | 2 +-
libminifi/include/Connection.h | 16 ++++++++--------
libminifi/include/FlowFileRecord.h | 6 +++---
libminifi/include/RemoteProcessorGroupPort.h | 2 +-
libminifi/include/c2/C2Trigger.h | 2 +-
libminifi/include/c2/ControllerSocketProtocol.h | 2 +-
libminifi/include/c2/HeartBeatReporter.h | 2 +-
libminifi/include/c2/triggers/FileUpdateTrigger.h | 2 +-
.../include/controllers/LinuxPowerManagementService.h | 2 +-
libminifi/include/controllers/SSLContextService.h | 2 +-
libminifi/include/controllers/ThreadManagementService.h | 2 +-
.../include/controllers/UpdatePolicyControllerService.h | 2 +-
.../AbstractAutoPersistingKeyValueStoreService.h | 2 +-
.../keyvalue/PersistableKeyValueStoreService.h | 2 +-
libminifi/include/core/ClassLoader.h | 2 +-
libminifi/include/core/Core.h | 2 +-
libminifi/include/core/FlowConfiguration.h | 8 ++++----
libminifi/include/core/Processor.h | 2 +-
libminifi/include/core/SerializableComponent.h | 4 ++--
libminifi/include/core/controller/ControllerService.h | 2 +-
.../include/core/controller/ControllerServiceProvider.h | 2 +-
libminifi/include/core/state/nodes/AgentInformation.h | 14 +++++++-------
libminifi/include/core/state/nodes/BuildInformation.h | 2 +-
libminifi/include/core/state/nodes/MetricsBase.h | 6 +++---
libminifi/include/core/state/nodes/QueueMetrics.h | 2 +-
libminifi/include/core/state/nodes/RepositoryMetrics.h | 2 +-
libminifi/include/core/state/nodes/SchedulingNodes.h | 2 +-
libminifi/include/core/state/nodes/StateMonitor.h | 2 +-
libminifi/include/processors/ProcessorUtils.h | 2 +-
libminifi/include/sitetosite/Peer.h | 2 +-
libminifi/include/sitetosite/SiteToSiteClient.h | 14 +++++++-------
libminifi/src/Connection.cpp | 8 ++++----
.../AbstractAutoPersistingKeyValueStoreService.cpp | 2 +-
.../keyvalue/PersistableKeyValueStoreService.cpp | 2 +-
libminifi/src/core/FlowConfiguration.cpp | 6 +++---
libminifi/src/core/ProcessGroup.cpp | 2 +-
libminifi/src/core/Processor.cpp | 2 +-
libminifi/src/sitetosite/SiteToSiteClient.cpp | 2 +-
libminifi/test/KamikazeProcessor.h | 2 +-
libminifi/test/TestBase.cpp | 4 ++--
libminifi/test/flow-tests/CustomProcessors.h | 4 ++--
libminifi/test/persistence-tests/PersistenceTests.cpp | 4 ++--
libminifi/test/unit/MockClasses.h | 4 ++--
libminifi/test/unit/ProvenanceTestHelper.h | 8 ++++----
nanofi/include/cxx/CallbackProcessor.h | 2 +-
142 files changed, 187 insertions(+), 187 deletions(-)
diff --git a/extensions/aws/controllerservices/AWSCredentialsService.h
b/extensions/aws/controllerservices/AWSCredentialsService.h
index 028e743..0551b5b 100644
--- a/extensions/aws/controllerservices/AWSCredentialsService.h
+++ b/extensions/aws/controllerservices/AWSCredentialsService.h
@@ -43,7 +43,7 @@ class AWSCredentialsService : public
core::controller::ControllerService {
static const core::Property SecretKey;
static const core::Property CredentialsFile;
- explicit AWSCredentialsService(const std::string &name, const
minifi::utils::Identifier& uuid = {})
+ explicit AWSCredentialsService(const std::string &name, const
minifi::utils::Identifier &uuid = {})
: ControllerService(name, uuid) {
}
diff --git
a/extensions/azure/controllerservices/AzureStorageCredentialsService.h
b/extensions/azure/controllerservices/AzureStorageCredentialsService.h
index 9e55e55..84868e4 100644
--- a/extensions/azure/controllerservices/AzureStorageCredentialsService.h
+++ b/extensions/azure/controllerservices/AzureStorageCredentialsService.h
@@ -41,7 +41,7 @@ class AzureStorageCredentialsService : public
core::controller::ControllerServic
static const core::Property CommonStorageAccountEndpointSuffix;
static const core::Property ConnectionString;
- explicit AzureStorageCredentialsService(const std::string &name, const
minifi::utils::Identifier& uuid = {})
+ explicit AzureStorageCredentialsService(const std::string& name, const
minifi::utils::Identifier& uuid = {})
: ControllerService(name, uuid),
logger_(logging::LoggerFactory<AzureStorageCredentialsService>::getLogger()) {
}
diff --git a/extensions/bustache/ApplyTemplate.h
b/extensions/bustache/ApplyTemplate.h
index e743ca8..7b0526e 100644
--- a/extensions/bustache/ApplyTemplate.h
+++ b/extensions/bustache/ApplyTemplate.h
@@ -41,7 +41,7 @@ class ApplyTemplate : public core::Processor {
/*!
* Create a new processor
*/
- ApplyTemplate(std::string name, utils::Identifier uuid = utils::Identifier())
+ ApplyTemplate(const std::string& name, const utils::Identifier& uuid = {})
: Processor(name, uuid),
logger_(logging::LoggerFactory<ApplyTemplate>::getLogger()) {}
~ApplyTemplate() = default;
diff --git a/extensions/civetweb/processors/ListenHTTP.h
b/extensions/civetweb/processors/ListenHTTP.h
index 1904e20..adf4a76 100644
--- a/extensions/civetweb/processors/ListenHTTP.h
+++ b/extensions/civetweb/processors/ListenHTTP.h
@@ -48,7 +48,7 @@ class ListenHTTP : public core::Processor {
/*!
* Create a new processor
*/
- ListenHTTP(std::string name, utils::Identifier uuid = utils::Identifier())
+ ListenHTTP(const std::string& name, const utils::Identifier& uuid = {})
: Processor(name, uuid),
logger_(logging::LoggerFactory<ListenHTTP>::getLogger()),
batch_size_(0) {
diff --git a/extensions/coap/controllerservice/CoapConnector.h
b/extensions/coap/controllerservice/CoapConnector.h
index 7ed6197..a6412dc 100644
--- a/extensions/coap/controllerservice/CoapConnector.h
+++ b/extensions/coap/controllerservice/CoapConnector.h
@@ -44,7 +44,7 @@ namespace controllers {
*/
class CoapConnectorService : public core::controller::ControllerService {
public:
- explicit CoapConnectorService(const std::string &name, const
utils::Identifier& uuid = {})
+ explicit CoapConnectorService(const std::string &name, const
utils::Identifier &uuid = {})
: ControllerService(name, uuid) {
initialize();
}
diff --git a/extensions/gps/GetGPS.h b/extensions/gps/GetGPS.h
index b7b2b24..a9f3f38 100644
--- a/extensions/gps/GetGPS.h
+++ b/extensions/gps/GetGPS.h
@@ -32,7 +32,7 @@ namespace processors {
class GetGPS : public core::Processor {
public:
- GetGPS(std::string name, utils::Identifier uuid = utils::Identifier())
+ GetGPS(const std::string& name, const utils::Identifier& uuid = {})
: core::Processor(name, uuid),
logger_(logging::LoggerFactory<GetGPS>::getLogger()) {
gpsdHost_ = "localhost";
gpsdPort_ = "2947";
diff --git a/extensions/http-curl/client/HTTPClient.cpp
b/extensions/http-curl/client/HTTPClient.cpp
index 9e2aceb..1e3d954 100644
--- a/extensions/http-curl/client/HTTPClient.cpp
+++ b/extensions/http-curl/client/HTTPClient.cpp
@@ -43,7 +43,7 @@ HTTPClient::HTTPClient(const std::string &url, const
std::shared_ptr<minifi::con
http_session_ = curl_easy_init();
}
-HTTPClient::HTTPClient(std::string name, utils::Identifier uuid)
+HTTPClient::HTTPClient(const std::string& name, const utils::Identifier& uuid)
: core::Connectable(name, uuid) {
http_session_ = curl_easy_init();
}
diff --git a/extensions/http-curl/client/HTTPClient.h
b/extensions/http-curl/client/HTTPClient.h
index ceb36f9..b8ebd15 100644
--- a/extensions/http-curl/client/HTTPClient.h
+++ b/extensions/http-curl/client/HTTPClient.h
@@ -76,7 +76,7 @@ class HTTPClient : public BaseHTTPClient, public
core::Connectable {
public:
HTTPClient();
- HTTPClient(std::string name, utils::Identifier uuid);
+ HTTPClient(const std::string& name, const utils::Identifier& uuid);
explicit HTTPClient(const std::string &url, const
std::shared_ptr<minifi::controllers::SSLContextService> ssl_context_service =
nullptr);
diff --git a/extensions/http-curl/processors/InvokeHTTP.h
b/extensions/http-curl/processors/InvokeHTTP.h
index 9a0fca8..a853f80 100644
--- a/extensions/http-curl/processors/InvokeHTTP.h
+++ b/extensions/http-curl/processors/InvokeHTTP.h
@@ -49,7 +49,7 @@ class InvokeHTTP : public core::Processor {
/*!
* Create a new processor
*/
- InvokeHTTP(std::string name, utils::Identifier uuid = utils::Identifier())
+ InvokeHTTP(const std::string& name, const utils::Identifier& uuid = {})
: Processor(name, uuid) {
}
// Destructor
diff --git a/extensions/http-curl/protocols/AgentPrinter.cpp
b/extensions/http-curl/protocols/AgentPrinter.cpp
index 58b567f..b96c78f 100644
--- a/extensions/http-curl/protocols/AgentPrinter.cpp
+++ b/extensions/http-curl/protocols/AgentPrinter.cpp
@@ -34,7 +34,7 @@ namespace nifi {
namespace minifi {
namespace c2 {
-AgentPrinter::AgentPrinter(std::string name, utils::Identifier uuid)
+AgentPrinter::AgentPrinter(const std::string& name, const utils::Identifier&
uuid)
: HeartBeatReporter(name, uuid),
logger_(logging::LoggerFactory<AgentPrinter>::getLogger()) {
}
diff --git a/extensions/http-curl/protocols/AgentPrinter.h
b/extensions/http-curl/protocols/AgentPrinter.h
index 5b663cc..c006f15 100644
--- a/extensions/http-curl/protocols/AgentPrinter.h
+++ b/extensions/http-curl/protocols/AgentPrinter.h
@@ -40,7 +40,7 @@ namespace c2 {
*/
class AgentPrinter : public RESTProtocol, public HeartBeatReporter {
public:
- AgentPrinter(std::string name, utils::Identifier uuid = utils::Identifier());
+ AgentPrinter(const std::string& name, const utils::Identifier& uuid = {});
/**
* Initialize agent printer.
diff --git a/extensions/http-curl/protocols/RESTReceiver.cpp
b/extensions/http-curl/protocols/RESTReceiver.cpp
index bcd414a..8da78eb 100644
--- a/extensions/http-curl/protocols/RESTReceiver.cpp
+++ b/extensions/http-curl/protocols/RESTReceiver.cpp
@@ -39,7 +39,7 @@ int ssl_protocol_en(void* /*ssl_context*/, void*
/*user_data*/) {
return 0;
}
-RESTReceiver::RESTReceiver(std::string name, utils::Identifier uuid)
+RESTReceiver::RESTReceiver(const std::string& name, const utils::Identifier&
uuid)
: HeartBeatReporter(name, uuid),
logger_(logging::LoggerFactory<RESTReceiver>::getLogger()) {
}
diff --git a/extensions/http-curl/protocols/RESTReceiver.h
b/extensions/http-curl/protocols/RESTReceiver.h
index 3760330..81ee078 100644
--- a/extensions/http-curl/protocols/RESTReceiver.h
+++ b/extensions/http-curl/protocols/RESTReceiver.h
@@ -46,7 +46,7 @@ int ssl_protocol_en(void *ssl_context, void *user_data);
*/
class RESTReceiver : public RESTProtocol, public HeartBeatReporter {
public:
- RESTReceiver(std::string name, utils::Identifier uuid = utils::Identifier());
+ RESTReceiver(const std::string& name, const utils::Identifier& uuid = {});
void initialize(core::controller::ControllerServiceProvider* controller,
const std::shared_ptr<state::StateMonitor> &updateSink,
const std::shared_ptr<Configure> &configure)
override;
diff --git a/extensions/http-curl/sitetosite/HTTPProtocol.h
b/extensions/http-curl/sitetosite/HTTPProtocol.h
index ce3dff3..225b700 100644
--- a/extensions/http-curl/sitetosite/HTTPProtocol.h
+++ b/extensions/http-curl/sitetosite/HTTPProtocol.h
@@ -64,7 +64,7 @@ class HttpSiteToSiteClient : public
sitetosite::SiteToSiteClient {
/*!
* Create a new http protocol
*/
- HttpSiteToSiteClient(std::string /*name*/, utils::Identifier /*uuid*/ =
utils::Identifier())
+ HttpSiteToSiteClient(const std::string& /*name*/, const utils::Identifier&
/*uuid*/ = {})
: SiteToSiteClient(),
current_code(UNRECOGNIZED_RESPONSE_CODE),
logger_(logging::LoggerFactory<HttpSiteToSiteClient>::getLogger()) {
diff --git a/extensions/http-curl/sitetosite/PeersEntity.h
b/extensions/http-curl/sitetosite/PeersEntity.h
index 7d60bf9..166b74f 100644
--- a/extensions/http-curl/sitetosite/PeersEntity.h
+++ b/extensions/http-curl/sitetosite/PeersEntity.h
@@ -40,7 +40,7 @@ namespace sitetosite {
class PeersEntity {
public:
- static bool parse(const std::shared_ptr<logging::Logger> &logger, const
std::string &entity, utils::Identifier id, std::vector<PeerStatus>
&peer_statuses) {
+ static bool parse(const std::shared_ptr<logging::Logger> &logger, const
std::string &entity, const utils::Identifier &id, std::vector<PeerStatus>
&peer_statuses) {
try {
rapidjson::Document root;
rapidjson::ParseResult ok = root.Parse(entity.c_str());
@@ -50,7 +50,7 @@ class PeersEntity {
ss << "Failed to parse archive lens stack from JSON string with
reason: "
<< rapidjson::GetParseError_En(ok.Code())
<< " at offset " << ok.Offset();
-
+
throw Exception(ExceptionType::GENERAL_EXCEPTION, ss.str());
}
diff --git a/extensions/jni/ExecuteJavaControllerService.h
b/extensions/jni/ExecuteJavaControllerService.h
index 9162dc0..e7be54c2c 100644
--- a/extensions/jni/ExecuteJavaControllerService.h
+++ b/extensions/jni/ExecuteJavaControllerService.h
@@ -60,7 +60,7 @@ class ExecuteJavaControllerService : public
ConfigurationContext, public std::en
/*!
* Create a new processor
*/
- explicit ExecuteJavaControllerService(std::string name, utils::Identifier
uuid = utils::Identifier())
+ explicit ExecuteJavaControllerService(const std::string& name, const
utils::Identifier& uuid = {})
: ConfigurationContext(name, uuid),
contextInstance(nullptr),
clazzInstance(nullptr),
diff --git a/extensions/jni/ExecuteJavaProcessor.h
b/extensions/jni/ExecuteJavaProcessor.h
index 2fcb29b..1e018a4 100644
--- a/extensions/jni/ExecuteJavaProcessor.h
+++ b/extensions/jni/ExecuteJavaProcessor.h
@@ -57,7 +57,7 @@ class ExecuteJavaProcessor : public core::Processor {
/*!
* Create a new processor
*/
- explicit ExecuteJavaProcessor(std::string name, utils::Identifier uuid =
utils::Identifier())
+ explicit ExecuteJavaProcessor(const std::string& name, const
utils::Identifier& uuid = {})
: Processor(name, uuid),
logger_instance_(nullptr),
context_instance_(nullptr),
diff --git a/extensions/jni/JVMCreator.h b/extensions/jni/JVMCreator.h
index b586d29..6146916 100644
--- a/extensions/jni/JVMCreator.h
+++ b/extensions/jni/JVMCreator.h
@@ -40,7 +40,7 @@ namespace jni {
class JVMCreator : public minifi::core::CoreComponent {
public:
- explicit JVMCreator(const std::string &name, utils::Identifier uuid =
utils::Identifier())
+ explicit JVMCreator(const std::string &name, const utils::Identifier &uuid =
{})
: minifi::core::CoreComponent(name, uuid),
loader_(nullptr),
logger_(logging::LoggerFactory<JVMCreator>::getLogger()) {
diff --git a/extensions/jni/jvm/JavaControllerService.h
b/extensions/jni/jvm/JavaControllerService.h
index 5ab25b5..3686da8 100644
--- a/extensions/jni/jvm/JavaControllerService.h
+++ b/extensions/jni/jvm/JavaControllerService.h
@@ -46,7 +46,7 @@ namespace controllers {
*/
class JavaControllerService : public core::controller::ControllerService,
public std::enable_shared_from_this<JavaControllerService>, public JavaServicer
{
public:
- explicit JavaControllerService(const std::string &name, const
utils::Identifier& uuid = {})
+ explicit JavaControllerService(const std::string &name, const
utils::Identifier &uuid = {})
: ControllerService(name, uuid),
loader(nullptr),
logger_(logging::LoggerFactory<JavaControllerService>::getLogger()) {
diff --git a/extensions/libarchive/CompressContent.h
b/extensions/libarchive/CompressContent.h
index 1a43217..fc7851e 100644
--- a/extensions/libarchive/CompressContent.h
+++ b/extensions/libarchive/CompressContent.h
@@ -49,7 +49,7 @@ public:
/*!
* Create a new processor
*/
- explicit CompressContent(std::string name, utils::Identifier uuid =
utils::Identifier())
+ explicit CompressContent(const std::string& name, const utils::Identifier&
uuid = {})
: core::Processor(name, uuid)
, logger_(logging::LoggerFactory<CompressContent>::getLogger())
, updateFileName_(false)
diff --git a/extensions/libarchive/FocusArchiveEntry.h
b/extensions/libarchive/FocusArchiveEntry.h
index 831e2d4..71f1223 100644
--- a/extensions/libarchive/FocusArchiveEntry.h
+++ b/extensions/libarchive/FocusArchiveEntry.h
@@ -48,7 +48,7 @@ class FocusArchiveEntry : public core::Processor {
/*!
* Create a new processor
*/
- explicit FocusArchiveEntry(std::string name, utils::Identifier uuid =
utils::Identifier())
+ explicit FocusArchiveEntry(const std::string& name, const utils::Identifier&
uuid = {})
: core::Processor(name, uuid),
logger_(logging::LoggerFactory<FocusArchiveEntry>::getLogger()) {
}
diff --git a/extensions/libarchive/ManipulateArchive.h
b/extensions/libarchive/ManipulateArchive.h
index cd46a65..b630a69 100644
--- a/extensions/libarchive/ManipulateArchive.h
+++ b/extensions/libarchive/ManipulateArchive.h
@@ -41,7 +41,7 @@ using logging::Logger;
class ManipulateArchive : public core::Processor {
public:
- ManipulateArchive(std::string name, utils::Identifier uuid =
utils::Identifier())
+ ManipulateArchive(const std::string& name, const utils::Identifier& uuid =
{})
: core::Processor(name, uuid),
logger_(logging::LoggerFactory<ManipulateArchive>::getLogger()) {
}
diff --git a/extensions/libarchive/MergeContent.h
b/extensions/libarchive/MergeContent.h
index b847f04..feef7c1 100644
--- a/extensions/libarchive/MergeContent.h
+++ b/extensions/libarchive/MergeContent.h
@@ -295,7 +295,7 @@ class MergeContent : public processors::BinFiles {
/*!
* Create a new processor
*/
- explicit MergeContent(std::string name, utils::Identifier uuid =
utils::Identifier())
+ explicit MergeContent(const std::string& name, const utils::Identifier& uuid
= {})
: processors::BinFiles(name, uuid),
logger_(logging::LoggerFactory<MergeContent>::getLogger()) {
mergeStrategy_ = merge_content_options::MERGE_STRATEGY_DEFRAGMENT;
diff --git a/extensions/libarchive/UnfocusArchiveEntry.h
b/extensions/libarchive/UnfocusArchiveEntry.h
index eaeff8b..0ced070 100644
--- a/extensions/libarchive/UnfocusArchiveEntry.h
+++ b/extensions/libarchive/UnfocusArchiveEntry.h
@@ -49,7 +49,7 @@ class UnfocusArchiveEntry : public core::Processor {
/*!
* Create a new processor
*/
- explicit UnfocusArchiveEntry(std::string name, utils::Identifier uuid =
utils::Identifier())
+ explicit UnfocusArchiveEntry(const std::string& name, const
utils::Identifier& uuid = {})
: core::Processor(name, uuid),
logger_(logging::LoggerFactory<UnfocusArchiveEntry>::getLogger()){
}
diff --git a/extensions/librdkafka/PublishKafka.h
b/extensions/librdkafka/PublishKafka.h
index b538e2d..a975b35 100644
--- a/extensions/librdkafka/PublishKafka.h
+++ b/extensions/librdkafka/PublishKafka.h
@@ -88,7 +88,7 @@ class PublishKafka : public core::Processor {
static const core::Relationship Failure;
static const core::Relationship Success;
- explicit PublishKafka(std::string name, utils::Identifier uuid =
utils::Identifier())
+ explicit PublishKafka(const std::string& name, const utils::Identifier& uuid
= {})
: core::Processor(std::move(name), uuid) {
}
diff --git a/extensions/mqtt/controllerservice/MQTTControllerService.h
b/extensions/mqtt/controllerservice/MQTTControllerService.h
index 7aa2489..96f414f 100644
--- a/extensions/mqtt/controllerservice/MQTTControllerService.h
+++ b/extensions/mqtt/controllerservice/MQTTControllerService.h
@@ -57,7 +57,7 @@ class Message {
Message &operator=(const Message &other) = default;
Message &operator=(Message &&other) = default;
-
+
std::string topic_;
std::vector<uint8_t> data_;
};
@@ -68,7 +68,7 @@ class Message {
*/
class MQTTControllerService : public core::controller::ControllerService {
public:
- explicit MQTTControllerService(const std::string &name, const
utils::Identifier& uuid = {})
+ explicit MQTTControllerService(const std::string &name, const
utils::Identifier &uuid = {})
: ControllerService(name, uuid),
initialized_(false),
client_(nullptr),
diff --git a/extensions/mqtt/processors/AbstractMQTTProcessor.h
b/extensions/mqtt/processors/AbstractMQTTProcessor.h
index 835b370..5b1a28a 100644
--- a/extensions/mqtt/processors/AbstractMQTTProcessor.h
+++ b/extensions/mqtt/processors/AbstractMQTTProcessor.h
@@ -48,7 +48,7 @@ class AbstractMQTTProcessor : public core::Processor {
/*!
* Create a new processor
*/
- explicit AbstractMQTTProcessor(std::string name, utils::Identifier uuid =
utils::Identifier())
+ explicit AbstractMQTTProcessor(const std::string& name, const
utils::Identifier& uuid = {})
: core::Processor(name, uuid),
logger_(logging::LoggerFactory<AbstractMQTTProcessor>::getLogger()) {
client_ = nullptr;
diff --git a/extensions/mqtt/processors/ConsumeMQTT.h
b/extensions/mqtt/processors/ConsumeMQTT.h
index b4e39a1..536cc15 100644
--- a/extensions/mqtt/processors/ConsumeMQTT.h
+++ b/extensions/mqtt/processors/ConsumeMQTT.h
@@ -49,7 +49,7 @@ class ConsumeMQTT : public processors::AbstractMQTTProcessor {
/*!
* Create a new processor
*/
- explicit ConsumeMQTT(std::string name, utils::Identifier uuid =
utils::Identifier())
+ explicit ConsumeMQTT(const std::string& name, const utils::Identifier& uuid
= {})
: processors::AbstractMQTTProcessor(name, uuid),
logger_(logging::LoggerFactory<ConsumeMQTT>::getLogger()) {
isSubscriber_ = true;
diff --git a/extensions/mqtt/processors/ConvertBase.h
b/extensions/mqtt/processors/ConvertBase.h
index 49a129b..4a24642 100644
--- a/extensions/mqtt/processors/ConvertBase.h
+++ b/extensions/mqtt/processors/ConvertBase.h
@@ -45,7 +45,7 @@ class ConvertBase : public core::Processor, public
minifi::c2::RESTProtocol {
/*!
* Create a new processor
*/
- explicit ConvertBase(std::string name, utils::Identifier uuid =
utils::Identifier())
+ explicit ConvertBase(const std::string& name, const utils::Identifier& uuid
= {})
: core::Processor(name, uuid) {
}
// Destructor
diff --git a/extensions/mqtt/processors/ConvertHeartBeat.h
b/extensions/mqtt/processors/ConvertHeartBeat.h
index 43a1785..ee8161e 100644
--- a/extensions/mqtt/processors/ConvertHeartBeat.h
+++ b/extensions/mqtt/processors/ConvertHeartBeat.h
@@ -45,7 +45,7 @@ public:
/*!
* Create a new processor
*/
- explicit ConvertHeartBeat(std::string name, utils::Identifier uuid =
utils::Identifier())
+ explicit ConvertHeartBeat(const std::string& name, const utils::Identifier&
uuid = {})
: ConvertBase(name, uuid),
logger_(logging::LoggerFactory<ConvertHeartBeat>::getLogger()) {
}
// Destructor
diff --git a/extensions/mqtt/processors/ConvertJSONAck.h
b/extensions/mqtt/processors/ConvertJSONAck.h
index 970cf09..47f53d0 100644
--- a/extensions/mqtt/processors/ConvertJSONAck.h
+++ b/extensions/mqtt/processors/ConvertJSONAck.h
@@ -47,7 +47,7 @@ class ConvertJSONAck : public ConvertBase {
/*!
* Create a new processor
*/
- explicit ConvertJSONAck(std::string name, utils::Identifier uuid =
utils::Identifier())
+ explicit ConvertJSONAck(const std::string& name, const utils::Identifier&
uuid = {})
: ConvertBase(name, uuid),
logger_(logging::LoggerFactory<ConvertJSONAck>::getLogger()) {
}
diff --git a/extensions/mqtt/processors/ConvertUpdate.h
b/extensions/mqtt/processors/ConvertUpdate.h
index d4c9361..d24e5d4 100644
--- a/extensions/mqtt/processors/ConvertUpdate.h
+++ b/extensions/mqtt/processors/ConvertUpdate.h
@@ -50,7 +50,7 @@ class ConvertUpdate : public ConvertBase {
/*!
* Create a new processor
*/
- explicit ConvertUpdate(std::string name, utils::Identifier uuid =
utils::Identifier())
+ explicit ConvertUpdate(const std::string& name, const utils::Identifier&
uuid = {})
: ConvertBase(name, uuid),
logger_(logging::LoggerFactory<ConvertUpdate>::getLogger()) {
}
// Destructor
diff --git a/extensions/mqtt/processors/PublishMQTT.h
b/extensions/mqtt/processors/PublishMQTT.h
index d60c819..fdad09f 100644
--- a/extensions/mqtt/processors/PublishMQTT.h
+++ b/extensions/mqtt/processors/PublishMQTT.h
@@ -43,7 +43,7 @@ class PublishMQTT : public processors::AbstractMQTTProcessor {
/*!
* Create a new processor
*/
- explicit PublishMQTT(std::string name, utils::Identifier uuid =
utils::Identifier())
+ explicit PublishMQTT(const std::string& name, const utils::Identifier& uuid
= {})
: processors::AbstractMQTTProcessor(name, uuid),
logger_(logging::LoggerFactory<PublishMQTT>::getLogger()) {
retain_ = false;
diff --git a/extensions/mqtt/protocol/MQTTC2Protocol.cpp
b/extensions/mqtt/protocol/MQTTC2Protocol.cpp
index c4e316c..79acf77 100644
--- a/extensions/mqtt/protocol/MQTTC2Protocol.cpp
+++ b/extensions/mqtt/protocol/MQTTC2Protocol.cpp
@@ -23,7 +23,7 @@ namespace nifi {
namespace minifi {
namespace c2 {
-MQTTC2Protocol::MQTTC2Protocol(std::string name, utils::Identifier uuid)
+MQTTC2Protocol::MQTTC2Protocol(const std::string& name, const
utils::Identifier& uuid)
: C2Protocol(name, uuid),
logger_(logging::LoggerFactory<Connectable>::getLogger()) {
}
diff --git a/extensions/mqtt/protocol/MQTTC2Protocol.h
b/extensions/mqtt/protocol/MQTTC2Protocol.h
index 1b0e0b6..755720e 100644
--- a/extensions/mqtt/protocol/MQTTC2Protocol.h
+++ b/extensions/mqtt/protocol/MQTTC2Protocol.h
@@ -44,7 +44,7 @@ namespace c2 {
*/
class MQTTC2Protocol : public C2Protocol {
public:
- explicit MQTTC2Protocol(std::string name, utils::Identifier uuid =
utils::Identifier());
+ explicit MQTTC2Protocol(const std::string& name, const utils::Identifier&
uuid = {});
virtual ~MQTTC2Protocol();
diff --git a/extensions/opc/include/fetchopc.h
b/extensions/opc/include/fetchopc.h
index fb7fbdc..c476012 100644
--- a/extensions/opc/include/fetchopc.h
+++ b/extensions/opc/include/fetchopc.h
@@ -59,7 +59,7 @@ public:
static core::Relationship Success;
static core::Relationship Failure;
- FetchOPCProcessor(std::string name, utils::Identifier uuid =
utils::Identifier())
+ FetchOPCProcessor(const std::string& name, const utils::Identifier& uuid =
{})
: BaseOPCProcessor(name, uuid), nameSpaceIdx_(0), nodesFound_(0),
variablesFound_(0), maxDepth_(0) {
logger_ = logging::LoggerFactory<FetchOPCProcessor>::getLogger();
}
diff --git a/extensions/opc/include/opcbase.h b/extensions/opc/include/opcbase.h
index bcd20a3..54fc7f2 100644
--- a/extensions/opc/include/opcbase.h
+++ b/extensions/opc/include/opcbase.h
@@ -45,7 +45,7 @@ class BaseOPCProcessor : public core::Processor {
static core::Property KeyPath;
static core::Property TrustedPath;
- BaseOPCProcessor(std::string name, utils::Identifier uuid =
utils::Identifier())
+ BaseOPCProcessor(const std::string& name, const utils::Identifier& uuid = {})
: Processor(name, uuid) {
}
diff --git a/extensions/opc/include/putopc.h b/extensions/opc/include/putopc.h
index 5976ce6..c1d402a 100644
--- a/extensions/opc/include/putopc.h
+++ b/extensions/opc/include/putopc.h
@@ -64,7 +64,7 @@ class PutOPCProcessor : public BaseOPCProcessor {
static core::Relationship Success;
static core::Relationship Failure;
- PutOPCProcessor(std::string name, utils::Identifier uuid =
utils::Identifier())
+ PutOPCProcessor(const std::string& name, const utils::Identifier& uuid = {})
: BaseOPCProcessor(name, uuid), nameSpaceIdx_(0), parentExists_(false) {
logger_ = logging::LoggerFactory<PutOPCProcessor>::getLogger();
}
diff --git a/extensions/opencv/CaptureRTSPFrame.h
b/extensions/opencv/CaptureRTSPFrame.h
index 8fcdc9a..e0e6789 100644
--- a/extensions/opencv/CaptureRTSPFrame.h
+++ b/extensions/opencv/CaptureRTSPFrame.h
@@ -37,7 +37,7 @@ class CaptureRTSPFrame : public core::Processor {
public:
- explicit CaptureRTSPFrame(const std::string &name, utils::Identifier uuid =
utils::Identifier())
+ explicit CaptureRTSPFrame(const std::string &name, const utils::Identifier
&uuid = {})
: Processor(name, uuid),
logger_(logging::LoggerFactory<CaptureRTSPFrame>::getLogger()) {
}
diff --git a/extensions/opencv/MotionDetector.h
b/extensions/opencv/MotionDetector.h
index db9d357..5d289e2 100644
--- a/extensions/opencv/MotionDetector.h
+++ b/extensions/opencv/MotionDetector.h
@@ -40,7 +40,7 @@ class MotionDetector : public core::Processor {
public:
- explicit MotionDetector(const std::string &name, utils::Identifier uuid =
utils::Identifier())
+ explicit MotionDetector(const std::string &name, const utils::Identifier
&uuid = {})
: Processor(name, uuid),
logger_(logging::LoggerFactory<MotionDetector>::getLogger()) {
}
diff --git
a/extensions/openwsman/processors/SourceInitiatedSubscriptionListener.cpp
b/extensions/openwsman/processors/SourceInitiatedSubscriptionListener.cpp
index 2a177c4..e25567a 100644
--- a/extensions/openwsman/processors/SourceInitiatedSubscriptionListener.cpp
+++ b/extensions/openwsman/processors/SourceInitiatedSubscriptionListener.cpp
@@ -141,7 +141,7 @@ constexpr char const*
SourceInitiatedSubscriptionListener::INITIAL_EXISTING_EVEN
constexpr char const* SourceInitiatedSubscriptionListener::ProcessorName;
-SourceInitiatedSubscriptionListener::SourceInitiatedSubscriptionListener(std::string
name, utils::Identifier uuid)
+SourceInitiatedSubscriptionListener::SourceInitiatedSubscriptionListener(const
std::string& name, const utils::Identifier& uuid)
: Processor(name, uuid)
,
logger_(logging::LoggerFactory<SourceInitiatedSubscriptionListener>::getLogger())
, session_factory_(nullptr)
diff --git
a/extensions/openwsman/processors/SourceInitiatedSubscriptionListener.h
b/extensions/openwsman/processors/SourceInitiatedSubscriptionListener.h
index 8e11292..1798d33 100644
--- a/extensions/openwsman/processors/SourceInitiatedSubscriptionListener.h
+++ b/extensions/openwsman/processors/SourceInitiatedSubscriptionListener.h
@@ -54,7 +54,7 @@ class SourceInitiatedSubscriptionListener : public
core::Processor {
static constexpr char const* ProcessorName =
"SourceInitiatedSubscriptionListener";
- explicit SourceInitiatedSubscriptionListener(std::string name,
utils::Identifier uuid = utils::Identifier());
+ explicit SourceInitiatedSubscriptionListener(const std::string& name, const
utils::Identifier& uuid = {});
// Supported Properties
static core::Property ListenHostname;
diff --git a/extensions/pcap/CapturePacket.h b/extensions/pcap/CapturePacket.h
index 9cc3f4c..8e74003 100644
--- a/extensions/pcap/CapturePacket.h
+++ b/extensions/pcap/CapturePacket.h
@@ -97,7 +97,7 @@ class CapturePacket : public core::Processor {
/*!
* Create a new processor
*/
- explicit CapturePacket(std::string name, utils::Identifier uuid =
utils::Identifier())
+ explicit CapturePacket(const std::string& name, const utils::Identifier&
uuid = {})
: Processor(name, uuid),
capture_bluetooth_(false),
pcap_batch_size_(50),
diff --git a/extensions/rocksdb-repos/DatabaseContentRepository.h
b/extensions/rocksdb-repos/DatabaseContentRepository.h
index db41510..f14bb00 100644
--- a/extensions/rocksdb-repos/DatabaseContentRepository.h
+++ b/extensions/rocksdb-repos/DatabaseContentRepository.h
@@ -79,7 +79,7 @@ class DatabaseContentRepository : public
core::ContentRepository, public core::C
};
public:
- DatabaseContentRepository(std::string name =
getClassName<DatabaseContentRepository>(), utils::Identifier uuid =
utils::Identifier())
+ DatabaseContentRepository(const std::string& name =
getClassName<DatabaseContentRepository>(), const utils::Identifier& uuid = {})
: core::Connectable(name, uuid),
is_valid_(false),
db_(nullptr),
diff --git a/extensions/rocksdb-repos/FlowFileRepository.h
b/extensions/rocksdb-repos/FlowFileRepository.h
index d2b4120..e76b0d0 100644
--- a/extensions/rocksdb-repos/FlowFileRepository.h
+++ b/extensions/rocksdb-repos/FlowFileRepository.h
@@ -57,7 +57,7 @@ class FlowFileRepository : public core::Repository, public
std::enable_shared_fr
public:
// Constructor
- FlowFileRepository(std::string name, utils::Identifier /*uuid*/)
+ FlowFileRepository(const std::string& name, const utils::Identifier&
/*uuid*/)
: FlowFileRepository(name) {
}
diff --git a/extensions/rocksdb-repos/ProvenanceRepository.h
b/extensions/rocksdb-repos/ProvenanceRepository.h
index 435d388..688cfbf 100644
--- a/extensions/rocksdb-repos/ProvenanceRepository.h
+++ b/extensions/rocksdb-repos/ProvenanceRepository.h
@@ -37,7 +37,7 @@ namespace provenance {
class ProvenanceRepository : public core::Repository, public
std::enable_shared_from_this<ProvenanceRepository> {
public:
- ProvenanceRepository(std::string name, utils::Identifier /*uuid*/)
+ ProvenanceRepository(const std::string& name, const utils::Identifier&
/*uuid*/)
: ProvenanceRepository(name){
}
diff --git
a/extensions/rocksdb-repos/controllers/RocksDbPersistableKeyValueStoreService.cpp
b/extensions/rocksdb-repos/controllers/RocksDbPersistableKeyValueStoreService.cpp
index 58370bf..b964f04 100644
---
a/extensions/rocksdb-repos/controllers/RocksDbPersistableKeyValueStoreService.cpp
+++
b/extensions/rocksdb-repos/controllers/RocksDbPersistableKeyValueStoreService.cpp
@@ -31,7 +31,7 @@ core::Property
RocksDbPersistableKeyValueStoreService::Directory(
core::PropertyBuilder::createProperty("Directory")->withDescription("Path
to a directory for the database")
->isRequired(true)->build());
-RocksDbPersistableKeyValueStoreService::RocksDbPersistableKeyValueStoreService(const
std::string& name, utils::Identifier uuid /*= utils::Identifier()*/)
+RocksDbPersistableKeyValueStoreService::RocksDbPersistableKeyValueStoreService(const
std::string& name, const utils::Identifier& uuid /*= utils::Identifier()*/)
: PersistableKeyValueStoreService(name, uuid)
, AbstractAutoPersistingKeyValueStoreService(name, uuid)
,
logger_(logging::LoggerFactory<RocksDbPersistableKeyValueStoreService>::getLogger())
{
diff --git
a/extensions/rocksdb-repos/controllers/RocksDbPersistableKeyValueStoreService.h
b/extensions/rocksdb-repos/controllers/RocksDbPersistableKeyValueStoreService.h
index 2b75323..ca1d804 100644
---
a/extensions/rocksdb-repos/controllers/RocksDbPersistableKeyValueStoreService.h
+++
b/extensions/rocksdb-repos/controllers/RocksDbPersistableKeyValueStoreService.h
@@ -42,7 +42,7 @@ namespace controllers {
class RocksDbPersistableKeyValueStoreService : public
AbstractAutoPersistingKeyValueStoreService {
public:
- explicit RocksDbPersistableKeyValueStoreService(const std::string& name,
utils::Identifier uuid = utils::Identifier());
+ explicit RocksDbPersistableKeyValueStoreService(const std::string& name,
const utils::Identifier& uuid = {});
~RocksDbPersistableKeyValueStoreService() override = default;
diff --git a/extensions/script/ExecuteScript.h
b/extensions/script/ExecuteScript.h
index dd8e230..476c631 100644
--- a/extensions/script/ExecuteScript.h
+++ b/extensions/script/ExecuteScript.h
@@ -36,7 +36,7 @@ namespace processors {
class ExecuteScript : public core::Processor {
public:
- explicit ExecuteScript(const std::string &name, utils::Identifier uuid =
utils::Identifier())
+ explicit ExecuteScript(const std::string &name, const utils::Identifier
&uuid = {})
: Processor(name, uuid),
logger_(logging::LoggerFactory<ExecuteScript>::getLogger()),
script_engine_q_() {
diff --git a/extensions/script/python/ExecutePythonProcessor.h
b/extensions/script/python/ExecutePythonProcessor.h
index 3c87eb3..0057b6f 100644
--- a/extensions/script/python/ExecutePythonProcessor.h
+++ b/extensions/script/python/ExecutePythonProcessor.h
@@ -45,7 +45,7 @@ namespace processors {
class ExecutePythonProcessor : public core::Processor {
public:
- explicit ExecutePythonProcessor(const std::string &name, utils::Identifier
uuid = utils::Identifier())
+ explicit ExecutePythonProcessor(const std::string &name, const
utils::Identifier &uuid = {})
: Processor(name, uuid),
python_dynamic_(false),
valid_init_(false),
diff --git a/extensions/script/python/PyProcCreator.h
b/extensions/script/python/PyProcCreator.h
index 96ef4ae..d2cf5da 100644
--- a/extensions/script/python/PyProcCreator.h
+++ b/extensions/script/python/PyProcCreator.h
@@ -46,7 +46,7 @@ class PythonObjectFactory : public
core::DefautObjectFactory<minifi::python::pro
/**
* Create a shared pointer to a new processor.
*/
- std::shared_ptr<core::CoreComponent> create(const std::string &name, const
utils::Identifier & uuid) override {
+ std::shared_ptr<core::CoreComponent> create(const std::string &name, const
utils::Identifier &uuid) override {
auto ptr =
std::static_pointer_cast<minifi::python::processors::ExecutePythonProcessor>(DefautObjectFactory::create(name,
uuid));
ptr->initialize();
ptr->setProperty(minifi::python::processors::ExecutePythonProcessor::ScriptFile,
file_);
diff --git a/extensions/script/python/PythonCreator.h
b/extensions/script/python/PythonCreator.h
index 64d5a9c..f97d525 100644
--- a/extensions/script/python/PythonCreator.h
+++ b/extensions/script/python/PythonCreator.h
@@ -43,7 +43,7 @@ namespace python {
class PythonCreator : public minifi::core::CoreComponent {
public:
- explicit PythonCreator(const std::string &name, utils::Identifier uuid =
utils::Identifier())
+ explicit PythonCreator(const std::string &name, const utils::Identifier
&uuid = {})
: minifi::core::CoreComponent(name, uuid),
logger_(logging::LoggerFactory<PythonCreator>::getLogger()) {
}
diff --git a/extensions/sensors/GetEnvironmentalSensors.h
b/extensions/sensors/GetEnvironmentalSensors.h
index 5eeb4db..6bbab46 100644
--- a/extensions/sensors/GetEnvironmentalSensors.h
+++ b/extensions/sensors/GetEnvironmentalSensors.h
@@ -49,7 +49,7 @@ class GetEnvironmentalSensors : public SensorBase {
/*!
* Create a new processor
*/
- GetEnvironmentalSensors(std::string name, utils::Identifier uuid =
utils::Identifier())
+ GetEnvironmentalSensors(const std::string& name, const utils::Identifier&
uuid = {})
: SensorBase(name, uuid),
humidity_sensor_(nullptr),
pressure_sensor_(nullptr),
diff --git a/extensions/sensors/GetMovementSensors.h
b/extensions/sensors/GetMovementSensors.h
index 825e99e..ec0c84c 100644
--- a/extensions/sensors/GetMovementSensors.h
+++ b/extensions/sensors/GetMovementSensors.h
@@ -49,7 +49,7 @@ class GetMovementSensors : public SensorBase {
/*!
* Create a new processor
*/
- GetMovementSensors(std::string name, utils::Identifier uuid =
utils::Identifier())
+ GetMovementSensors(const std::string& name, const utils::Identifier& uuid =
{})
: SensorBase(name, uuid),
logger_(logging::LoggerFactory<GetMovementSensors>::getLogger()) {
}
diff --git a/extensions/sensors/SensorBase.h b/extensions/sensors/SensorBase.h
index 6af9bb5..0bdeb52 100644
--- a/extensions/sensors/SensorBase.h
+++ b/extensions/sensors/SensorBase.h
@@ -48,7 +48,7 @@ class SensorBase : public core::Processor {
/*!
* Create a new processor
*/
- SensorBase(std::string name, utils::Identifier uuid = utils::Identifier())
+ SensorBase(const std::string& name, const utils::Identifier& uuid = {})
: Processor(name, uuid),
imu(nullptr),
logger_(logging::LoggerFactory<SensorBase>::getLogger()) {
diff --git a/extensions/sftp/processors/FetchSFTP.cpp
b/extensions/sftp/processors/FetchSFTP.cpp
index 68ae388..ea6729e 100644
--- a/extensions/sftp/processors/FetchSFTP.cpp
+++ b/extensions/sftp/processors/FetchSFTP.cpp
@@ -115,7 +115,7 @@ void FetchSFTP::initialize() {
setSupportedRelationships(relationships);
}
-FetchSFTP::FetchSFTP(std::string name, utils::Identifier uuid /*=
utils::Identifier()*/)
+FetchSFTP::FetchSFTP(const std::string& name, const utils::Identifier& uuid
/*= utils::Identifier()*/)
: SFTPProcessorBase(name, uuid),
create_directory_(false),
disable_directory_listing_(false) {
diff --git a/extensions/sftp/processors/FetchSFTP.h
b/extensions/sftp/processors/FetchSFTP.h
index 2addc87..1910122 100644
--- a/extensions/sftp/processors/FetchSFTP.h
+++ b/extensions/sftp/processors/FetchSFTP.h
@@ -51,7 +51,7 @@ class FetchSFTP : public SFTPProcessorBase {
/*!
* Create a new processor
*/
- FetchSFTP(std::string name, utils::Identifier uuid = utils::Identifier());
+ FetchSFTP(const std::string& name, const utils::Identifier& uuid = {});
virtual ~FetchSFTP();
// Supported Properties
diff --git a/extensions/sftp/processors/ListSFTP.cpp
b/extensions/sftp/processors/ListSFTP.cpp
index 89449a2..c144ea6 100644
--- a/extensions/sftp/processors/ListSFTP.cpp
+++ b/extensions/sftp/processors/ListSFTP.cpp
@@ -173,7 +173,7 @@ void ListSFTP::initialize() {
setSupportedRelationships(relationships);
}
-ListSFTP::ListSFTP(std::string name, utils::Identifier uuid /*=
utils::Identifier()*/)
+ListSFTP::ListSFTP(const std::string& name, const utils::Identifier& uuid /*=
utils::Identifier()*/)
: SFTPProcessorBase(name, uuid)
, search_recursively_(false)
, follow_symlink_(false)
diff --git a/extensions/sftp/processors/ListSFTP.h
b/extensions/sftp/processors/ListSFTP.h
index 6439f7f..29353de 100644
--- a/extensions/sftp/processors/ListSFTP.h
+++ b/extensions/sftp/processors/ListSFTP.h
@@ -64,7 +64,7 @@ class ListSFTP : public SFTPProcessorBase {
/*!
* Create a new processor
*/
- ListSFTP(std::string name, utils::Identifier uuid = utils::Identifier());
+ ListSFTP(const std::string& name, const utils::Identifier& uuid = {});
virtual ~ListSFTP();
// Supported Properties
diff --git a/extensions/sftp/processors/PutSFTP.cpp
b/extensions/sftp/processors/PutSFTP.cpp
index b55148a..1fdc1b4 100644
--- a/extensions/sftp/processors/PutSFTP.cpp
+++ b/extensions/sftp/processors/PutSFTP.cpp
@@ -157,7 +157,7 @@ void PutSFTP::initialize() {
setSupportedRelationships(relationships);
}
-PutSFTP::PutSFTP(std::string name, utils::Identifier uuid /*=
utils::Identifier()*/)
+PutSFTP::PutSFTP(const std::string& name, const utils::Identifier& uuid /*=
utils::Identifier()*/)
: SFTPProcessorBase(name, uuid),
create_directory_(false),
batch_size_(0),
diff --git a/extensions/sftp/processors/PutSFTP.h
b/extensions/sftp/processors/PutSFTP.h
index 099a741..543200b 100644
--- a/extensions/sftp/processors/PutSFTP.h
+++ b/extensions/sftp/processors/PutSFTP.h
@@ -61,7 +61,7 @@ namespace processors {
/*!
* Create a new processor
*/
- PutSFTP(std::string name, utils::Identifier uuid = utils::Identifier());
+ PutSFTP(const std::string& name, const utils::Identifier& uuid = {});
virtual ~PutSFTP();
// Supported Properties
diff --git a/extensions/sftp/processors/SFTPProcessorBase.cpp
b/extensions/sftp/processors/SFTPProcessorBase.cpp
index 96e97d5..a35ffd5 100644
--- a/extensions/sftp/processors/SFTPProcessorBase.cpp
+++ b/extensions/sftp/processors/SFTPProcessorBase.cpp
@@ -108,7 +108,7 @@ constexpr char const* SFTPProcessorBase::PROXY_TYPE_SOCKS;
constexpr size_t SFTPProcessorBase::CONNECTION_CACHE_MAX_SIZE;
-SFTPProcessorBase::SFTPProcessorBase(std::string name, utils::Identifier uuid)
+SFTPProcessorBase::SFTPProcessorBase(const std::string& name, const
utils::Identifier& uuid)
: Processor(name, uuid),
connection_timeout_(0),
data_timeout_(0),
diff --git a/extensions/sftp/processors/SFTPProcessorBase.h
b/extensions/sftp/processors/SFTPProcessorBase.h
index ecf7c9e..7f5556b 100644
--- a/extensions/sftp/processors/SFTPProcessorBase.h
+++ b/extensions/sftp/processors/SFTPProcessorBase.h
@@ -46,7 +46,7 @@ namespace processors {
class SFTPProcessorBase : public core::Processor {
public:
- SFTPProcessorBase(std::string name, utils::Identifier uuid);
+ SFTPProcessorBase(const std::string& name, const utils::Identifier& uuid);
virtual ~SFTPProcessorBase();
// Supported Properties
diff --git a/extensions/sql/processors/ExecuteSQL.cpp
b/extensions/sql/processors/ExecuteSQL.cpp
index bae2282..b952fb7 100644
--- a/extensions/sql/processors/ExecuteSQL.cpp
+++ b/extensions/sql/processors/ExecuteSQL.cpp
@@ -55,7 +55,7 @@ const core::Relationship ExecuteSQL::Success("success",
"Successfully created Fl
const std::string ExecuteSQL::RESULT_ROW_COUNT = "executesql.row.count";
const std::string ExecuteSQL::INPUT_FLOW_FILE_UUID = "input.flowfile.uuid";
-ExecuteSQL::ExecuteSQL(const std::string& name, utils::Identifier uuid)
+ExecuteSQL::ExecuteSQL(const std::string& name, const utils::Identifier& uuid)
: SQLProcessor(name, uuid, logging::LoggerFactory<ExecuteSQL>::getLogger()) {
}
diff --git a/extensions/sql/processors/ExecuteSQL.h
b/extensions/sql/processors/ExecuteSQL.h
index 015b11a..be56837 100644
--- a/extensions/sql/processors/ExecuteSQL.h
+++ b/extensions/sql/processors/ExecuteSQL.h
@@ -37,7 +37,7 @@ namespace processors {
//! ExecuteSQL Class
class ExecuteSQL : public SQLProcessor, public FlowFileSource {
public:
- explicit ExecuteSQL(const std::string& name, utils::Identifier uuid =
utils::Identifier());
+ explicit ExecuteSQL(const std::string& name, const utils::Identifier& uuid =
{});
//! Processor Name
static const std::string ProcessorName;
diff --git a/extensions/sql/processors/PutSQL.cpp
b/extensions/sql/processors/PutSQL.cpp
index 2e4814b..ee8b4ce 100644
--- a/extensions/sql/processors/PutSQL.cpp
+++ b/extensions/sql/processors/PutSQL.cpp
@@ -53,7 +53,7 @@ const core::Property PutSQL::SQLStatement(
const core::Relationship PutSQL::Success("success", "Database is successfully
updated.");
-PutSQL::PutSQL(const std::string& name, utils::Identifier uuid)
+PutSQL::PutSQL(const std::string& name, const utils::Identifier& uuid)
: SQLProcessor(name, uuid, logging::LoggerFactory<PutSQL>::getLogger()) {
}
diff --git a/extensions/sql/processors/PutSQL.h
b/extensions/sql/processors/PutSQL.h
index 1e4dc9e..6e249d4 100644
--- a/extensions/sql/processors/PutSQL.h
+++ b/extensions/sql/processors/PutSQL.h
@@ -35,14 +35,14 @@ namespace processors {
//! PutSQL Class
class PutSQL: public SQLProcessor {
public:
- explicit PutSQL(const std::string& name, utils::Identifier uuid =
utils::Identifier());
+ explicit PutSQL(const std::string& name, const utils::Identifier& uuid = {});
//! Processor Name
static const std::string ProcessorName;
void processOnSchedule(core::ProcessContext& context) override;
void processOnTrigger(core::ProcessContext& context, core::ProcessSession&
session) override;
-
+
void initialize() override;
static const core::Property SQLStatement;
diff --git a/extensions/sql/processors/QueryDatabaseTable.cpp
b/extensions/sql/processors/QueryDatabaseTable.cpp
index a136cb0..e49bdb5 100644
--- a/extensions/sql/processors/QueryDatabaseTable.cpp
+++ b/extensions/sql/processors/QueryDatabaseTable.cpp
@@ -92,7 +92,7 @@ const std::string QueryDatabaseTable::TABLENAME_KEY =
"tablename";
const std::string QueryDatabaseTable::MAXVALUE_KEY_PREFIX = "maxvalue.";
// QueryDatabaseTable
-QueryDatabaseTable::QueryDatabaseTable(const std::string& name,
utils::Identifier uuid)
+QueryDatabaseTable::QueryDatabaseTable(const std::string& name, const
utils::Identifier& uuid)
: SQLProcessor(name, uuid,
logging::LoggerFactory<QueryDatabaseTable>::getLogger()) {
}
diff --git a/extensions/sql/processors/QueryDatabaseTable.h
b/extensions/sql/processors/QueryDatabaseTable.h
index de397c0..345ee87 100644
--- a/extensions/sql/processors/QueryDatabaseTable.h
+++ b/extensions/sql/processors/QueryDatabaseTable.h
@@ -39,7 +39,7 @@ namespace processors {
//! QueryDatabaseTable Class
class QueryDatabaseTable: public SQLProcessor, public FlowFileSource {
public:
- explicit QueryDatabaseTable(const std::string& name, utils::Identifier uuid
= utils::Identifier());
+ explicit QueryDatabaseTable(const std::string& name, const
utils::Identifier& uuid = {});
static const std::string RESULT_TABLE_NAME;
static const std::string RESULT_ROW_COUNT;
diff --git a/extensions/sql/processors/SQLProcessor.h
b/extensions/sql/processors/SQLProcessor.h
index 73e50b3..6def80d 100644
--- a/extensions/sql/processors/SQLProcessor.h
+++ b/extensions/sql/processors/SQLProcessor.h
@@ -38,7 +38,7 @@ class SQLProcessor: public core::Processor {
static const core::Property DBControllerService;
protected:
- SQLProcessor(const std::string& name, utils::Identifier uuid,
std::shared_ptr<logging::Logger> logger)
+ SQLProcessor(const std::string& name, const utils::Identifier& uuid,
std::shared_ptr<logging::Logger> logger)
: core::Processor(name, uuid), logger_(std::move(logger)) {
}
diff --git a/extensions/sql/services/DatabaseService.h
b/extensions/sql/services/DatabaseService.h
index e497d92..9967a4f 100644
--- a/extensions/sql/services/DatabaseService.h
+++ b/extensions/sql/services/DatabaseService.h
@@ -40,7 +40,7 @@ namespace controllers {
*/
class DatabaseService : public core::controller::ControllerService {
public:
- explicit DatabaseService(const std::string &name, const utils::Identifier&
uuid = {})
+ explicit DatabaseService(const std::string &name, const utils::Identifier
&uuid = {})
: ControllerService(name, uuid),
initialized_(false),
logger_(logging::LoggerFactory<DatabaseService>::getLogger()) {
diff --git a/extensions/sql/services/ODBCConnector.h
b/extensions/sql/services/ODBCConnector.h
index 43caf2c..16a3562 100644
--- a/extensions/sql/services/ODBCConnector.h
+++ b/extensions/sql/services/ODBCConnector.h
@@ -16,7 +16,7 @@
* limitations under the License.
*/
-#pragma once
+#pragma once
#include "core/logging/LoggerConfiguration.h"
#include "core/controller/ControllerService.h"
@@ -50,7 +50,7 @@ class ODBCConnection : public sql::Connection {
bool connected(std::string& exception) const override {
try {
exception.clear();
- // According to
https://stackoverflow.com/questions/3668506/efficient-sql-test-query-or-validation-query-that-will-work-across-all-or-most
by Rob Hruska,
+ // According to
https://stackoverflow.com/questions/3668506/efficient-sql-test-query-or-validation-query-that-will-work-across-all-or-most
by Rob Hruska,
// 'select 1' works for: H2, MySQL, Microsoft SQL Server, PostgreSQL,
SQLite. For Oracle 'SELECT 1 FROM DUAL' works.
prepareStatement("select 1")->execute();
return true;
@@ -90,7 +90,7 @@ class ODBCConnection : public sql::Connection {
*/
class ODBCService : public DatabaseService {
public:
- explicit ODBCService(const std::string &name, utils::Identifier uuid =
utils::Identifier())
+ explicit ODBCService(const std::string &name, const utils::Identifier &uuid
= {})
: DatabaseService(name, uuid),
logger_(logging::LoggerFactory<ODBCService>::getLogger()) {
initialize();
diff --git
a/extensions/standard-processors/controllers/UnorderedMapKeyValueStoreService.cpp
b/extensions/standard-processors/controllers/UnorderedMapKeyValueStoreService.cpp
index ca01622..2822421 100644
---
a/extensions/standard-processors/controllers/UnorderedMapKeyValueStoreService.cpp
+++
b/extensions/standard-processors/controllers/UnorderedMapKeyValueStoreService.cpp
@@ -23,7 +23,7 @@ namespace nifi {
namespace minifi {
namespace controllers {
-UnorderedMapKeyValueStoreService::UnorderedMapKeyValueStoreService(const
std::string& name, utils::Identifier uuid /*= utils::Identifier()*/)
+UnorderedMapKeyValueStoreService::UnorderedMapKeyValueStoreService(const
std::string& name, const utils::Identifier& uuid /*= utils::Identifier()*/)
: PersistableKeyValueStoreService(name, uuid)
,
logger_(logging::LoggerFactory<UnorderedMapKeyValueStoreService>::getLogger()) {
}
diff --git
a/extensions/standard-processors/controllers/UnorderedMapKeyValueStoreService.h
b/extensions/standard-processors/controllers/UnorderedMapKeyValueStoreService.h
index a6eb795..e1c1d97 100644
---
a/extensions/standard-processors/controllers/UnorderedMapKeyValueStoreService.h
+++
b/extensions/standard-processors/controllers/UnorderedMapKeyValueStoreService.h
@@ -40,7 +40,7 @@ namespace controllers {
/// Key-value store serice purely in RAM without disk usage
class UnorderedMapKeyValueStoreService : virtual public
PersistableKeyValueStoreService {
public:
- explicit UnorderedMapKeyValueStoreService(const std::string& name,
utils::Identifier uuid = utils::Identifier());
+ explicit UnorderedMapKeyValueStoreService(const std::string& name, const
utils::Identifier& uuid = {});
explicit UnorderedMapKeyValueStoreService(const std::string& name, const
std::shared_ptr<Configure>& configuration);
~UnorderedMapKeyValueStoreService() override;
diff --git
a/extensions/standard-processors/controllers/UnorderedMapPersistableKeyValueStoreService.cpp
b/extensions/standard-processors/controllers/UnorderedMapPersistableKeyValueStoreService.cpp
index e34ac94..47565b4 100644
---
a/extensions/standard-processors/controllers/UnorderedMapPersistableKeyValueStoreService.cpp
+++
b/extensions/standard-processors/controllers/UnorderedMapPersistableKeyValueStoreService.cpp
@@ -58,7 +58,7 @@ core::Property
UnorderedMapPersistableKeyValueStoreService::File(
core::PropertyBuilder::createProperty("File")->withDescription("Path to a
file to store state")
->isRequired(true)->build());
-UnorderedMapPersistableKeyValueStoreService::UnorderedMapPersistableKeyValueStoreService(const
std::string& name, utils::Identifier uuid /*= utils::Identifier()*/)
+UnorderedMapPersistableKeyValueStoreService::UnorderedMapPersistableKeyValueStoreService(const
std::string& name, const utils::Identifier& uuid /*= utils::Identifier()*/)
: PersistableKeyValueStoreService(name, uuid)
, AbstractAutoPersistingKeyValueStoreService(name, uuid)
, UnorderedMapKeyValueStoreService(name, uuid)
diff --git
a/extensions/standard-processors/controllers/UnorderedMapPersistableKeyValueStoreService.h
b/extensions/standard-processors/controllers/UnorderedMapPersistableKeyValueStoreService.h
index 306cfaf..a4bf6b7 100644
---
a/extensions/standard-processors/controllers/UnorderedMapPersistableKeyValueStoreService.h
+++
b/extensions/standard-processors/controllers/UnorderedMapPersistableKeyValueStoreService.h
@@ -40,7 +40,7 @@ namespace controllers {
class UnorderedMapPersistableKeyValueStoreService : public
AbstractAutoPersistingKeyValueStoreService,
public
UnorderedMapKeyValueStoreService {
public:
- explicit UnorderedMapPersistableKeyValueStoreService(const std::string&
name, utils::Identifier uuid = utils::Identifier());
+ explicit UnorderedMapPersistableKeyValueStoreService(const std::string&
name, const utils::Identifier& uuid = {});
explicit UnorderedMapPersistableKeyValueStoreService(const std::string&
name, const std::shared_ptr<Configure>& configuration);
~UnorderedMapPersistableKeyValueStoreService() override;
diff --git a/extensions/standard-processors/processors/AppendHostInfo.h
b/extensions/standard-processors/processors/AppendHostInfo.h
index a3acc31..e319ac6 100644
--- a/extensions/standard-processors/processors/AppendHostInfo.h
+++ b/extensions/standard-processors/processors/AppendHostInfo.h
@@ -44,7 +44,7 @@ class AppendHostInfo : public core::Processor {
/*!
* Create a new processor
*/
- AppendHostInfo(std::string name, utils::Identifier uuid =
utils::Identifier()) // NOLINT
+ AppendHostInfo(const std::string& name, const utils::Identifier& uuid = {})
// NOLINT
: core::Processor(name, uuid),
logger_(logging::LoggerFactory<AppendHostInfo>::getLogger()) {
}
diff --git a/extensions/standard-processors/processors/ExecuteProcess.h
b/extensions/standard-processors/processors/ExecuteProcess.h
index 49bf3a7..51d72fd 100644
--- a/extensions/standard-processors/processors/ExecuteProcess.h
+++ b/extensions/standard-processors/processors/ExecuteProcess.h
@@ -57,7 +57,7 @@ class ExecuteProcess : public core::Processor {
/*!
* Create a new processor
*/
- ExecuteProcess(std::string name, utils::Identifier uuid =
utils::Identifier()) // NOLINT
+ ExecuteProcess(const std::string& name, const utils::Identifier& uuid = {})
// NOLINT
: Processor(name, uuid),
logger_(logging::LoggerFactory<ExecuteProcess>::getLogger()) {
_redirectErrorStream = false;
diff --git a/extensions/standard-processors/processors/ExtractText.h
b/extensions/standard-processors/processors/ExtractText.h
index 10c9017..173b449 100644
--- a/extensions/standard-processors/processors/ExtractText.h
+++ b/extensions/standard-processors/processors/ExtractText.h
@@ -42,7 +42,7 @@ class ExtractText : public core::Processor {
/*!
* Create a new processor
*/
- explicit ExtractText(std::string name, utils::Identifier uuid =
utils::Identifier())
+ explicit ExtractText(const std::string& name, const utils::Identifier&
uuid = {})
: Processor(name, uuid) {
logger_ = logging::LoggerFactory<ExtractText>::getLogger();
}
diff --git a/extensions/standard-processors/processors/GenerateFlowFile.h
b/extensions/standard-processors/processors/GenerateFlowFile.h
index 6211f59..7ac9ee2 100644
--- a/extensions/standard-processors/processors/GenerateFlowFile.h
+++ b/extensions/standard-processors/processors/GenerateFlowFile.h
@@ -44,7 +44,7 @@ class GenerateFlowFile : public core::Processor {
/*!
* Create a new processor
*/
- GenerateFlowFile(std::string name, utils::Identifier uuid =
utils::Identifier()) // NOLINT
+ GenerateFlowFile(const std::string& name, const utils::Identifier& uuid =
{}) // NOLINT
: Processor(name, uuid),
logger_(logging::LoggerFactory<GenerateFlowFile>::getLogger()) {
batchSize_ = 1;
uniqueFlowFile_ = true;
diff --git a/extensions/standard-processors/processors/GetFile.h
b/extensions/standard-processors/processors/GetFile.h
index 4c350fa..b1f4933 100644
--- a/extensions/standard-processors/processors/GetFile.h
+++ b/extensions/standard-processors/processors/GetFile.h
@@ -61,7 +61,7 @@ class GetFileMetrics : public state::response::ResponseNode {
input_bytes_ = 0;
}
- GetFileMetrics(std::string name, utils::Identifier &uuid)
+ GetFileMetrics(const std::string& name, const utils::Identifier& uuid)
: state::response::ResponseNode(name, uuid) {
iterations_ = 0;
accepted_files_ = 0;
diff --git a/extensions/standard-processors/processors/GetTCP.h
b/extensions/standard-processors/processors/GetTCP.h
index f0cb78c..c2a5b49 100644
--- a/extensions/standard-processors/processors/GetTCP.h
+++ b/extensions/standard-processors/processors/GetTCP.h
@@ -125,7 +125,7 @@ class GetTCPMetrics : public state::response::ResponseNode {
: state::response::ResponseNode("GetTCPMetrics") {
}
- GetTCPMetrics(const std::string& name, utils::Identifier &uuid)
+ GetTCPMetrics(const std::string& name, const utils::Identifier& uuid)
: state::response::ResponseNode(name, uuid) {
}
~GetTCPMetrics() override = default;
@@ -172,7 +172,7 @@ class GetTCP : public core::Processor, public
state::response::MetricsNodeSource
/*!
* Create a new processor
*/
- explicit GetTCP(const std::string& name, utils::Identifier uuid =
utils::Identifier())
+ explicit GetTCP(const std::string& name, const utils::Identifier& uuid = {})
: Processor(name, uuid),
running_(false),
stay_connected_(true),
diff --git a/extensions/standard-processors/processors/HashContent.h
b/extensions/standard-processors/processors/HashContent.h
index 1467cfb..b8c562e 100644
--- a/extensions/standard-processors/processors/HashContent.h
+++ b/extensions/standard-processors/processors/HashContent.h
@@ -137,7 +137,7 @@ class HashContent : public core::Processor {
/*!
* Create a new processor
*/
- explicit HashContent(std::string name, utils::Identifier uuid =
utils::Identifier())
+ explicit HashContent(const std::string& name, const utils::Identifier& uuid
= {})
: Processor(name, uuid) {
logger_ = logging::LoggerFactory<HashContent>::getLogger();
}
diff --git a/extensions/standard-processors/processors/ListenSyslog.h
b/extensions/standard-processors/processors/ListenSyslog.h
index 7bf0303..f54827f 100644
--- a/extensions/standard-processors/processors/ListenSyslog.h
+++ b/extensions/standard-processors/processors/ListenSyslog.h
@@ -73,7 +73,7 @@ class ListenSyslog : public core::Processor {
/*!
* Create a new processor
*/
- ListenSyslog(std::string name, utils::Identifier uuid =
utils::Identifier()) // NOLINT
+ ListenSyslog(const std::string& name, const utils::Identifier& uuid = {})
// NOLINT
: Processor(name, uuid),
logger_(logging::LoggerFactory<ListenSyslog>::getLogger()) {
_eventQueueByteSize = 0;
diff --git a/extensions/standard-processors/processors/LogAttribute.h
b/extensions/standard-processors/processors/LogAttribute.h
index 969f329..6d4b2ef 100644
--- a/extensions/standard-processors/processors/LogAttribute.h
+++ b/extensions/standard-processors/processors/LogAttribute.h
@@ -46,7 +46,7 @@ class LogAttribute : public core::Processor {
/*!
* Create a new processor
*/
- explicit LogAttribute(std::string name, utils::Identifier uuid =
utils::Identifier())
+ explicit LogAttribute(const std::string& name, const utils::Identifier& uuid
= {})
: Processor(std::move(name), uuid),
flowfiles_to_log_(1),
hexencode_(false),
diff --git a/extensions/standard-processors/processors/PutFile.h
b/extensions/standard-processors/processors/PutFile.h
index acba760..c09bffb 100644
--- a/extensions/standard-processors/processors/PutFile.h
+++ b/extensions/standard-processors/processors/PutFile.h
@@ -49,7 +49,7 @@ class PutFile : public core::Processor {
/*!
* Create a new processor
*/
- PutFile(std::string name, utils::Identifier uuid = utils::Identifier()) //
NOLINT
+ PutFile(const std::string& name, const utils::Identifier& uuid = {}) //
NOLINT
: core::Processor(std::move(name), uuid),
logger_(logging::LoggerFactory<PutFile>::getLogger()) {
}
diff --git a/extensions/standard-processors/processors/RetryFlowFile.h
b/extensions/standard-processors/processors/RetryFlowFile.h
index 0fc4840..3eda165 100644
--- a/extensions/standard-processors/processors/RetryFlowFile.h
+++ b/extensions/standard-processors/processors/RetryFlowFile.h
@@ -42,7 +42,7 @@ namespace processors {
class RetryFlowFile : public core::Processor {
public:
- explicit RetryFlowFile(std::string name, utils::Identifier uuid =
utils::Identifier())
+ explicit RetryFlowFile(const std::string& name, const utils::Identifier&
uuid = {})
: Processor(name, uuid),
logger_(logging::LoggerFactory<RetryFlowFile>::getLogger()) {}
// Destructor
diff --git a/extensions/standard-processors/processors/RouteOnAttribute.h
b/extensions/standard-processors/processors/RouteOnAttribute.h
index fff1a04..82a5a35 100644
--- a/extensions/standard-processors/processors/RouteOnAttribute.h
+++ b/extensions/standard-processors/processors/RouteOnAttribute.h
@@ -39,7 +39,7 @@ namespace processors {
class RouteOnAttribute : public core::Processor {
public:
- RouteOnAttribute(std::string name, utils::Identifier uuid =
utils::Identifier()) // NOLINT
+ RouteOnAttribute(const std::string& name, const utils::Identifier& uuid =
{}) // NOLINT
: core::Processor(name, uuid),
logger_(logging::LoggerFactory<RouteOnAttribute>::getLogger()) {
}
diff --git a/extensions/standard-processors/processors/TailFile.h
b/extensions/standard-processors/processors/TailFile.h
index 4b5efbf..776b8ee 100644
--- a/extensions/standard-processors/processors/TailFile.h
+++ b/extensions/standard-processors/processors/TailFile.h
@@ -73,7 +73,7 @@ enum class Mode {
class TailFile : public core::Processor {
public:
- explicit TailFile(std::string name, utils::Identifier uuid =
utils::Identifier())
+ explicit TailFile(const std::string& name, const utils::Identifier& uuid =
{})
: core::Processor(std::move(name), uuid),
logger_(logging::LoggerFactory<TailFile>::getLogger()) {
}
diff --git a/extensions/standard-processors/processors/UpdateAttribute.h
b/extensions/standard-processors/processors/UpdateAttribute.h
index cddaed8..b566ec0 100644
--- a/extensions/standard-processors/processors/UpdateAttribute.h
+++ b/extensions/standard-processors/processors/UpdateAttribute.h
@@ -39,7 +39,7 @@ namespace processors {
class UpdateAttribute : public core::Processor {
public:
- UpdateAttribute(std::string name, utils::Identifier uuid =
utils::Identifier()) // NOLINT
+ UpdateAttribute(const std::string& name, const utils::Identifier& uuid =
{}) // NOLINT
: core::Processor(name, uuid),
logger_(logging::LoggerFactory<UpdateAttribute>::getLogger()) {
}
diff --git a/extensions/standard-processors/tests/unit/ProcessorTests.cpp
b/extensions/standard-processors/tests/unit/ProcessorTests.cpp
index 784ed11..642be14 100644
--- a/extensions/standard-processors/tests/unit/ProcessorTests.cpp
+++ b/extensions/standard-processors/tests/unit/ProcessorTests.cpp
@@ -498,7 +498,7 @@ TEST_CASE("Test Find file", "[getfileCreate3]") {
class TestProcessorNoContent : public minifi::core::Processor {
public:
- explicit TestProcessorNoContent(std::string name, utils::Identifier uuid =
{})
+ explicit TestProcessorNoContent(const std::string& name, const
utils::Identifier& uuid = {})
: Processor(name, uuid),
Success("success", "All files are routed to success") {
}
diff --git a/extensions/tensorflow/TFApplyGraph.h
b/extensions/tensorflow/TFApplyGraph.h
index 446b08d..3f26872 100644
--- a/extensions/tensorflow/TFApplyGraph.h
+++ b/extensions/tensorflow/TFApplyGraph.h
@@ -33,7 +33,7 @@ namespace processors {
class TFApplyGraph : public core::Processor {
public:
- explicit TFApplyGraph(const std::string &name, utils::Identifier uuid =
utils::Identifier())
+ explicit TFApplyGraph(const std::string &name, const utils::Identifier &uuid
= {})
: Processor(name, uuid),
logger_(logging::LoggerFactory<TFApplyGraph>::getLogger()) {
}
diff --git a/extensions/tensorflow/TFConvertImageToTensor.h
b/extensions/tensorflow/TFConvertImageToTensor.h
index dc0a02b..da3a11c 100644
--- a/extensions/tensorflow/TFConvertImageToTensor.h
+++ b/extensions/tensorflow/TFConvertImageToTensor.h
@@ -33,7 +33,7 @@ namespace processors {
class TFConvertImageToTensor : public core::Processor {
public:
- explicit TFConvertImageToTensor(const std::string &name, utils::Identifier
uuid = utils::Identifier())
+ explicit TFConvertImageToTensor(const std::string &name, const
utils::Identifier &uuid = {})
: Processor(name, uuid),
logger_(logging::LoggerFactory<TFConvertImageToTensor>::getLogger()) {
}
diff --git a/extensions/tensorflow/TFExtractTopLabels.h
b/extensions/tensorflow/TFExtractTopLabels.h
index 7288e84..a1b2211 100644
--- a/extensions/tensorflow/TFExtractTopLabels.h
+++ b/extensions/tensorflow/TFExtractTopLabels.h
@@ -33,7 +33,7 @@ namespace processors {
class TFExtractTopLabels : public core::Processor {
public:
- explicit TFExtractTopLabels(const std::string &name, utils::Identifier uuid
= utils::Identifier())
+ explicit TFExtractTopLabels(const std::string &name, const utils::Identifier
&uuid = {})
: Processor(name, uuid),
logger_(logging::LoggerFactory<TFExtractTopLabels>::getLogger()) {
}
diff --git a/extensions/usb-camera/GetUSBCamera.h
b/extensions/usb-camera/GetUSBCamera.h
index 15fc1fc..ac28b1e 100644
--- a/extensions/usb-camera/GetUSBCamera.h
+++ b/extensions/usb-camera/GetUSBCamera.h
@@ -41,7 +41,7 @@ namespace processors {
class GetUSBCamera : public core::Processor {
public:
- explicit GetUSBCamera(const std::string &name, utils::Identifier uuid =
utils::Identifier())
+ explicit GetUSBCamera(const std::string &name, const utils::Identifier &uuid
= {})
: core::Processor(name, uuid),
logger_(logging::LoggerFactory<GetUSBCamera>::getLogger()) {
png_write_mtx_ = std::make_shared<std::mutex>();
diff --git a/extensions/windows-event-log/ConsumeWindowsEventLog.cpp
b/extensions/windows-event-log/ConsumeWindowsEventLog.cpp
index f262402..9452b6a 100644
--- a/extensions/windows-event-log/ConsumeWindowsEventLog.cpp
+++ b/extensions/windows-event-log/ConsumeWindowsEventLog.cpp
@@ -170,7 +170,7 @@ core::Property ConsumeWindowsEventLog::ProcessOldEvents(
core::Relationship ConsumeWindowsEventLog::Success("success", "Relationship
for successfully consumed events.");
-ConsumeWindowsEventLog::ConsumeWindowsEventLog(const std::string& name,
utils::Identifier uuid)
+ConsumeWindowsEventLog::ConsumeWindowsEventLog(const std::string& name, const
utils::Identifier& uuid)
: core::Processor(name, uuid),
logger_(logging::LoggerFactory<ConsumeWindowsEventLog>::getLogger()) {
char buff[MAX_COMPUTERNAME_LENGTH + 1];
diff --git a/extensions/windows-event-log/ConsumeWindowsEventLog.h
b/extensions/windows-event-log/ConsumeWindowsEventLog.h
index e09833b..f2ce4ff 100644
--- a/extensions/windows-event-log/ConsumeWindowsEventLog.h
+++ b/extensions/windows-event-log/ConsumeWindowsEventLog.h
@@ -58,7 +58,7 @@ public:
/*!
* Create a new processor
*/
- ConsumeWindowsEventLog(const std::string& name, utils::Identifier uuid =
utils::Identifier());
+ ConsumeWindowsEventLog(const std::string& name, const utils::Identifier&
uuid = {});
//! Destructor
virtual ~ConsumeWindowsEventLog();
diff --git a/extensions/windows-event-log/TailEventLog.h
b/extensions/windows-event-log/TailEventLog.h
index 166b6ba..3716258 100644
--- a/extensions/windows-event-log/TailEventLog.h
+++ b/extensions/windows-event-log/TailEventLog.h
@@ -37,7 +37,7 @@ const char log_name[255] = "Application";
class TailEventLog : public core::Processor {
public:
- TailEventLog(std::string name, utils::Identifier uuid = utils::Identifier())
+ TailEventLog(const std::string& name, const utils::Identifier& uuid = {})
: core::Processor(name, uuid),
logger_(logging::LoggerFactory<TailEventLog>::getLogger()),max_events_(1){
}
virtual ~TailEventLog() = default;
diff --git a/libminifi/include/Connection.h b/libminifi/include/Connection.h
index 888fcc0..70f354d 100644
--- a/libminifi/include/Connection.h
+++ b/libminifi/include/Connection.h
@@ -48,21 +48,21 @@ class Connection : public core::Connectable, public
std::enable_shared_from_this
/*
* Create a new processor
*/
- explicit Connection(const std::shared_ptr<core::Repository>
&flow_repository, const std::shared_ptr<core::ContentRepository> &content_repo,
std::string name);
- explicit Connection(const std::shared_ptr<core::Repository>
&flow_repository, const std::shared_ptr<core::ContentRepository> &content_repo,
std::string name, const utils::Identifier& uuid);
- explicit Connection(const std::shared_ptr<core::Repository>
&flow_repository, const std::shared_ptr<core::ContentRepository> &content_repo,
std::string name, const utils::Identifier& uuid,
- const utils::Identifier& srcUUID);
- explicit Connection(const std::shared_ptr<core::Repository>
&flow_repository, const std::shared_ptr<core::ContentRepository> &content_repo,
std::string name, const utils::Identifier& uuid,
- const utils::Identifier& srcUUID, const
utils::Identifier& destUUID);
+ explicit Connection(const std::shared_ptr<core::Repository>
&flow_repository, const std::shared_ptr<core::ContentRepository> &content_repo,
const std::string &name);
+ explicit Connection(const std::shared_ptr<core::Repository>
&flow_repository, const std::shared_ptr<core::ContentRepository> &content_repo,
const std::string &name, const utils::Identifier &uuid);
+ explicit Connection(const std::shared_ptr<core::Repository>
&flow_repository, const std::shared_ptr<core::ContentRepository> &content_repo,
const std::string &name, const utils::Identifier &uuid,
+ const utils::Identifier &srcUUID);
+ explicit Connection(const std::shared_ptr<core::Repository>
&flow_repository, const std::shared_ptr<core::ContentRepository> &content_repo,
const std::string &name, const utils::Identifier &uuid,
+ const utils::Identifier &srcUUID, const
utils::Identifier &destUUID);
// Destructor
virtual ~Connection() = default;
// Set Source Processor UUID
- void setSourceUUID(const utils::Identifier& uuid) {
+ void setSourceUUID(const utils::Identifier &uuid) {
src_uuid_ = uuid;
}
// Set Destination Processor UUID
- void setDestinationUUID(const utils::Identifier& uuid) {
+ void setDestinationUUID(const utils::Identifier &uuid) {
dest_uuid_ = uuid;
}
// Get Source Processor UUID
diff --git a/libminifi/include/FlowFileRecord.h
b/libminifi/include/FlowFileRecord.h
index 445af89..334c37f 100644
--- a/libminifi/include/FlowFileRecord.h
+++ b/libminifi/include/FlowFileRecord.h
@@ -63,15 +63,15 @@ class FlowFileRecord : public core::FlowFile {
//! Serialize and Persistent to the repository
bool Persist(const std::shared_ptr<core::Repository>& flowRepository);
//! DeSerialize
- static std::shared_ptr<FlowFileRecord> DeSerialize(const uint8_t *buffer,
int bufferSize, const std::shared_ptr<core::ContentRepository> &content_repo,
utils::Identifier& container) {
+ static std::shared_ptr<FlowFileRecord> DeSerialize(const uint8_t *buffer,
int bufferSize, const std::shared_ptr<core::ContentRepository> &content_repo,
utils::Identifier &container) {
io::BufferStream inStream{buffer, gsl::narrow<unsigned int>(bufferSize)};
return DeSerialize(inStream, content_repo, container);
}
//! DeSerialize
- static std::shared_ptr<FlowFileRecord> DeSerialize(io::InputStream &stream,
const std::shared_ptr<core::ContentRepository> &content_repo,
utils::Identifier& container);
+ static std::shared_ptr<FlowFileRecord> DeSerialize(io::InputStream &stream,
const std::shared_ptr<core::ContentRepository> &content_repo, utils::Identifier
&container);
//! DeSerialize
static std::shared_ptr<FlowFileRecord> DeSerialize(const std::string& key,
const std::shared_ptr<core::Repository>& flowRepository,
- const std::shared_ptr<core::ContentRepository> &content_repo,
utils::Identifier& container);
+ const std::shared_ptr<core::ContentRepository> &content_repo,
utils::Identifier &container);
std::string getContentFullPath() {
return claim_ ? claim_->getContentFullPath() : "";
diff --git a/libminifi/include/RemoteProcessorGroupPort.h
b/libminifi/include/RemoteProcessorGroupPort.h
index 8598103..be22fd0 100644
--- a/libminifi/include/RemoteProcessorGroupPort.h
+++ b/libminifi/include/RemoteProcessorGroupPort.h
@@ -81,7 +81,7 @@ class RemoteProcessorGroupPort : public core::Processor {
/*!
* Create a new processor
*/
- RemoteProcessorGroupPort(const std::shared_ptr<io::StreamFactory>
&stream_factory, std::string name, std::string url, const
std::shared_ptr<Configure> &configure, utils::Identifier uuid =
utils::Identifier()) // NOLINT
+ RemoteProcessorGroupPort(const std::shared_ptr<io::StreamFactory>
&stream_factory, const std::string &name, std::string url, const
std::shared_ptr<Configure> &configure, const utils::Identifier &uuid = {}) //
NOLINT
: core::Processor(name, uuid),
configure_(configure),
direction_(sitetosite::SEND),
diff --git a/libminifi/include/c2/C2Trigger.h b/libminifi/include/c2/C2Trigger.h
index 1370c58..7635e34 100644
--- a/libminifi/include/c2/C2Trigger.h
+++ b/libminifi/include/c2/C2Trigger.h
@@ -40,7 +40,7 @@ namespace c2 {
*/
class C2Trigger : public core::Connectable{
public:
- C2Trigger(std::string name, utils::Identifier uuid)
+ C2Trigger(const std::string& name, const utils::Identifier& uuid)
: core::Connectable(name, uuid) {
}
virtual ~C2Trigger() = default;
diff --git a/libminifi/include/c2/ControllerSocketProtocol.h
b/libminifi/include/c2/ControllerSocketProtocol.h
index 1636477..23811d6 100644
--- a/libminifi/include/c2/ControllerSocketProtocol.h
+++ b/libminifi/include/c2/ControllerSocketProtocol.h
@@ -40,7 +40,7 @@ namespace c2 {
*/
class ControllerSocketProtocol : public HeartBeatReporter {
public:
- ControllerSocketProtocol(std::string name, utils::Identifier uuid =
utils::Identifier()) // NOLINT
+ ControllerSocketProtocol(const std::string& name, const utils::Identifier&
uuid = {}) // NOLINT
: HeartBeatReporter(name, uuid),
logger_(logging::LoggerFactory<ControllerSocketProtocol>::getLogger())
{
}
diff --git a/libminifi/include/c2/HeartBeatReporter.h
b/libminifi/include/c2/HeartBeatReporter.h
index 82d5f2a..073a6e9 100644
--- a/libminifi/include/c2/HeartBeatReporter.h
+++ b/libminifi/include/c2/HeartBeatReporter.h
@@ -38,7 +38,7 @@ namespace c2 {
*/
class HeartBeatReporter : public core::Connectable {
public:
- HeartBeatReporter(std::string name, utils::Identifier & uuid)
+ HeartBeatReporter(const std::string& name, const utils::Identifier& uuid)
: core::Connectable(name, uuid),
controller_(nullptr),
update_sink_(nullptr),
diff --git a/libminifi/include/c2/triggers/FileUpdateTrigger.h
b/libminifi/include/c2/triggers/FileUpdateTrigger.h
index 5edb371..7bd8635 100644
--- a/libminifi/include/c2/triggers/FileUpdateTrigger.h
+++ b/libminifi/include/c2/triggers/FileUpdateTrigger.h
@@ -41,7 +41,7 @@ namespace c2 {
*/
class FileUpdateTrigger : public C2Trigger {
public:
- FileUpdateTrigger(std::string name, utils::Identifier uuid =
utils::Identifier()) // NOLINT
+ FileUpdateTrigger(const std::string& name, const utils::Identifier& uuid =
{}) // NOLINT
: C2Trigger(name, uuid),
last_update_(0),
update_(false),
diff --git a/libminifi/include/controllers/LinuxPowerManagementService.h
b/libminifi/include/controllers/LinuxPowerManagementService.h
index 533bfc3..f3213d3 100644
--- a/libminifi/include/controllers/LinuxPowerManagementService.h
+++ b/libminifi/include/controllers/LinuxPowerManagementService.h
@@ -42,7 +42,7 @@ namespace controllers {
*/
class LinuxPowerManagerService : public ThreadManagementService {
public:
- explicit LinuxPowerManagerService(const std::string &name, utils::Identifier
uuid = utils::Identifier())
+ explicit LinuxPowerManagerService(const std::string &name, const
utils::Identifier &uuid = {})
: ThreadManagementService(name, uuid),
enabled_(false),
battery_level_(0),
diff --git a/libminifi/include/controllers/SSLContextService.h
b/libminifi/include/controllers/SSLContextService.h
index 9bdde82..8afbf0d 100644
--- a/libminifi/include/controllers/SSLContextService.h
+++ b/libminifi/include/controllers/SSLContextService.h
@@ -81,7 +81,7 @@ class SSLContext {
*/
class SSLContextService : public core::controller::ControllerService {
public:
- explicit SSLContextService(const std::string &name, const utils::Identifier&
uuid = {})
+ explicit SSLContextService(const std::string &name, const utils::Identifier
&uuid = {})
: ControllerService(name, uuid),
initialized_(false),
valid_(false),
diff --git a/libminifi/include/controllers/ThreadManagementService.h
b/libminifi/include/controllers/ThreadManagementService.h
index f4380d4..904e56c 100644
--- a/libminifi/include/controllers/ThreadManagementService.h
+++ b/libminifi/include/controllers/ThreadManagementService.h
@@ -39,7 +39,7 @@ namespace controllers {
*/
class ThreadManagementService : public core::controller::ControllerService {
public:
- explicit ThreadManagementService(const std::string &name, const
utils::Identifier& uuid = {})
+ explicit ThreadManagementService(const std::string &name, const
utils::Identifier &uuid = {})
: ControllerService(name, uuid),
logger_(logging::LoggerFactory<ThreadManagementService>::getLogger()) {
}
diff --git a/libminifi/include/controllers/UpdatePolicyControllerService.h
b/libminifi/include/controllers/UpdatePolicyControllerService.h
index 27bce1a..9dbf224 100644
--- a/libminifi/include/controllers/UpdatePolicyControllerService.h
+++ b/libminifi/include/controllers/UpdatePolicyControllerService.h
@@ -41,7 +41,7 @@ namespace controllers {
*/
class UpdatePolicyControllerService : public
core::controller::ControllerService, public
std::enable_shared_from_this<UpdatePolicyControllerService> {
public:
- explicit UpdatePolicyControllerService(const std::string &name, const
utils::Identifier& uuid = {})
+ explicit UpdatePolicyControllerService(const std::string &name, const
utils::Identifier &uuid = {})
: ControllerService(name, uuid),
persist_updates_(false),
policy_(new state::UpdatePolicy(false)),
diff --git
a/libminifi/include/controllers/keyvalue/AbstractAutoPersistingKeyValueStoreService.h
b/libminifi/include/controllers/keyvalue/AbstractAutoPersistingKeyValueStoreService.h
index 9f3d0e4..e347a70 100644
---
a/libminifi/include/controllers/keyvalue/AbstractAutoPersistingKeyValueStoreService.h
+++
b/libminifi/include/controllers/keyvalue/AbstractAutoPersistingKeyValueStoreService.h
@@ -39,7 +39,7 @@ namespace controllers {
class AbstractAutoPersistingKeyValueStoreService : virtual public
PersistableKeyValueStoreService {
public:
- explicit AbstractAutoPersistingKeyValueStoreService(const std::string& name,
utils::Identifier uuid = utils::Identifier());
+ explicit AbstractAutoPersistingKeyValueStoreService(const std::string& name,
const utils::Identifier& uuid = {});
~AbstractAutoPersistingKeyValueStoreService() override;
diff --git
a/libminifi/include/controllers/keyvalue/PersistableKeyValueStoreService.h
b/libminifi/include/controllers/keyvalue/PersistableKeyValueStoreService.h
index 77f3b4a..d65856f 100644
--- a/libminifi/include/controllers/keyvalue/PersistableKeyValueStoreService.h
+++ b/libminifi/include/controllers/keyvalue/PersistableKeyValueStoreService.h
@@ -34,7 +34,7 @@ namespace controllers {
class PersistableKeyValueStoreService : public KeyValueStoreService, public
AbstractCoreComponentStateManagerProvider {
public:
- explicit PersistableKeyValueStoreService(const std::string& name,
utils::Identifier uuid = utils::Identifier());
+ explicit PersistableKeyValueStoreService(const std::string& name, const
utils::Identifier& uuid = {});
~PersistableKeyValueStoreService() override;
diff --git a/libminifi/include/core/ClassLoader.h
b/libminifi/include/core/ClassLoader.h
index c061558..99d2061 100644
--- a/libminifi/include/core/ClassLoader.h
+++ b/libminifi/include/core/ClassLoader.h
@@ -181,7 +181,7 @@ class DefautObjectFactory : public ObjectFactory {
/**
* Create a shared pointer to a new processor.
*/
- virtual std::shared_ptr<CoreComponent> create(const std::string &name, const
utils::Identifier & uuid) {
+ virtual std::shared_ptr<CoreComponent> create(const std::string &name, const
utils::Identifier &uuid) {
std::shared_ptr<T> ptr = std::make_shared<T>(name, uuid);
return std::static_pointer_cast<CoreComponent>(ptr);
}
diff --git a/libminifi/include/core/Core.h b/libminifi/include/core/Core.h
index f056faf..11635f3 100644
--- a/libminifi/include/core/Core.h
+++ b/libminifi/include/core/Core.h
@@ -148,7 +148,7 @@ class CoreComponent {
* Constructor that sets the name and uuid.
*/
- explicit CoreComponent(const std::string &name, const utils::Identifier&
uuid = {}, const std::shared_ptr<utils::IdGenerator>& idGenerator =
utils::IdGenerator::getIdGenerator())
+ explicit CoreComponent(const std::string &name, const utils::Identifier
&uuid = {}, const std::shared_ptr<utils::IdGenerator> &idGenerator =
utils::IdGenerator::getIdGenerator())
: name_(name) {
if (uuid.isNil()) {
// Generate the global UUID for the flow record
diff --git a/libminifi/include/core/FlowConfiguration.h
b/libminifi/include/core/FlowConfiguration.h
index 9d96b56..13d366d 100644
--- a/libminifi/include/core/FlowConfiguration.h
+++ b/libminifi/include/core/FlowConfiguration.h
@@ -101,8 +101,8 @@ class FlowConfiguration : public CoreComponent {
~FlowConfiguration() override;
// Create Processor (Node/Input/Output Port) based on the name
- std::shared_ptr<core::Processor> createProcessor(std::string name,
utils::Identifier &uuid);
- std::shared_ptr<core::Processor> createProcessor(const std::string &name,
const std::string &fullname, utils::Identifier &uuid);
+ std::shared_ptr<core::Processor> createProcessor(const std::string &name,
const utils::Identifier &uuid);
+ std::shared_ptr<core::Processor> createProcessor(const std::string &name,
const std::string &fullname, const utils::Identifier &uuid);
// Create Root Processor Group
std::unique_ptr<core::ProcessGroup> createRootProcessGroup(const std::string
&name, const utils::Identifier &uuid, int version);
@@ -110,10 +110,10 @@ class FlowConfiguration : public CoreComponent {
std::unique_ptr<core::ProcessGroup> createRemoteProcessGroup(const
std::string &name, const utils::Identifier &uuid);
std::shared_ptr<core::controller::ControllerServiceNode>
createControllerService(const std::string &class_name, const std::string
&full_class_name, const std::string &name,
- const utils::Identifier& uuid);
+ const utils::Identifier &uuid);
// Create Connection
- std::shared_ptr<minifi::Connection> createConnection(std::string name, const
utils::Identifier& uuid) const;
+ std::shared_ptr<minifi::Connection> createConnection(const std::string
&name, const utils::Identifier &uuid) const;
// Create Provenance Report Task
std::shared_ptr<core::Processor> createProvenanceReportTask(void);
diff --git a/libminifi/include/core/Processor.h
b/libminifi/include/core/Processor.h
index 51851a5..17bb955 100644
--- a/libminifi/include/core/Processor.h
+++ b/libminifi/include/core/Processor.h
@@ -64,7 +64,7 @@ namespace core {
// Processor Class
class Processor : public Connectable, public ConfigurableComponent, public
std::enable_shared_from_this<Processor> {
public:
- Processor(const std::string& name, const utils::Identifier &uuid);
+ Processor(const std::string& name, const utils::Identifier& uuid);
explicit Processor(const std::string& name);
virtual ~Processor() {
notifyStop();
diff --git a/libminifi/include/core/SerializableComponent.h
b/libminifi/include/core/SerializableComponent.h
index b93e455..94d69eb 100644
--- a/libminifi/include/core/SerializableComponent.h
+++ b/libminifi/include/core/SerializableComponent.h
@@ -35,11 +35,11 @@ namespace core {
*/
class SerializableComponent : public core::Connectable {
public:
- SerializableComponent(const std::string name) // NOLINT
+ SerializableComponent(const std::string& name) // NOLINT
: core::Connectable(name) {
}
- SerializableComponent(const std::string name, utils::Identifier &uuid )
+ SerializableComponent(const std::string& name, const utils::Identifier& uuid)
: core::Connectable(name, uuid) {
}
diff --git a/libminifi/include/core/controller/ControllerService.h
b/libminifi/include/core/controller/ControllerService.h
index 6baa9fd..7e0492f 100644
--- a/libminifi/include/core/controller/ControllerService.h
+++ b/libminifi/include/core/controller/ControllerService.h
@@ -73,7 +73,7 @@ class ControllerService : public ConfigurableComponent,
public Connectable {
/**
* Controller Service constructor.
*/
- explicit ControllerService(const std::string &name, const utils::Identifier&
uuid)
+ explicit ControllerService(const std::string &name, const utils::Identifier
&uuid)
: Connectable(name, uuid),
configuration_(std::make_shared<Configure>()) {
current_state_ = DISABLED;
diff --git a/libminifi/include/core/controller/ControllerServiceProvider.h
b/libminifi/include/core/controller/ControllerServiceProvider.h
index 0009ffd..894021d 100644
--- a/libminifi/include/core/controller/ControllerServiceProvider.h
+++ b/libminifi/include/core/controller/ControllerServiceProvider.h
@@ -175,7 +175,7 @@ class ControllerServiceProvider : public CoreComponent,
public ConfigurableCompo
* Returns a controller service for the service identifier and componentID
* @param service Identifier service identifier.
*/
- virtual std::shared_ptr<ControllerService>
getControllerServiceForComponent(const std::string &serviceIdentifier, const
utils::Identifier& /*componentId*/) {
+ virtual std::shared_ptr<ControllerService>
getControllerServiceForComponent(const std::string& serviceIdentifier, const
utils::Identifier& /*componentId*/) {
std::shared_ptr<ControllerService> node =
getControllerService(serviceIdentifier);
return node;
}
diff --git a/libminifi/include/core/state/nodes/AgentInformation.h
b/libminifi/include/core/state/nodes/AgentInformation.h
index d686fce..dbef652 100644
--- a/libminifi/include/core/state/nodes/AgentInformation.h
+++ b/libminifi/include/core/state/nodes/AgentInformation.h
@@ -76,7 +76,7 @@ namespace response {
class ComponentManifest : public DeviceInformation {
public:
- ComponentManifest(const std::string& name, utils::Identifier & uuid)
+ ComponentManifest(const std::string& name, const utils::Identifier& uuid)
: DeviceInformation(name, uuid) {
}
@@ -309,7 +309,7 @@ class ComponentManifest : public DeviceInformation {
class ExternalManifest : public ComponentManifest {
public:
- ExternalManifest(const std::string& name, utils::Identifier & uuid)
+ ExternalManifest(const std::string& name, const utils::Identifier& uuid)
: ComponentManifest(name, uuid) {
}
@@ -331,7 +331,7 @@ class ExternalManifest : public ComponentManifest {
class Bundles : public DeviceInformation {
public:
- Bundles(const std::string& name, utils::Identifier & uuid)
+ Bundles(const std::string& name, const utils::Identifier& uuid)
: DeviceInformation(name, uuid) {
setArray(true);
}
@@ -409,7 +409,7 @@ class Bundles : public DeviceInformation {
*/
class AgentStatus : public StateMonitorNode {
public:
- AgentStatus(std::string name, utils::Identifier & uuid)
+ AgentStatus(const std::string& name, const utils::Identifier& uuid)
: StateMonitorNode(name, uuid) {
}
@@ -590,7 +590,7 @@ class AgentMonitor {
*/
class AgentManifest : public DeviceInformation {
public:
- AgentManifest(const std::string& name, utils::Identifier & uuid)
+ AgentManifest(const std::string& name, const utils::Identifier& uuid)
: DeviceInformation(name, uuid) {
}
@@ -672,7 +672,7 @@ class AgentManifest : public DeviceInformation {
class AgentNode : public DeviceInformation, public AgentMonitor, public
AgentIdentifier {
public:
- AgentNode(const std::string& name, const utils::Identifier & uuid)
+ AgentNode(const std::string& name, const utils::Identifier& uuid)
: DeviceInformation(name, uuid) {
setArray(false);
}
@@ -735,7 +735,7 @@ class AgentNode : public DeviceInformation, public
AgentMonitor, public AgentIde
*/
class AgentInformation : public AgentNode {
public:
- AgentInformation(const std::string& name, const utils::Identifier & uuid)
+ AgentInformation(const std::string& name, const utils::Identifier& uuid)
: AgentNode(name, uuid),
include_agent_status_(true) {
setArray(false);
diff --git a/libminifi/include/core/state/nodes/BuildInformation.h
b/libminifi/include/core/state/nodes/BuildInformation.h
index 2e11965..ff9b520 100644
--- a/libminifi/include/core/state/nodes/BuildInformation.h
+++ b/libminifi/include/core/state/nodes/BuildInformation.h
@@ -68,7 +68,7 @@ namespace response {
*/
class BuildInformation : public DeviceInformation {
public:
- BuildInformation(std::string name, const utils::Identifier &uuid)
+ BuildInformation(const std::string &name, const utils::Identifier &uuid)
: DeviceInformation(name, uuid) {
}
diff --git a/libminifi/include/core/state/nodes/MetricsBase.h
b/libminifi/include/core/state/nodes/MetricsBase.h
index e0763a4..e0af104 100644
--- a/libminifi/include/core/state/nodes/MetricsBase.h
+++ b/libminifi/include/core/state/nodes/MetricsBase.h
@@ -49,7 +49,7 @@ class ResponseNode : public core::Connectable {
is_array_(false) {
}
- ResponseNode(const std::string& name, const utils::Identifier &uuid)
+ ResponseNode(const std::string& name, const utils::Identifier& uuid)
: core::Connectable(name, uuid),
is_array_(false) {
}
@@ -87,7 +87,7 @@ class ResponseNode : public core::Connectable {
*/
class DeviceInformation : public ResponseNode {
public:
- DeviceInformation(const std::string& name, const utils::Identifier & uuid)
+ DeviceInformation(const std::string& name, const utils::Identifier& uuid)
: ResponseNode(name, uuid) {
}
DeviceInformation(const std::string& name) // NOLINT
@@ -100,7 +100,7 @@ class DeviceInformation : public ResponseNode {
*/
class ObjectNode : public ResponseNode {
public:
- ObjectNode(std::string name, utils::Identifier uuid = utils::Identifier())
// NOLINT
+ ObjectNode(const std::string& name, const utils::Identifier& uuid = {}) //
NOLINT
: ResponseNode(name, uuid) {
}
diff --git a/libminifi/include/core/state/nodes/QueueMetrics.h
b/libminifi/include/core/state/nodes/QueueMetrics.h
index 90f0c43..cd0efd3 100644
--- a/libminifi/include/core/state/nodes/QueueMetrics.h
+++ b/libminifi/include/core/state/nodes/QueueMetrics.h
@@ -41,7 +41,7 @@ namespace response {
*/
class QueueMetrics : public ResponseNode {
public:
- QueueMetrics(const std::string &name, utils::Identifier & uuid)
+ QueueMetrics(const std::string &name, const utils::Identifier &uuid)
: ResponseNode(name, uuid) {
}
diff --git a/libminifi/include/core/state/nodes/RepositoryMetrics.h
b/libminifi/include/core/state/nodes/RepositoryMetrics.h
index 8ba79f9..2c96cb1 100644
--- a/libminifi/include/core/state/nodes/RepositoryMetrics.h
+++ b/libminifi/include/core/state/nodes/RepositoryMetrics.h
@@ -41,7 +41,7 @@ namespace response {
*/
class RepositoryMetrics : public ResponseNode {
public:
- RepositoryMetrics(const std::string &name, utils::Identifier &uuid)
+ RepositoryMetrics(const std::string &name, const utils::Identifier &uuid)
: ResponseNode(name, uuid) {
}
diff --git a/libminifi/include/core/state/nodes/SchedulingNodes.h
b/libminifi/include/core/state/nodes/SchedulingNodes.h
index 3ba4ab9..cdf3d11 100644
--- a/libminifi/include/core/state/nodes/SchedulingNodes.h
+++ b/libminifi/include/core/state/nodes/SchedulingNodes.h
@@ -35,7 +35,7 @@ namespace response {
class SchedulingDefaults : public DeviceInformation {
public:
- SchedulingDefaults(std::string name, utils::Identifier &uuid)
+ SchedulingDefaults(const std::string &name, const utils::Identifier &uuid)
: DeviceInformation(name, uuid) {
}
diff --git a/libminifi/include/core/state/nodes/StateMonitor.h
b/libminifi/include/core/state/nodes/StateMonitor.h
index e1caf30..e64f86a 100644
--- a/libminifi/include/core/state/nodes/StateMonitor.h
+++ b/libminifi/include/core/state/nodes/StateMonitor.h
@@ -44,7 +44,7 @@ namespace response {
class StateMonitorNode : public DeviceInformation {
public:
- StateMonitorNode(std::string name, const utils::Identifier &uuid)
+ StateMonitorNode(const std::string& name, const utils::Identifier& uuid)
: DeviceInformation(name, uuid),
monitor_(nullptr) {
}
diff --git a/libminifi/include/processors/ProcessorUtils.h
b/libminifi/include/processors/ProcessorUtils.h
index 4e6c2cc..fe9ebc6 100644
--- a/libminifi/include/processors/ProcessorUtils.h
+++ b/libminifi/include/processors/ProcessorUtils.h
@@ -38,7 +38,7 @@ class ProcessorUtils {
* @param uuid uuid object for the processor
* @param stream_factory stream factory to be set onto the processor
*/
- static inline std::shared_ptr<core::Processor> createProcessor(const
std::string &class_short_name, const std::string &canonicalName,
utils::Identifier &uuid,
+ static inline std::shared_ptr<core::Processor> createProcessor(const
std::string &class_short_name, const std::string &canonicalName, const
utils::Identifier &uuid,
const
std::shared_ptr<minifi::io::StreamFactory> &stream_factory) {
auto ptr =
core::ClassLoader::getDefaultClassLoader().instantiate(class_short_name, uuid);
// fallback to the canonical name if the short name does not work, then
attempt JNI bindings if they exist
diff --git a/libminifi/include/sitetosite/Peer.h
b/libminifi/include/sitetosite/Peer.h
index 19d0a03..a82e3b4 100644
--- a/libminifi/include/sitetosite/Peer.h
+++ b/libminifi/include/sitetosite/Peer.h
@@ -46,7 +46,7 @@ namespace sitetosite {
class Peer {
public:
- explicit Peer(utils::Identifier &port_id, const std::string &host, uint16_t
port, bool secure = false)
+ explicit Peer(const utils::Identifier &port_id, const std::string &host,
uint16_t port, bool secure = false)
: host_(host),
port_(port),
secure_(secure) {
diff --git a/libminifi/include/sitetosite/SiteToSiteClient.h
b/libminifi/include/sitetosite/SiteToSiteClient.h
index 4280b2f..fc1dc91 100644
--- a/libminifi/include/sitetosite/SiteToSiteClient.h
+++ b/libminifi/include/sitetosite/SiteToSiteClient.h
@@ -134,7 +134,7 @@ class SiteToSiteClient : public core::Connectable {
// Receive the data packet from the transaction
// Return false when any error occurs
- bool receive(const utils::Identifier& transactionID, DataPacket *packet,
bool &eof);
+ bool receive(const utils::Identifier &transactionID, DataPacket *packet,
bool &eof);
/**
* Transfers raw data and attributes to server
* @param context process context
@@ -212,19 +212,19 @@ class SiteToSiteClient : public core::Connectable {
}
// Return -1 when any error occurs
- virtual int16_t send(const utils::Identifier& transactionID, DataPacket
*packet, const std::shared_ptr<core::FlowFile> &flowFile, const
std::shared_ptr<core::ProcessSession> &session);
+ virtual int16_t send(const utils::Identifier &transactionID, DataPacket
*packet, const std::shared_ptr<core::FlowFile> &flowFile, const
std::shared_ptr<core::ProcessSession> &session);
protected:
// Cancel the transaction
- virtual void cancel(const utils::Identifier& transactionID);
+ virtual void cancel(const utils::Identifier &transactionID);
// Complete the transaction
- virtual bool complete(const utils::Identifier& transactionID);
+ virtual bool complete(const utils::Identifier &transactionID);
// Error the transaction
- virtual void error(const utils::Identifier& transactionID);
+ virtual void error(const utils::Identifier &transactionID);
- virtual bool confirm(const utils::Identifier& transactionID);
+ virtual bool confirm(const utils::Identifier &transactionID);
// deleteTransaction
- virtual void deleteTransaction(const utils::Identifier& transactionID);
+ virtual void deleteTransaction(const utils::Identifier &transactionID);
virtual void tearDown() = 0;
diff --git a/libminifi/src/Connection.cpp b/libminifi/src/Connection.cpp
index af119fb..5b298ae 100644
--- a/libminifi/src/Connection.cpp
+++ b/libminifi/src/Connection.cpp
@@ -38,7 +38,7 @@ namespace apache {
namespace nifi {
namespace minifi {
-Connection::Connection(const std::shared_ptr<core::Repository>
&flow_repository, const std::shared_ptr<core::ContentRepository> &content_repo,
std::string name)
+Connection::Connection(const std::shared_ptr<core::Repository>
&flow_repository, const std::shared_ptr<core::ContentRepository> &content_repo,
const std::string &name)
: core::Connectable(name),
flow_repository_(flow_repository),
content_repo_(content_repo),
@@ -54,7 +54,7 @@ Connection::Connection(const
std::shared_ptr<core::Repository> &flow_repository,
logger_->log_debug("Connection %s created", name_);
}
-Connection::Connection(const std::shared_ptr<core::Repository>
&flow_repository, const std::shared_ptr<core::ContentRepository> &content_repo,
std::string name, const utils::Identifier& uuid)
+Connection::Connection(const std::shared_ptr<core::Repository>
&flow_repository, const std::shared_ptr<core::ContentRepository> &content_repo,
const std::string &name, const utils::Identifier &uuid)
: core::Connectable(name, uuid),
flow_repository_(flow_repository),
content_repo_(content_repo),
@@ -70,7 +70,7 @@ Connection::Connection(const
std::shared_ptr<core::Repository> &flow_repository,
logger_->log_debug("Connection %s created", name_);
}
-Connection::Connection(const std::shared_ptr<core::Repository>
&flow_repository, const std::shared_ptr<core::ContentRepository> &content_repo,
std::string name, const utils::Identifier& uuid,
+Connection::Connection(const std::shared_ptr<core::Repository>
&flow_repository, const std::shared_ptr<core::ContentRepository> &content_repo,
const std::string &name, const utils::Identifier &uuid,
const utils::Identifier& srcUUID)
: core::Connectable(name, uuid),
flow_repository_(flow_repository),
@@ -90,7 +90,7 @@ Connection::Connection(const
std::shared_ptr<core::Repository> &flow_repository,
logger_->log_debug("Connection %s created", name_);
}
-Connection::Connection(const std::shared_ptr<core::Repository>
&flow_repository, const std::shared_ptr<core::ContentRepository> &content_repo,
std::string name, const utils::Identifier& uuid,
+Connection::Connection(const std::shared_ptr<core::Repository>
&flow_repository, const std::shared_ptr<core::ContentRepository> &content_repo,
const std::string &name, const utils::Identifier &uuid,
const utils::Identifier& srcUUID, const
utils::Identifier& destUUID)
: core::Connectable(name, uuid),
flow_repository_(flow_repository),
diff --git
a/libminifi/src/controllers/keyvalue/AbstractAutoPersistingKeyValueStoreService.cpp
b/libminifi/src/controllers/keyvalue/AbstractAutoPersistingKeyValueStoreService.cpp
index 92a530a..8b907dc 100644
---
a/libminifi/src/controllers/keyvalue/AbstractAutoPersistingKeyValueStoreService.cpp
+++
b/libminifi/src/controllers/keyvalue/AbstractAutoPersistingKeyValueStoreService.cpp
@@ -32,7 +32,7 @@ core::Property
AbstractAutoPersistingKeyValueStoreService::AutoPersistenceInterv
"If set to 0 seconds, auto persistence will be disabled.")
->isRequired(false)->withDefaultValue<core::TimePeriodValue>("1
min")->build());
-AbstractAutoPersistingKeyValueStoreService::AbstractAutoPersistingKeyValueStoreService(const
std::string& name, utils::Identifier uuid /*= utils::Identifier()*/)
+AbstractAutoPersistingKeyValueStoreService::AbstractAutoPersistingKeyValueStoreService(const
std::string& name, const utils::Identifier& uuid /*= utils::Identifier()*/)
: PersistableKeyValueStoreService(name, uuid)
, always_persist_(false)
, auto_persistence_interval_(0U)
diff --git
a/libminifi/src/controllers/keyvalue/PersistableKeyValueStoreService.cpp
b/libminifi/src/controllers/keyvalue/PersistableKeyValueStoreService.cpp
index 6eb3745..a194f0e 100644
--- a/libminifi/src/controllers/keyvalue/PersistableKeyValueStoreService.cpp
+++ b/libminifi/src/controllers/keyvalue/PersistableKeyValueStoreService.cpp
@@ -24,7 +24,7 @@ namespace nifi {
namespace minifi {
namespace controllers {
-PersistableKeyValueStoreService::PersistableKeyValueStoreService(const
std::string& name, utils::Identifier uuid /*= utils::Identifier()*/)
+PersistableKeyValueStoreService::PersistableKeyValueStoreService(const
std::string& name, const utils::Identifier& uuid /*= utils::Identifier()*/)
: KeyValueStoreService(name, uuid) {
}
diff --git a/libminifi/src/core/FlowConfiguration.cpp
b/libminifi/src/core/FlowConfiguration.cpp
index 1374205..53104c9 100644
--- a/libminifi/src/core/FlowConfiguration.cpp
+++ b/libminifi/src/core/FlowConfiguration.cpp
@@ -42,7 +42,7 @@ FlowConfiguration::~FlowConfiguration() {
}
}
-std::shared_ptr<core::Processor>
FlowConfiguration::createProcessor(std::string name, utils::Identifier &uuid) {
+std::shared_ptr<core::Processor> FlowConfiguration::createProcessor(const
std::string &name, const utils::Identifier &uuid) {
auto processor = minifi::processors::ProcessorUtils::createProcessor(name,
name, uuid, stream_factory_);
if (nullptr == processor) {
logger_->log_error("No Processor defined for %s", name);
@@ -51,7 +51,7 @@ std::shared_ptr<core::Processor>
FlowConfiguration::createProcessor(std::string
return processor;
}
-std::shared_ptr<core::Processor> FlowConfiguration::createProcessor(const
std::string &name, const std::string &fullname, utils::Identifier &uuid) {
+std::shared_ptr<core::Processor> FlowConfiguration::createProcessor(const
std::string &name, const std::string &fullname, const utils::Identifier &uuid) {
auto processor = minifi::processors::ProcessorUtils::createProcessor(name,
fullname, uuid, stream_factory_);
if (nullptr == processor) {
logger_->log_error("No Processor defined for %s", fullname);
@@ -124,7 +124,7 @@ std::unique_ptr<core::ProcessGroup>
FlowConfiguration::createRemoteProcessGroup(
return utils::make_unique<core::ProcessGroup>(core::REMOTE_PROCESS_GROUP,
name, uuid);
}
-std::shared_ptr<minifi::Connection>
FlowConfiguration::createConnection(std::string name, const utils::Identifier&
uuid) const {
+std::shared_ptr<minifi::Connection> FlowConfiguration::createConnection(const
std::string& name, const utils::Identifier& uuid) const {
return std::make_shared<minifi::Connection>(flow_file_repo_, content_repo_,
name, uuid);
}
diff --git a/libminifi/src/core/ProcessGroup.cpp
b/libminifi/src/core/ProcessGroup.cpp
index 8183d0b..5f4c9ab 100644
--- a/libminifi/src/core/ProcessGroup.cpp
+++ b/libminifi/src/core/ProcessGroup.cpp
@@ -46,7 +46,7 @@ ProcessGroup::ProcessGroup(ProcessGroupType type, const
std::string& name, const
: ProcessGroup(type, name, uuid, version, 0) {
}
-ProcessGroup::ProcessGroup(ProcessGroupType type, const std::string& name,
const utils::Identifier& uuid, int version, ProcessGroup *parent)
+ProcessGroup::ProcessGroup(ProcessGroupType type, const std::string& name,
const utils::Identifier& uuid, int version, ProcessGroup* parent)
: CoreComponent(name, uuid, id_generator_),
config_version_(version),
type_(type),
diff --git a/libminifi/src/core/Processor.cpp b/libminifi/src/core/Processor.cpp
index dd3b715..6d11b74 100644
--- a/libminifi/src/core/Processor.cpp
+++ b/libminifi/src/core/Processor.cpp
@@ -69,7 +69,7 @@ Processor::Processor(const std::string& name)
logger_->log_debug("Processor %s created UUID %s", name_, getUUIDStr());
}
-Processor::Processor(const std::string& name, const utils::Identifier &uuid)
+Processor::Processor(const std::string& name, const utils::Identifier& uuid)
: Connectable(name, uuid),
ConfigurableComponent(),
logger_(logging::LoggerFactory<Processor>::getLogger()) {
diff --git a/libminifi/src/sitetosite/SiteToSiteClient.cpp
b/libminifi/src/sitetosite/SiteToSiteClient.cpp
index 2eabfa1..1833144 100644
--- a/libminifi/src/sitetosite/SiteToSiteClient.cpp
+++ b/libminifi/src/sitetosite/SiteToSiteClient.cpp
@@ -410,7 +410,7 @@ bool SiteToSiteClient::complete(const utils::Identifier&
transactionID) {
}
}
-int16_t SiteToSiteClient::send(const utils::Identifier& transactionID,
DataPacket *packet, const std::shared_ptr<core::FlowFile> &flowFile, const
std::shared_ptr<core::ProcessSession> &session) {
+int16_t SiteToSiteClient::send(const utils::Identifier &transactionID,
DataPacket *packet, const std::shared_ptr<core::FlowFile> &flowFile, const
std::shared_ptr<core::ProcessSession> &session) {
int ret;
if (peer_state_ != READY) {
diff --git a/libminifi/test/KamikazeProcessor.h
b/libminifi/test/KamikazeProcessor.h
index 0c5b752..60a3683 100644
--- a/libminifi/test/KamikazeProcessor.h
+++ b/libminifi/test/KamikazeProcessor.h
@@ -40,7 +40,7 @@ public:
static const std::string OnTriggerLogStr;
static const std::string OnUnScheduleLogStr;
- KamikazeProcessor(std::string name, utils::Identifier uuid =
utils::Identifier())
+ KamikazeProcessor(const std::string& name, const utils::Identifier& uuid =
{})
: Processor(name, uuid),
logger_(logging::LoggerFactory<KamikazeProcessor>::getLogger()) {
_throwInOnTrigger = false;
}
diff --git a/libminifi/test/TestBase.cpp b/libminifi/test/TestBase.cpp
index 94b7633..c953c8a 100644
--- a/libminifi/test/TestBase.cpp
+++ b/libminifi/test/TestBase.cpp
@@ -120,8 +120,8 @@ std::shared_ptr<core::Processor>
TestPlan::addProcessor(const std::shared_ptr<co
return processor;
}
-std::shared_ptr<core::Processor> TestPlan::addProcessor(const std::string
&processor_name, const utils::Identifier& uuid, const std::string &name,
- const std::initializer_list<core::Relationship>& relationships, bool
linkToPrevious) {
+std::shared_ptr<core::Processor> TestPlan::addProcessor(const std::string
&processor_name, const utils::Identifier &uuid, const std::string &name,
+ const std::initializer_list<core::Relationship> &relationships, bool
linkToPrevious) {
if (finalized) {
return nullptr;
}
diff --git a/libminifi/test/flow-tests/CustomProcessors.h
b/libminifi/test/flow-tests/CustomProcessors.h
index 2408677..fe4bd0f 100644
--- a/libminifi/test/flow-tests/CustomProcessors.h
+++ b/libminifi/test/flow-tests/CustomProcessors.h
@@ -48,7 +48,7 @@ class ProcessorWithStatistics {
class TestProcessor : public core::Processor, public ProcessorWithStatistics {
public:
- TestProcessor(const std::string& name, const utils::Identifier &uuid) :
Processor(name, uuid) {}
+ TestProcessor(const std::string& name, const utils::Identifier& uuid) :
Processor(name, uuid) {}
TestProcessor(const std::string& name) : Processor(name) {}
void initialize() override {
setSupportedProperties({AppleProbability, BananaProbability});
@@ -91,7 +91,7 @@ class TestProcessor : public core::Processor, public
ProcessorWithStatistics {
class TestFlowFileGenerator : public processors::GenerateFlowFile, public
ProcessorWithStatistics {
public:
- TestFlowFileGenerator(const std::string& name, const utils::Identifier
&uuid) : GenerateFlowFile(name, uuid) {}
+ TestFlowFileGenerator(const std::string& name, const utils::Identifier&
uuid) : GenerateFlowFile(name, uuid) {}
TestFlowFileGenerator(const std::string& name) : GenerateFlowFile(name) {}
using processors::GenerateFlowFile::onTrigger;
diff --git a/libminifi/test/persistence-tests/PersistenceTests.cpp
b/libminifi/test/persistence-tests/PersistenceTests.cpp
index 7919426..1bf7b0c 100644
--- a/libminifi/test/persistence-tests/PersistenceTests.cpp
+++ b/libminifi/test/persistence-tests/PersistenceTests.cpp
@@ -243,7 +243,7 @@ TEST_CASE("Processors Can Store FlowFiles", "[TestP1]") {
class ContentUpdaterProcessor : public core::Processor{
public:
- ContentUpdaterProcessor(const std::string& name, utils::Identifier& id) :
Processor(name, id) {}
+ ContentUpdaterProcessor(const std::string& name, const utils::Identifier&
id) : Processor(name, id) {}
void onTrigger(core::ProcessContext* /*context*/, core::ProcessSession
*session) override {
auto ff = session->get();
std::string data = "<override>";
@@ -253,7 +253,7 @@ class ContentUpdaterProcessor : public core::Processor{
}
};
-std::shared_ptr<core::Processor>
setupContentUpdaterProcessor(utils::Identifier& id) {
+std::shared_ptr<core::Processor> setupContentUpdaterProcessor(const
utils::Identifier& id) {
return std::make_shared<ContentUpdaterProcessor>("Updater", id);
}
diff --git a/libminifi/test/unit/MockClasses.h
b/libminifi/test/unit/MockClasses.h
index 2d07538..e08bcd6 100644
--- a/libminifi/test/unit/MockClasses.h
+++ b/libminifi/test/unit/MockClasses.h
@@ -28,7 +28,7 @@ std::mutex control_mutex;
class MockControllerService : public core::controller::ControllerService {
public:
- explicit MockControllerService(const std::string &name, const
utils::Identifier & uuid)
+ explicit MockControllerService(const std::string &name, const
utils::Identifier &uuid)
: ControllerService(name, uuid) {
}
@@ -72,7 +72,7 @@ class MockControllerService : public
core::controller::ControllerService {
class MockProcessor : public core::Processor {
public:
- explicit MockProcessor(const std::string &name, utils::Identifier uuid)
+ explicit MockProcessor(const std::string &name, const utils::Identifier
&uuid)
: Processor(name, uuid) {
setTriggerWhenEmpty(true);
}
diff --git a/libminifi/test/unit/ProvenanceTestHelper.h
b/libminifi/test/unit/ProvenanceTestHelper.h
index 82f7978..1a00ab3 100644
--- a/libminifi/test/unit/ProvenanceTestHelper.h
+++ b/libminifi/test/unit/ProvenanceTestHelper.h
@@ -278,19 +278,19 @@ class TestFlowController : public minifi::FlowController {
return true;
}
- std::shared_ptr<core::Processor> createProcessor(std::string /*name*/,
utils::Identifier& /*uuid*/) {
+ std::shared_ptr<core::Processor> createProcessor(const std::string&
/*name*/, const utils::Identifier& /*uuid*/) {
return 0;
}
- core::ProcessGroup *createRootProcessGroup(std::string /*name*/,
utils::Identifier& /*uuid*/) {
+ core::ProcessGroup *createRootProcessGroup(const std::string& /*name*/,
const utils::Identifier& /*uuid*/) {
return 0;
}
- core::ProcessGroup *createRemoteProcessGroup(std::string /*name*/,
utils::Identifier& /*uuid*/) {
+ core::ProcessGroup *createRemoteProcessGroup(const std::string& /*name*/,
const utils::Identifier& /*uuid*/) {
return 0;
}
- std::shared_ptr<minifi::Connection> createConnection(std::string /*name*/,
utils::Identifier& /*uuid*/) {
+ std::shared_ptr<minifi::Connection> createConnection(const std::string&
/*name*/, const utils::Identifier& /*uuid*/) {
return 0;
}
};
diff --git a/nanofi/include/cxx/CallbackProcessor.h
b/nanofi/include/cxx/CallbackProcessor.h
index 7b6b78b..92130f1 100644
--- a/nanofi/include/cxx/CallbackProcessor.h
+++ b/nanofi/include/cxx/CallbackProcessor.h
@@ -53,7 +53,7 @@ class CallbackProcessor : public core::Processor {
/*!
* Create a new processor
*/
- CallbackProcessor(std::string name, utils::Identifier uuid =
utils::Identifier())
+ CallbackProcessor(const std::string& name, const utils::Identifier& uuid =
{})
: Processor(std::move(name), uuid) {
}
// Destructor
