This is an automated email from the ASF dual-hosted git repository. szaszm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/nifi-minifi-cpp.git
commit fb54a8dc8e1228a4a06ea3a90936394021c0754d Author: Martin Zink <[email protected]> AuthorDate: Fri Apr 14 18:09:45 2023 +0200 MINIFICPP-2084 Fix flaky Reverse DNS timeout test Closes #1541 Signed-off-by: Marton Szasz <[email protected]> --- extensions/expression-language/tests/ExpressionLanguageTests.cpp | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/extensions/expression-language/tests/ExpressionLanguageTests.cpp b/extensions/expression-language/tests/ExpressionLanguageTests.cpp index f7b162c0e..655f6b699 100644 --- a/extensions/expression-language/tests/ExpressionLanguageTests.cpp +++ b/extensions/expression-language/tests/ExpressionLanguageTests.cpp @@ -1421,15 +1421,9 @@ TEST_CASE("Reverse DNS lookup with valid timeout parameter", "[ExpressionLanguag std::string expected_hostname; flow_file_a->addAttribute("ip_addr", "8.8.8.8"); - SECTION("Should timeout") { - auto reverse_lookup_expr_0ms = expression::compile("${reverseDnsLookup(${ip_addr}, 0)}"); - REQUIRE_NOTHROW(reverse_lookup_expr_0ms(expression::Parameters{flow_file_a}).asString() == "8.8.8.8"); - CHECK(LogTestController::getInstance().contains("reverseDnsLookup timed out")); - } - SECTION("Shouldn't timeout") { auto reverse_lookup_expr_500ms = expression::compile("${reverseDnsLookup(${ip_addr}, 500)}"); - REQUIRE_NOTHROW(reverse_lookup_expr_500ms(expression::Parameters{flow_file_a}).asString() == "dns.google"); + CHECK(reverse_lookup_expr_500ms(expression::Parameters{flow_file_a}).asString() == "dns.google"); CHECK_FALSE(LogTestController::getInstance().contains("reverseDnsLookup timed out", 0ms)); } }
