This is an automated email from the ASF dual-hosted git repository.
scottyaslan pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/nifi.git
The following commit(s) were added to refs/heads/main by this push:
new f70967ec9e NIFI-13111: Removing/Hiding unimplemented features in
preparation for next milestone release (#8710)
f70967ec9e is described below
commit f70967ec9e302ae3f2f57de730d0ec169ec2af2e
Author: Matt Gilman <[email protected]>
AuthorDate: Wed May 1 15:36:32 2024 -0400
NIFI-13111: Removing/Hiding unimplemented features in preparation for next
milestone release (#8710)
* NIFI-13111:
- Removing/Hiding unimplemented features in preparation for next milestone
release.
* NIFI-13111:
- Addressing review feedback.
This closes #8710
---
.../service/canvas-context-menu.service.ts | 18 ++++++++++++------
.../operation-control.component.html | 19 ++++++++++---------
.../connection-status-table.component.html | 11 ++++++++++-
.../process-group-status-table.component.html | 11 +----------
.../processor-status-table.component.html | 12 ++++++------
5 files changed, 39 insertions(+), 32 deletions(-)
diff --git
a/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/service/canvas-context-menu.service.ts
b/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/service/canvas-context-menu.service.ts
index 3e707b2853..8e7977eed0 100644
---
a/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/service/canvas-context-menu.service.ts
+++
b/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/service/canvas-context-menu.service.ts
@@ -293,7 +293,8 @@ export class CanvasContextMenu implements
ContextMenuDefinitionProvider {
menuItems: [
{
condition: (selection: any) => {
- return this.canvasUtils.hasUpstream(selection);
+ // TODO - hasUpstream
+ return false;
},
clazz: 'icon',
text: 'Upstream',
@@ -303,7 +304,8 @@ export class CanvasContextMenu implements
ContextMenuDefinitionProvider {
},
{
condition: (selection: any) => {
- return this.canvasUtils.hasDownstream(selection);
+ // TODO - hasDownstream
+ return false;
},
clazz: 'icon',
text: 'Downstream',
@@ -819,7 +821,8 @@ export class CanvasContextMenu implements
ContextMenuDefinitionProvider {
},
{
condition: (selection: any) => {
- return this.canvasUtils.isProcessGroup(selection);
+ // return this.canvasUtils.isProcessGroup(selection);
+ return false;
},
clazz: 'fa fa-flash',
text: 'Enable all controller services',
@@ -829,7 +832,8 @@ export class CanvasContextMenu implements
ContextMenuDefinitionProvider {
},
{
condition: (selection: any) => {
- return this.canvasUtils.emptySelection(selection);
+ // return this.canvasUtils.emptySelection(selection);
+ return false;
},
clazz: 'fa fa-flash',
text: 'Enable all controller services',
@@ -839,7 +843,8 @@ export class CanvasContextMenu implements
ContextMenuDefinitionProvider {
},
{
condition: (selection: any) => {
- return this.canvasUtils.isProcessGroup(selection);
+ // return this.canvasUtils.isProcessGroup(selection);
+ return false;
},
clazz: 'icon icon-enable-false',
text: 'Disable all controller services',
@@ -849,7 +854,8 @@ export class CanvasContextMenu implements
ContextMenuDefinitionProvider {
},
{
condition: (selection: any) => {
- return this.canvasUtils.emptySelection(selection);
+ // return this.canvasUtils.emptySelection(selection);
+ return false;
},
clazz: 'icon icon-enable-false',
text: 'Disable all controller services',
diff --git
a/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/graph-controls/operation-control/operation-control.component.html
b/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/graph-controls/operation-control/operation-control.component.html
index 1a0e39ec2e..82092e1d1d 100644
---
a/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/graph-controls/operation-control/operation-control.component.html
+++
b/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/graph-controls/operation-control/operation-control.component.html
@@ -129,15 +129,16 @@
(click)="group(selection)">
<i class="ml-1 icon icon-group"></i>
</button>
- <button
- mat-icon-button
- color="primary"
- class="mr-2"
- type="button"
- [disabled]="!canColor(selection)"
- (click)="color(selection)">
- <i class="fa fa-paint-brush"></i>
- </button>
+ <!-- TODO - Add support for coloring processors and
labels -->
+ <!-- <button-->
+ <!-- mat-icon-button-->
+ <!-- color="primary"-->
+ <!-- class="mr-2"-->
+ <!-- type="button"-->
+ <!--
[disabled]="!canColor(selection)"-->
+ <!--
(click)="color(selection)">-->
+ <!-- <i class="fa
fa-paint-brush"></i>-->
+ <!-- </button>-->
<button
mat-icon-button
color="primary"
diff --git
a/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/summary/ui/connection-status-listing/connection-status-table/connection-status-table.component.html
b/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/summary/ui/connection-status-listing/connection-status-table/connection-status-table.component.html
index 634b33e87e..118f146635 100644
---
a/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/summary/ui/connection-status-listing/connection-status-table/connection-status-table.component.html
+++
b/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/summary/ui/connection-status-listing/connection-status-table/connection-status-table.component.html
@@ -44,7 +44,16 @@
<ng-container matColumnDef="moreDetails">
<th mat-header-cell *matHeaderCellDef></th>
<td mat-cell *matCellDef="let item">
- <div class="flex items-center
gap-x-2"></div>
+ @if (canRead(item)) {
+ <div class="flex items-center gap-x-2">
+ <!-- TODO - support showing
connection details in EditConnectionDialog -->
+ <!--
@if (canRead(item)) {-->
+ <!--
<div-->
+ <!--
class="pointer fa fa-info-circle primary-color"-->
+ <!--
title="View Connection Details"></div>-->
+ <!--
}-->
+ </div>
+ }
</td>
</ng-container>
diff --git
a/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/summary/ui/process-group-status-listing/process-group-status-table/process-group-status-table.component.html
b/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/summary/ui/process-group-status-listing/process-group-status-table/process-group-status-table.component.html
index 62bb03ce39..7060b4f672 100644
---
a/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/summary/ui/process-group-status-listing/process-group-status-table/process-group-status-table.component.html
+++
b/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/summary/ui/process-group-status-listing/process-group-status-table/process-group-status-table.component.html
@@ -43,16 +43,7 @@
<ng-container matColumnDef="moreDetails">
<th mat-header-cell *matHeaderCellDef></th>
<td mat-cell *matCellDef="let item">
- @if (canRead(item)) {
- <div class="flex items-center gap-x-2">
- <!-- TODO - handle read only in
configure component? -->
- @if (canRead(item)) {
- <div
- class="pointer fa
fa-info-circle primary-color"
- title="View Process Group
Details"></div>
- }
- </div>
- }
+ <div class="flex items-center
gap-x-2"></div>
</td>
</ng-container>
diff --git
a/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/summary/ui/processor-status-listing/processor-status-table/processor-status-table.component.html
b/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/summary/ui/processor-status-listing/processor-status-table/processor-status-table.component.html
index c42b553f6b..9e0466ecf2 100644
---
a/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/summary/ui/processor-status-listing/processor-status-table/processor-status-table.component.html
+++
b/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/summary/ui/processor-status-listing/processor-status-table/processor-status-table.component.html
@@ -45,12 +45,12 @@
<td mat-cell *matCellDef="let item">
@if (canRead(item)) {
<div class="flex items-center gap-x-2">
- <!-- TODO - handle read only in
configure component? -->
- @if (canRead(item)) {
- <div
- class="pointer fa
fa-info-circle primary-color"
- title="View Processor
Details"></div>
- }
+ <!-- TODO - support showing
processor details in EditProcessorDialog -->
+ <!--
@if (canRead(item)) {-->
+ <!--
<div-->
+ <!--
class="pointer fa fa-info-circle primary-color"-->
+ <!--
title="View Processor Details"></div>-->
+ <!--
}-->
</div>
}
</td>
