(nifi) branch main updated: NIFI-13375 Added missing logging parameter in SplitRecord

[mosermw]

This is an automated email from the ASF dual-hosted git repository.

mosermw pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/nifi.git


The following commit(s) were added to refs/heads/main by this push:
     new 27866c8ae6 NIFI-13375 Added missing logging parameter in SplitRecord
27866c8ae6 is described below

commit 27866c8ae6b0097743e6137728fd5e5b28df8c30
Author: dan-s1 <dsti...@gmail.com>
AuthorDate: Fri Jun 7 21:04:32 2024 +0000

    NIFI-13375 Added missing logging parameter in SplitRecord
    
    Signed-off-by: Mike Moser <mose...@apache.org>
    
    This closes #8941
---
 .../java/org/apache/nifi/processors/standard/SplitRecord.java    | 2 +-
 .../org/apache/nifi/processors/standard/TestSplitRecord.java     | 9 +++++++++
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git 
a/nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/SplitRecord.java
 
b/nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/SplitRecord.java
index 9f72452aad..0b441c08d1 100644
--- 
a/nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/SplitRecord.java
+++ 
b/nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/SplitRecord.java
@@ -198,7 +198,7 @@ public class SplitRecord extends AbstractProcessor {
                 }
             });
         } catch (final ProcessException pe) {
-            getLogger().error("Failed to split", original, pe);
+            getLogger().error("Failed to split {}", original, pe);
             session.remove(splits);
             session.transfer(original, REL_FAILURE);
             return;
diff --git 
a/nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestSplitRecord.java
 
b/nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestSplitRecord.java
index b59e985d6d..a3e4926bbf 100644
--- 
a/nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestSplitRecord.java
+++ 
b/nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestSplitRecord.java
@@ -22,12 +22,15 @@ import org.apache.nifi.reporting.InitializationException;
 import org.apache.nifi.serialization.record.MockRecordParser;
 import org.apache.nifi.serialization.record.MockRecordWriter;
 import org.apache.nifi.serialization.record.RecordFieldType;
+import org.apache.nifi.util.LogMessage;
+import org.apache.nifi.util.MockComponentLog;
 import org.apache.nifi.util.MockFlowFile;
 import org.apache.nifi.util.TestRunner;
 import org.apache.nifi.util.TestRunners;
 import org.junit.jupiter.api.Test;
 
 import java.util.List;
+import java.util.Optional;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertTrue;
@@ -191,6 +194,12 @@ public class TestSplitRecord {
         runner.assertAllFlowFilesTransferred(SplitRecord.REL_FAILURE, 1);
         final MockFlowFile failed = 
runner.getFlowFilesForRelationship(SplitRecord.REL_FAILURE).get(0);
         assertTrue(original == failed);
+
+        final MockComponentLog logger = runner.getLogger();
+        final Optional<LogMessage> logMessage = 
logger.getErrorMessages().stream()
+                .filter(msg -> msg.getMsg().contains("Failed to split 
FlowFile"))
+                .findFirst();
+        assertTrue((logMessage.isPresent()));
     }
 
 }