This is an automated email from the ASF dual-hosted git repository.

szaszm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/nifi-minifi-cpp.git

commit 049e126b116f9b6f1dde291ab21a50dbf1eeba03
Author: Martin Zink <[email protected]>
AuthorDate: Fri Mar 28 15:43:29 2025 +0100

    MINIFICPP-2548 Dont fail flow-update when FlowController is not running
    
    I couldnt see any reason for this condition, and it does seem to cause 
update failures (race conditions).
    I've seen this intermittently failing docker tests.
    
    Closes #1951
    
    Signed-off-by: Marton Szasz <[email protected]>
---
 libminifi/src/FlowController.cpp | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/libminifi/src/FlowController.cpp b/libminifi/src/FlowController.cpp
index 89d210fce..758474569 100644
--- a/libminifi/src/FlowController.cpp
+++ b/libminifi/src/FlowController.cpp
@@ -121,9 +121,6 @@ nonstd::expected<void, std::string> 
FlowController::applyConfiguration(const std
   if (newRoot == nullptr)
     return nonstd::make_unexpected("Could not create root process group");
 
-  if (!isRunning())
-    return nonstd::make_unexpected("FlowController is not running");
-
   logger_->log_info("Starting to reload Flow Controller with flow control name 
{}, version {}", newRoot->getName(), newRoot->getVersion());
 
   bool started = false;

Reply via email to