This is an automated email from the ASF dual-hosted git repository.
pvillard pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/nifi.git
The following commit(s) were added to refs/heads/main by this push:
new 3caca7b2ab NIFI-14829 Added the missing comma in PMD LooseCoupling
rule exclusions.
3caca7b2ab is described below
commit 3caca7b2abf8f62ddd2eb83c47e41498d68b5758
Author: dan-s1 <[email protected]>
AuthorDate: Thu Aug 7 21:27:53 2025 +0000
NIFI-14829 Added the missing comma in PMD LooseCoupling rule exclusions.
Signed-off-by: Pierre Villard <[email protected]>
This closes #10179.
---
.../java/org/apache/nifi/processors/gcp/drive/ListGoogleDrive.java | 2 +-
.../java/org/apache/nifi/processors/gcp/drive/PutGoogleDrive.java | 2 +-
.../org/apache/nifi/processors/gcp/drive/AbstractGoogleDriveIT.java | 4 ++--
.../org/apache/nifi/processors/gcp/drive/FetchGoogleDriveIT.java | 2 +-
.../src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java | 2 +-
.../org/apache/nifi/processors/mongodb/PutMongoBulkOperations.java | 2 +-
.../java/org/apache/nifi/processors/mongodb/RunMongoAggregation.java | 2 +-
pmd-ruleset.xml | 5 ++++-
8 files changed, 12 insertions(+), 9 deletions(-)
diff --git
a/nifi-extension-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/drive/ListGoogleDrive.java
b/nifi-extension-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/drive/ListGoogleDrive.java
index 2a0df50f8d..c2483b6c90 100644
---
a/nifi-extension-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/drive/ListGoogleDrive.java
+++
b/nifi-extension-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/drive/ListGoogleDrive.java
@@ -327,7 +327,7 @@ public class ListGoogleDrive extends
AbstractListProcessor<GoogleDriveFileInfo>
String pageToken = null;
do {
- final FileList result = driveService.files()
+ final FileList result = driveService.files() //NOPMD
.list()
.setSupportsAllDrives(true)
.setIncludeItemsFromAllDrives(true)
diff --git
a/nifi-extension-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/drive/PutGoogleDrive.java
b/nifi-extension-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/drive/PutGoogleDrive.java
index fc1816e0c8..8cd42c25cb 100644
---
a/nifi-extension-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/drive/PutGoogleDrive.java
+++
b/nifi-extension-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/drive/PutGoogleDrive.java
@@ -377,7 +377,7 @@ public class PutGoogleDrive extends AbstractProcessor
implements GoogleDriveTrai
}
private Optional<File> checkFileExistence(String fileName, String
parentId) throws IOException {
- final FileList result = driveService.files()
+ final FileList result = driveService.files() //NOPMD
.list()
.setSupportsAllDrives(true)
.setIncludeItemsFromAllDrives(true)
diff --git
a/nifi-extension-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/test/java/org/apache/nifi/processors/gcp/drive/AbstractGoogleDriveIT.java
b/nifi-extension-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/test/java/org/apache/nifi/processors/gcp/drive/AbstractGoogleDriveIT.java
index 76a464e8d0..03810ad661 100644
---
a/nifi-extension-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/test/java/org/apache/nifi/processors/gcp/drive/AbstractGoogleDriveIT.java
+++
b/nifi-extension-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/test/java/org/apache/nifi/processors/gcp/drive/AbstractGoogleDriveIT.java
@@ -123,7 +123,7 @@ public abstract class AbstractGoogleDriveIT<T extends
GoogleDriveTrait & Process
fileMetaData.setMimeType("application/vnd.google-apps.folder");
- Drive.Files.Create create = driveService.files()
+ Drive.Files.Create create = driveService.files() //NOPMD
.create(fileMetaData)
.setSupportsAllDrives(true)
.setFields("id");
@@ -144,7 +144,7 @@ public abstract class AbstractGoogleDriveIT<T extends
GoogleDriveTrait & Process
AbstractInputStreamContent content = new
ByteArrayContent("text/plain", fileContent.getBytes(StandardCharsets.UTF_8));
- Drive.Files.Create create = driveService.files()
+ Drive.Files.Create create = driveService.files() //NOPMD
.create(fileMetadata, content)
.setSupportsAllDrives(true)
.setFields("id, name, modifiedTime, createdTime");
diff --git
a/nifi-extension-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/test/java/org/apache/nifi/processors/gcp/drive/FetchGoogleDriveIT.java
b/nifi-extension-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/test/java/org/apache/nifi/processors/gcp/drive/FetchGoogleDriveIT.java
index 49efc5df4b..2ffbda24ee 100644
---
a/nifi-extension-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/test/java/org/apache/nifi/processors/gcp/drive/FetchGoogleDriveIT.java
+++
b/nifi-extension-bundles/nifi-gcp-bundle/nifi-gcp-processors/src/test/java/org/apache/nifi/processors/gcp/drive/FetchGoogleDriveIT.java
@@ -57,7 +57,7 @@ public class FetchGoogleDriveIT extends
AbstractGoogleDriveIT<FetchGoogleDrive>
inputFlowFileAttributes.put(GoogleDriveAttributes.SIZE_AVAILABLE,
"true");
inputFlowFileAttributes.put(GoogleDriveAttributes.MIME_TYPE,
"text/plain");
- HashSet<Map<String, String>> expectedAttributes = new
HashSet<>(singletonList(inputFlowFileAttributes));
+ Set<Map<String, String>> expectedAttributes = new
HashSet<>(singletonList(inputFlowFileAttributes));
List<String> expectedContent = singletonList(DEFAULT_FILE_CONTENT);
testRunner.enqueue("unimportant_data", inputFlowFileAttributes);
diff --git
a/nifi-extension-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java
b/nifi-extension-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java
index a1b61c598e..3f0edec4fc 100644
---
a/nifi-extension-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java
+++
b/nifi-extension-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java
@@ -247,7 +247,7 @@ public class PutMongo extends AbstractMongoProcessor {
if (Objects.equals(updateOperationMode,
UPDATE_WITH_DOC.getValue())) {
updateResult = collection.replaceOne(updateQuery,
(Document) doc, new ReplaceOptions().upsert(upsert));
} else {
- BasicDBObject update = (BasicDBObject) doc;
+ BasicDBObject update = (BasicDBObject) doc; //NOPMD
update.remove(updateKey);
UpdateOptions updateOptions = new
UpdateOptions().upsert(upsert);
UpdateMethod updateQueryMode =
context.getProperty(UPDATE_METHOD).asAllowableValue(UpdateMethod.class);
diff --git
a/nifi-extension-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongoBulkOperations.java
b/nifi-extension-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongoBulkOperations.java
index fafde5bd6e..047ddcea14 100644
---
a/nifi-extension-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongoBulkOperations.java
+++
b/nifi-extension-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongoBulkOperations.java
@@ -127,7 +127,7 @@ public class PutMongoBulkOperations extends
AbstractMongoProcessor {
final BsonArrayCodec arrayCodec = new BsonArrayCodec();
final DecoderContext decoderContext =
DecoderContext.builder().build();
- final BsonArray updateItems;
+ final BsonArray updateItems; //NOPMD
try (final Reader reader = new
InputStreamReader(session.read(flowFile), charset)) {
updateItems = arrayCodec.decode(new JsonReader(reader),
decoderContext);
}
diff --git
a/nifi-extension-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/RunMongoAggregation.java
b/nifi-extension-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/RunMongoAggregation.java
index 480b08f679..6a5fac2d5a 100644
---
a/nifi-extension-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/RunMongoAggregation.java
+++
b/nifi-extension-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/RunMongoAggregation.java
@@ -71,7 +71,7 @@ public class RunMongoAggregation extends
AbstractMongoProcessor {
ObjectMapper mapper = new ObjectMapper();
List<Map> querySteps = mapper.readValue(query, List.class);
for (Map<?, ?> queryStep : querySteps) {
- BasicDBObject bson =
BasicDBObject.parse(mapper.writeValueAsString(queryStep));
+ BasicDBObject bson =
BasicDBObject.parse(mapper.writeValueAsString(queryStep)); //NOPMD
result.add(bson);
}
diff --git a/pmd-ruleset.xml b/pmd-ruleset.xml
index f00c12c596..9b59461b28 100644
--- a/pmd-ruleset.xml
+++ b/pmd-ruleset.xml
@@ -44,10 +44,13 @@ under the License.
java.util.Properties,
java.util.jar.Attributes,
jakarta.ws.rs.core.MultivaluedHashMap,
+ com.google.api.services.drive.DriveRequest,
com.google.api.services.drive.model.File,
+ com.google.cloud.bigquery.FieldValueList,
+ org.bson.BsonDocument,
org.bson.Document,
com.nimbusds.oauth2.sdk.Scope,
-
org.apache.nifi.attribute.expression.language.ValueLookup
+
org.apache.nifi.attribute.expression.language.ValueLookup,
org.apache.nifi.processor.util.listen.queue.TrackingLinkedBlockingQueue
" />
</properties>
