This is an automated email from the ASF dual-hosted git repository. adebreceni pushed a commit to branch minifi-api-reduced in repository https://gitbox.apache.org/repos/asf/nifi-minifi-cpp.git
commit fc75710b3a4441190d4ed472a604fcc74f24a4df Author: Adam Debreceni <[email protected]> AuthorDate: Mon Jun 23 13:04:19 2025 +0200 Add dtor, review changes --- extensions/expression-language/ProcessContextExpr.h | 2 +- libminifi/include/ForwardingNode.h | 2 ++ libminifi/include/Port.h | 4 ++++ 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/extensions/expression-language/ProcessContextExpr.h b/extensions/expression-language/ProcessContextExpr.h index 228b1e35f..3aa822d83 100644 --- a/extensions/expression-language/ProcessContextExpr.h +++ b/extensions/expression-language/ProcessContextExpr.h @@ -39,7 +39,7 @@ class ProcessContextExpr final : public core::ProcessContextImpl { nonstd::expected<std::string, std::error_code> getProperty(std::string_view name, const FlowFile*) const override; nonstd::expected<std::string, std::error_code> getDynamicProperty(std::string_view name, const FlowFile*) const override; -// + nonstd::expected<void, std::error_code> setProperty(std::string_view name, std::string value) override; nonstd::expected<void, std::error_code> setDynamicProperty(std::string name, std::string value) override; diff --git a/libminifi/include/ForwardingNode.h b/libminifi/include/ForwardingNode.h index 914d62e43..fb173debf 100644 --- a/libminifi/include/ForwardingNode.h +++ b/libminifi/include/ForwardingNode.h @@ -41,6 +41,8 @@ class ForwardingNode : public core::ProcessorImpl { void initialize() override; void onTrigger(core::ProcessContext& context, core::ProcessSession& session) override; + + ~ForwardingNode() override = default; }; } // namespace org::apache::nifi::minifi diff --git a/libminifi/include/Port.h b/libminifi/include/Port.h index 0cfd06133..8f1e20caf 100644 --- a/libminifi/include/Port.h +++ b/libminifi/include/Port.h @@ -41,6 +41,8 @@ class PortImpl final : public ForwardingNode { return port_type_; } + ~PortImpl() override = default; + MINIFIAPI static constexpr core::annotation::Input InputRequirement = core::annotation::Input::INPUT_ALLOWED; ADD_COMMON_VIRTUAL_FUNCTIONS_FOR_PROCESSORS @@ -57,6 +59,8 @@ class Port : public core::Processor { gsl_Assert(port_impl); return port_impl->getPortType(); } + + ~Port() override = default; }; } // namespace org::apache::nifi::minifi
