This is an automated email from the ASF dual-hosted git repository.

mcgilman pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/nifi.git


The following commit(s) were added to refs/heads/main by this push:
     new 73411878b1 NIFI-14984 - prevent ENTER from adding a new line in 
codemirror editors if the component is not dirty (#10316)
73411878b1 is described below

commit 73411878b1a8ea586e27072e4195ddcff4fae2ce
Author: Rob Fellows <[email protected]>
AuthorDate: Wed Sep 17 12:22:51 2025 -0400

    NIFI-14984 - prevent ENTER from adding a new line in codemirror editors if 
the component is not dirty (#10316)
---
 .../ui/common/property-table/editors/nf-editor/nf-editor.component.ts  | 3 +--
 .../src/app/pages/update-attribute/ui/ua-editor/ua-editor.component.ts | 3 +--
 .../components/map-table/editors/text-editor/text-editor.component.ts  | 3 +--
 3 files changed, 3 insertions(+), 6 deletions(-)

diff --git 
a/nifi-frontend/src/main/frontend/apps/nifi/src/app/ui/common/property-table/editors/nf-editor/nf-editor.component.ts
 
b/nifi-frontend/src/main/frontend/apps/nifi/src/app/ui/common/property-table/editors/nf-editor/nf-editor.component.ts
index e712d41ec3..2fecbf3846 100644
--- 
a/nifi-frontend/src/main/frontend/apps/nifi/src/app/ui/common/property-table/editors/nf-editor/nf-editor.component.ts
+++ 
b/nifi-frontend/src/main/frontend/apps/nifi/src/app/ui/common/property-table/editors/nf-editor/nf-editor.component.ts
@@ -167,9 +167,8 @@ export class NfEditor {
                         run: () => {
                             if (this.nfEditorForm.dirty && 
this.nfEditorForm.valid) {
                                 this.okClicked();
-                                return true;
                             }
-                            return false;
+                            return true;
                         }
                     },
                     ...defaultKeymap,
diff --git 
a/nifi-frontend/src/main/frontend/apps/update-attribute/src/app/pages/update-attribute/ui/ua-editor/ua-editor.component.ts
 
b/nifi-frontend/src/main/frontend/apps/update-attribute/src/app/pages/update-attribute/ui/ua-editor/ua-editor.component.ts
index 053e273e24..c4f6762242 100644
--- 
a/nifi-frontend/src/main/frontend/apps/update-attribute/src/app/pages/update-attribute/ui/ua-editor/ua-editor.component.ts
+++ 
b/nifi-frontend/src/main/frontend/apps/update-attribute/src/app/pages/update-attribute/ui/ua-editor/ua-editor.component.ts
@@ -148,9 +148,8 @@ export class UaEditor {
                         run: () => {
                             if (this.uaEditorForm.dirty && 
this.uaEditorForm.valid) {
                                 this.okClicked();
-                                return true;
                             }
-                            return false;
+                            return true;
                         }
                     },
                     ...defaultKeymap,
diff --git 
a/nifi-frontend/src/main/frontend/libs/shared/src/components/map-table/editors/text-editor/text-editor.component.ts
 
b/nifi-frontend/src/main/frontend/libs/shared/src/components/map-table/editors/text-editor/text-editor.component.ts
index f3edb56607..fe46154196 100644
--- 
a/nifi-frontend/src/main/frontend/libs/shared/src/components/map-table/editors/text-editor/text-editor.component.ts
+++ 
b/nifi-frontend/src/main/frontend/libs/shared/src/components/map-table/editors/text-editor/text-editor.component.ts
@@ -182,9 +182,8 @@ export class TextEditor {
                     run: () => {
                         if (this.textEditorForm.dirty && 
this.textEditorForm.valid) {
                             this.okClicked();
-                            return true;
                         }
-                        return false;
+                        return true;
                     }
                 },
                 ...defaultKeymap,

Reply via email to