This is an automated email from the ASF dual-hosted git repository. lordgamez pushed a commit to branch MINIFICPP-2629 in repository https://gitbox.apache.org/repos/asf/nifi-minifi-cpp.git
commit b40f7af791a22ad3252f00a28d04d36e6f0e51e4 Author: Gabor Gyimesi <[email protected]> AuthorDate: Tue Sep 23 14:26:03 2025 +0200 Review update --- .clang-tidy | 1 - core-framework/src/utils/SystemCpuUsageTracker.cpp | 3 ++- extensions/sftp/processors/ListSFTP.cpp | 2 +- extensions/standard-processors/processors/AttributeRollingWindow.cpp | 2 +- extensions/standard-processors/processors/SplitText.cpp | 2 +- extensions/standard-processors/tests/unit/SplitTextTests.cpp | 2 +- extensions/standard-processors/utils/JoltUtils.h | 2 +- libminifi/test/unit/ResponseNodeLoaderTests.cpp | 2 +- 8 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.clang-tidy b/.clang-tidy index 50c7f52a2..3e7311914 100644 --- a/.clang-tidy +++ b/.clang-tidy @@ -252,7 +252,6 @@ Checks: > readability-avoid-return-with-void-value, readability-avoid-unconditional-preprocessor-if, readability-enum-initial-value, - readability-math-missing-parentheses, readability-operators-representation, readability-redundant-casting, readability-redundant-inline-specifier, diff --git a/core-framework/src/utils/SystemCpuUsageTracker.cpp b/core-framework/src/utils/SystemCpuUsageTracker.cpp index 39cc663f8..65c7d57b3 100644 --- a/core-framework/src/utils/SystemCpuUsageTracker.cpp +++ b/core-framework/src/utils/SystemCpuUsageTracker.cpp @@ -44,7 +44,8 @@ void SystemCpuUsageTracker::queryCpuTimes() { previous_total_sys_ = total_sys_; previous_total_idle_ = total_idle_; gsl::owner<FILE*> file = fopen("/proc/stat", "r"); - if (fscanf(file, "cpu %lu %lu %lu %lu", &total_user_, &total_user_low_, &total_sys_, &total_idle_) != 4) { // NOLINT(cert-err34-c,clang-analyzer-unix.Stream) + if (!file) { return; } + if (fscanf(file, "cpu %lu %lu %lu %lu", &total_user_, &total_user_low_, &total_sys_, &total_idle_) != 4) { // NOLINT(cert-err34-c) total_user_ = previous_total_user_; total_user_low_ = previous_total_user_low_; total_idle_ = previous_total_idle_; diff --git a/extensions/sftp/processors/ListSFTP.cpp b/extensions/sftp/processors/ListSFTP.cpp index 0bd2975e6..82dd1b062 100644 --- a/extensions/sftp/processors/ListSFTP.cpp +++ b/extensions/sftp/processors/ListSFTP.cpp @@ -690,7 +690,7 @@ void ListSFTP::listByTrackingEntities( time_t now = time(nullptr); uint64_t min_timestamp_to_list = (!initial_listing_complete_ && entity_tracking_initial_listing_target_ == ENTITY_TRACKING_INITIAL_LISTING_TARGET_ALL_AVAILABLE) - ? 0U : ((now * 1000) - entity_tracking_time_window.count()); + ? 0U : (now * 1000 - entity_tracking_time_window.count()); /* Skip files not in the tracking window */ for (auto it = files.begin(); it != files.end(); ) { diff --git a/extensions/standard-processors/processors/AttributeRollingWindow.cpp b/extensions/standard-processors/processors/AttributeRollingWindow.cpp index c46631b47..1eecb36c2 100644 --- a/extensions/standard-processors/processors/AttributeRollingWindow.cpp +++ b/extensions/standard-processors/processors/AttributeRollingWindow.cpp @@ -113,7 +113,7 @@ void AttributeRollingWindow::calculateAndSetAttributes(core::FlowFile &flow_file }()); // https://math.stackexchange.com/questions/1720876/sums-of-squares-minus-square-of-sums const auto avg_of_squares = std::accumulate(std::begin(sorted_values), std::end(sorted_values), 0.0, [&](double acc, double value) { - return acc + (std::pow(value, 2) / gsl::narrow_cast<double>(sorted_values.size())); + return acc + std::pow(value, 2) / gsl::narrow_cast<double>(sorted_values.size()); }); const auto variance = avg_of_squares - std::pow(mean, 2); set_aggregate("variance", variance); diff --git a/extensions/standard-processors/processors/SplitText.cpp b/extensions/standard-processors/processors/SplitText.cpp index 0e43494c5..60dc02442 100644 --- a/extensions/standard-processors/processors/SplitText.cpp +++ b/extensions/standard-processors/processors/SplitText.cpp @@ -53,7 +53,7 @@ uint8_t LineReader::getEndLineSize(size_t newline_position) { } void LineReader::setLastLineInfoAttributes(uint8_t endline_size, const std::optional<std::string>& starts_with) { - const uint64_t size_from_beginning_of_stream = ((current_buffer_count_ - 1) * buffer_size_) + buffer_offset_; + const uint64_t size_from_beginning_of_stream = (current_buffer_count_ - 1) * buffer_size_ + buffer_offset_; if (last_line_info_) { LineInfo previous_line_info = *last_line_info_; last_line_info_->offset = previous_line_info.offset + previous_line_info.size; diff --git a/extensions/standard-processors/tests/unit/SplitTextTests.cpp b/extensions/standard-processors/tests/unit/SplitTextTests.cpp index 4e8297a93..53c437627 100644 --- a/extensions/standard-processors/tests/unit/SplitTextTests.cpp +++ b/extensions/standard-processors/tests/unit/SplitTextTests.cpp @@ -81,7 +81,7 @@ TEST_CASE("Test LineReader with input larger than buffer length") { TEST_CASE("Test LineReader with input of same size as buffer length") { auto stream = std::make_shared<io::BufferStream>(); - std::string input = std::string(BUFFER_SIZE - 1, 'a') + "\n" + std::string((BUFFER_SIZE * 2) - 1, 'b') + "\n"; + std::string input = std::string(BUFFER_SIZE - 1, 'a') + "\n" + std::string(BUFFER_SIZE * 2 - 1, 'b') + "\n"; stream->write(reinterpret_cast<const uint8_t*>(input.data()), input.size()); processors::detail::LineReader reader{stream, BUFFER_SIZE}; CHECK(reader.readNextLine() == processors::detail::LineReader::LineInfo{.offset = 0, .size = BUFFER_SIZE, .endline_size = 1}); diff --git a/extensions/standard-processors/utils/JoltUtils.h b/extensions/standard-processors/utils/JoltUtils.h index c9b208233..a6b0a0947 100644 --- a/extensions/standard-processors/utils/JoltUtils.h +++ b/extensions/standard-processors/utils/JoltUtils.h @@ -58,7 +58,7 @@ class Spec { return nullptr; } - template<std::invocable<const std::shared_ptr<core::logging::Logger>&> OnEnterFn, std::invocable<const std::shared_ptr<core::logging::Logger>&> OnExitFn> + template<std::invocable<std::shared_ptr<core::logging::Logger>> OnEnterFn, std::invocable<std::shared_ptr<core::logging::Logger>> OnExitFn> ::gsl::final_action<std::function<void()>> log(OnEnterFn on_enter, OnExitFn on_exit) const { if (logger) { on_enter(logger); diff --git a/libminifi/test/unit/ResponseNodeLoaderTests.cpp b/libminifi/test/unit/ResponseNodeLoaderTests.cpp index bb18aa836..59d7e241f 100644 --- a/libminifi/test/unit/ResponseNodeLoaderTests.cpp +++ b/libminifi/test/unit/ResponseNodeLoaderTests.cpp @@ -50,7 +50,7 @@ class ResponseNodeLoaderTestFixture { } protected: - template<typename T> requires(std::is_base_of_v<minifi::core::ProcessorImpl, T>) + template<typename T> requires std::is_base_of_v<minifi::core::ProcessorImpl, T> minifi::utils::Identifier addProcessor(const std::string& name) { auto processor = minifi::test::utils::make_processor<T>(name); auto uuid = processor->getUUID();
