This is an automated email from the ASF dual-hosted git repository.
martinzink pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/nifi-minifi-cpp.git
The following commit(s) were added to refs/heads/main by this push:
new d9910d094 MINIFICPP-2796 Remove workIsAvailable from C API (#2164)
d9910d094 is described below
commit d9910d094fea73a65544bd262bf5dd7fdba8dfd6
Author: Martin Zink <[email protected]>
AuthorDate: Mon May 4 16:55:44 2026 +0200
MINIFICPP-2796 Remove workIsAvailable from C API (#2164)
---
.../cpp-extension-lib/include/api/core/ProcessorImpl.h | 2 --
extension-framework/cpp-extension-lib/include/api/core/Resource.h | 3 ---
extension-framework/cpp-extension-lib/src/core/ProcessorImpl.cpp | 4 ----
libminifi/include/utils/CProcessor.h | 3 ++-
minifi-api/include/minifi-c/minifi-c.h | 3 +--
5 files changed, 3 insertions(+), 12 deletions(-)
diff --git
a/extension-framework/cpp-extension-lib/include/api/core/ProcessorImpl.h
b/extension-framework/cpp-extension-lib/include/api/core/ProcessorImpl.h
index a5753b2d3..2a5c90d52 100644
--- a/extension-framework/cpp-extension-lib/include/api/core/ProcessorImpl.h
+++ b/extension-framework/cpp-extension-lib/include/api/core/ProcessorImpl.h
@@ -67,8 +67,6 @@ class ProcessorImpl {
virtual void onUnSchedule() {}
- virtual bool isWorkAvailable();
-
static constexpr auto DynamicProperties =
std::array<minifi::core::DynamicPropertyDefinition, 0>{};
static constexpr auto OutputAttributes =
std::array<minifi::core::OutputAttributeReference, 0>{};
diff --git a/extension-framework/cpp-extension-lib/include/api/core/Resource.h
b/extension-framework/cpp-extension-lib/include/api/core/Resource.h
index 292a99639..ef934af95 100644
--- a/extension-framework/cpp-extension-lib/include/api/core/Resource.h
+++ b/extension-framework/cpp-extension-lib/include/api/core/Resource.h
@@ -103,9 +103,6 @@ void useProcessorClassDescription(Fn&& fn) {
.destroy = [] (MINIFI_OWNED void* self) -> void {
delete static_cast<Class*>(self);
},
- .isWorkAvailable = [] (void* self) -> MinifiBool {
- return static_cast<Class*>(self)->isWorkAvailable();
- },
.getTriggerWhenEmpty = [] (void* self) -> MinifiBool {
return static_cast<Class*>(self)->getTriggerWhenEmpty();
},
diff --git a/extension-framework/cpp-extension-lib/src/core/ProcessorImpl.cpp
b/extension-framework/cpp-extension-lib/src/core/ProcessorImpl.cpp
index 328a89adc..077d95929 100644
--- a/extension-framework/cpp-extension-lib/src/core/ProcessorImpl.cpp
+++ b/extension-framework/cpp-extension-lib/src/core/ProcessorImpl.cpp
@@ -40,10 +40,6 @@ ProcessorImpl::~ProcessorImpl() {
logger_->log_debug("Destroying processor {} with uuid {}", getName(),
getUUIDStr());
}
-bool ProcessorImpl::isWorkAvailable() {
- return false;
-}
-
std::string ProcessorImpl::getName() const {
return metadata_.name;
}
diff --git a/libminifi/include/utils/CProcessor.h
b/libminifi/include/utils/CProcessor.h
index 210f82b06..cfa3ea2d6 100644
--- a/libminifi/include/utils/CProcessor.h
+++ b/libminifi/include/utils/CProcessor.h
@@ -81,8 +81,9 @@ class CProcessor : public minifi::core::ProcessorApi {
class_description_.callbacks.destroy(impl_);
}
+ // C API doesnt yet expose isWorkAvailable
bool isWorkAvailable() override {
- return
static_cast<bool>(class_description_.callbacks.isWorkAvailable(impl_));
+ return false;
}
void restore(const std::shared_ptr<minifi::core::FlowFile>& /*file*/)
override {
diff --git a/minifi-api/include/minifi-c/minifi-c.h
b/minifi-api/include/minifi-c/minifi-c.h
index ad9de505a..97c969ab4 100644
--- a/minifi-api/include/minifi-c/minifi-c.h
+++ b/minifi-api/include/minifi-c/minifi-c.h
@@ -42,7 +42,7 @@ extern "C" {
#endif
enum : uint32_t {
- MINIFI_API_VERSION = 2
+ MINIFI_API_VERSION = 3
};
typedef bool MinifiBool;
@@ -165,7 +165,6 @@ typedef struct MinifiControllerServiceMetadata {
typedef struct MinifiProcessorCallbacks {
MINIFI_OWNED void*(*create)(MinifiProcessorMetadata);
void(*destroy)(MINIFI_OWNED void*);
- MinifiBool(*isWorkAvailable)(void*);
MinifiBool(*getTriggerWhenEmpty)(void*);
MinifiStatus(*onTrigger)(void*, MinifiProcessContext*,
MinifiProcessSession*);
MinifiStatus(*onSchedule)(void*, MinifiProcessContext*);