This is an automated email from the ASF dual-hosted git repository.
exceptionfactory pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/nifi.git
The following commit(s) were added to refs/heads/main by this push:
new 96f2b5bf958 NIFI-16144 Removed redundant String operations (#11476)
96f2b5bf958 is described below
commit 96f2b5bf958816dadcb9ac61116f1dcacc5d40a7
Author: dan-s1 <[email protected]>
AuthorDate: Fri Jul 24 21:11:12 2026 -0400
NIFI-16144 Removed redundant String operations (#11476)
Signed-off-by: David Handermann <[email protected]>
---
.../authorization/util/IdentityMappingUtil.java | 2 +-
.../nifi/remote/protocol/SiteToSiteTestUtils.java | 2 +-
.../nifi/processors/graph/ExecuteGraphQuery.java | 2 +-
.../mongodb/AbstractMongoQueryProcessor.java | 2 +-
.../nifi/processors/mongodb/DeleteMongo.java | 4 +-
.../nifi/processors/mongodb/QueryHelper.java | 2 +-
.../processors/mongodb/gridfs/FetchGridFS.java | 2 +-
.../processors/parquet/ConvertAvroToParquet.java | 2 +-
.../nifi/processors/pgp/SignContentPGPTest.java | 2 +-
.../apache/nifi/processors/standard/PutEmail.java | 2 +-
.../lookup/DistributedMapCacheLookupService.java | 2 +-
.../org/apache/nifi/json/TestWriteJsonResult.java | 52 +++++++---------------
.../zookeeper/CuratorACLProviderFactory.java | 2 +-
.../replication/io/TestJsonEntitySerializer.java | 4 +-
.../repository/StandardProcessSessionIT.java | 2 +-
.../registry/service/mapper/ExtensionMappings.java | 2 +-
.../TestFileSystemBundlePersistenceProvider.java | 12 ++---
.../extension/docs/TestHtmlExtensionDocWriter.java | 2 +-
.../properties/util/IdentityMappingUtil.java | 2 +-
.../processors/tests/system/VerifyContents.java | 2 +-
20 files changed, 42 insertions(+), 62 deletions(-)
diff --git
a/nifi-commons/nifi-security-identity/src/main/java/org/apache/nifi/authorization/util/IdentityMappingUtil.java
b/nifi-commons/nifi-security-identity/src/main/java/org/apache/nifi/authorization/util/IdentityMappingUtil.java
index 38a83bdf320..fa28ae1f6d1 100644
---
a/nifi-commons/nifi-security-identity/src/main/java/org/apache/nifi/authorization/util/IdentityMappingUtil.java
+++
b/nifi-commons/nifi-security-identity/src/main/java/org/apache/nifi/authorization/util/IdentityMappingUtil.java
@@ -185,7 +185,7 @@ public class IdentityMappingUtil {
final StringBuilder sb = new StringBuilder(value.length() + 1);
final int groupStart = backRefMatcher.start(1);
- sb.append(value.substring(0, groupStart - 1));
+ sb.append(value, 0, groupStart - 1);
sb.append("\\");
sb.append(value.substring(groupStart - 1));
value = sb.toString();
diff --git
a/nifi-commons/nifi-site-to-site-client/src/test/java/org/apache/nifi/remote/protocol/SiteToSiteTestUtils.java
b/nifi-commons/nifi-site-to-site-client/src/test/java/org/apache/nifi/remote/protocol/SiteToSiteTestUtils.java
index 2ed8bf38c15..aea1485e5d2 100644
---
a/nifi-commons/nifi-site-to-site-client/src/test/java/org/apache/nifi/remote/protocol/SiteToSiteTestUtils.java
+++
b/nifi-commons/nifi-site-to-site-client/src/test/java/org/apache/nifi/remote/protocol/SiteToSiteTestUtils.java
@@ -44,7 +44,7 @@ public class SiteToSiteTestUtils {
public static String readContents(DataPacket packet) throws IOException {
ByteArrayOutputStream os = new ByteArrayOutputStream((int)
packet.getSize());
StreamUtils.copy(packet.getData(), os);
- return new String(os.toByteArray(), StandardCharsets.UTF_8);
+ return os.toString(StandardCharsets.UTF_8);
}
public static void execReceiveZeroFlowFile(Transaction transaction) throws
IOException {
diff --git
a/nifi-extension-bundles/nifi-graph-bundle/nifi-graph-processors/src/main/java/org/apache/nifi/processors/graph/ExecuteGraphQuery.java
b/nifi-extension-bundles/nifi-graph-bundle/nifi-graph-processors/src/main/java/org/apache/nifi/processors/graph/ExecuteGraphQuery.java
index a1a8ac4f06c..01e232a055b 100644
---
a/nifi-extension-bundles/nifi-graph-bundle/nifi-graph-processors/src/main/java/org/apache/nifi/processors/graph/ExecuteGraphQuery.java
+++
b/nifi-extension-bundles/nifi-graph-bundle/nifi-graph-processors/src/main/java/org/apache/nifi/processors/graph/ExecuteGraphQuery.java
@@ -170,7 +170,7 @@ public class ExecuteGraphQuery extends
AbstractGraphExecutor {
session.exportTo(input, out);
out.close();
- query = new String(out.toByteArray());
+ query = out.toString();
} catch (Exception ex) {
throw new ProcessException(ex);
}
diff --git
a/nifi-extension-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoQueryProcessor.java
b/nifi-extension-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoQueryProcessor.java
index b220e9a68e1..a519d512897 100644
---
a/nifi-extension-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoQueryProcessor.java
+++
b/nifi-extension-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoQueryProcessor.java
@@ -124,7 +124,7 @@ public abstract class AbstractMongoQueryProcessor extends
AbstractMongoProcessor
ByteArrayOutputStream out = new ByteArrayOutputStream();
session.exportTo(input, out);
out.close();
- query = Document.parse(new String(out.toByteArray()));
+ query = Document.parse(out.toString());
} catch (Exception ex) {
getLogger().error("Error reading FlowFile : ", ex);
throw new ProcessException(ex);
diff --git
a/nifi-extension-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/DeleteMongo.java
b/nifi-extension-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/DeleteMongo.java
index d2481b59707..66a3835701a 100644
---
a/nifi-extension-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/DeleteMongo.java
+++
b/nifi-extension-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/DeleteMongo.java
@@ -137,12 +137,12 @@ public class DeleteMongo extends AbstractMongoProcessor {
session.exportTo(flowFile, bos);
bos.close();
- String json = new String(bos.toByteArray());
+ String json = bos.toString();
Document query = Document.parse(json);
DeleteResult result;
if (deleteMode.equals(DELETE_ONE.getValue())
- || (deleteMode.equals(DELETE_ATTR.getValue()) &&
deleteAttr.toLowerCase().equals("one"))) {
+ || (deleteMode.equals(DELETE_ATTR.getValue()) &&
deleteAttr.equalsIgnoreCase("one"))) {
result = collection.deleteOne(query);
} else {
result = collection.deleteMany(query);
diff --git
a/nifi-extension-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/QueryHelper.java
b/nifi-extension-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/QueryHelper.java
index 8e9cf1c1150..3268f9cf69a 100644
---
a/nifi-extension-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/QueryHelper.java
+++
b/nifi-extension-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/QueryHelper.java
@@ -59,7 +59,7 @@ public interface QueryHelper {
ByteArrayOutputStream out = new ByteArrayOutputStream();
session.exportTo(input, out);
out.close();
- queryStr = new String(out.toByteArray());
+ queryStr = out.toString();
}
return queryStr;
diff --git
a/nifi-extension-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/gridfs/FetchGridFS.java
b/nifi-extension-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/gridfs/FetchGridFS.java
index 6c91f8375da..8647c67e8dc 100644
---
a/nifi-extension-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/gridfs/FetchGridFS.java
+++
b/nifi-extension-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/gridfs/FetchGridFS.java
@@ -119,7 +119,7 @@ public class FetchGridFS extends AbstractGridFSProcessor
implements QueryHelper
ByteArrayOutputStream out = new ByteArrayOutputStream();
session.exportTo(input, out);
out.close();
- queryString = new String(out.toByteArray());
+ queryString = out.toString();
}
return queryString;
diff --git
a/nifi-extension-bundles/nifi-parquet-bundle/nifi-parquet-processors/src/main/java/org/apache/nifi/processors/parquet/ConvertAvroToParquet.java
b/nifi-extension-bundles/nifi-parquet-bundle/nifi-parquet-processors/src/main/java/org/apache/nifi/processors/parquet/ConvertAvroToParquet.java
index f34c21a8edb..eaca103a00d 100644
---
a/nifi-extension-bundles/nifi-parquet-bundle/nifi-parquet-processors/src/main/java/org/apache/nifi/processors/parquet/ConvertAvroToParquet.java
+++
b/nifi-extension-bundles/nifi-parquet-bundle/nifi-parquet-processors/src/main/java/org/apache/nifi/processors/parquet/ConvertAvroToParquet.java
@@ -156,7 +156,7 @@ public class ConvertAvroToParquet extends AbstractProcessor
{
StringBuilder newFilename = new StringBuilder();
int extensionIndex = fileName.lastIndexOf(".");
if (extensionIndex != -1) {
- newFilename.append(fileName.substring(0, extensionIndex));
+ newFilename.append(fileName, 0, extensionIndex);
} else {
newFilename.append(fileName);
}
diff --git
a/nifi-extension-bundles/nifi-pgp-bundle/nifi-pgp-processors/src/test/java/org/apache/nifi/processors/pgp/SignContentPGPTest.java
b/nifi-extension-bundles/nifi-pgp-bundle/nifi-pgp-processors/src/test/java/org/apache/nifi/processors/pgp/SignContentPGPTest.java
index 6534cfaf7ba..cd38519f55d 100644
---
a/nifi-extension-bundles/nifi-pgp-bundle/nifi-pgp-processors/src/test/java/org/apache/nifi/processors/pgp/SignContentPGPTest.java
+++
b/nifi-extension-bundles/nifi-pgp-bundle/nifi-pgp-processors/src/test/java/org/apache/nifi/processors/pgp/SignContentPGPTest.java
@@ -261,7 +261,7 @@ public class SignContentPGPTest {
assertTrue(verified);
- final String literal = new String(outputStream.toByteArray(),
StandardCharsets.UTF_8);
+ final String literal = outputStream.toString(StandardCharsets.UTF_8);
assertEquals(DATA, literal);
}
}
diff --git
a/nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutEmail.java
b/nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutEmail.java
index 7cc31a82244..9ef91b15acf 100644
---
a/nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutEmail.java
+++
b/nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutEmail.java
@@ -519,7 +519,7 @@ public class PutEmail extends AbstractProcessor {
session.read(flowFile, in -> StreamUtils.fillBuffer(in,
byteBuffer, false));
final Charset charset = getCharset(context);
- messageText = new String(byteBuffer, 0, byteBuffer.length,
charset);
+ messageText = new String(byteBuffer, charset);
} else if (context.getProperty(MESSAGE).isSet()) {
messageText =
context.getProperty(MESSAGE).evaluateAttributeExpressions(flowFile).getValue();
}
diff --git
a/nifi-extension-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup/DistributedMapCacheLookupService.java
b/nifi-extension-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup/DistributedMapCacheLookupService.java
index eb9fb9bc8bb..46dcfab1321 100644
---
a/nifi-extension-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup/DistributedMapCacheLookupService.java
+++
b/nifi-extension-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup/DistributedMapCacheLookupService.java
@@ -134,7 +134,7 @@ public class DistributedMapCacheLookupService extends
AbstractControllerService
if (input == null || input.length == 0) {
return null;
}
- return new String(input, 0, input.length, charset);
+ return new String(input, charset);
}
}
diff --git
a/nifi-extension-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/json/TestWriteJsonResult.java
b/nifi-extension-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/json/TestWriteJsonResult.java
index 35263a8dd70..5034e97f4ba 100644
---
a/nifi-extension-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/json/TestWriteJsonResult.java
+++
b/nifi-extension-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/json/TestWriteJsonResult.java
@@ -265,11 +265,9 @@ class TestWriteJsonResult {
writer.write(rs);
}
- final byte[] data = baos.toByteArray();
-
final String expected =
String.format("[{\"timestamp\":37293723,\"time\":37293723,\"date\":%d}]",
date.getTime());
- final String output = new String(data, StandardCharsets.UTF_8);
+ final String output = baos.toString(StandardCharsets.UTF_8);
assertEquals(expected, output);
}
@@ -292,11 +290,9 @@ class TestWriteJsonResult {
writer.finishRecordSet();
}
- final byte[] data = baos.toByteArray();
-
final String expected = "[{\"id\":\"1\"}]";
- final String output = new String(data, StandardCharsets.UTF_8);
+ final String output = baos.toString(StandardCharsets.UTF_8);
assertEquals(expected, output);
}
@@ -319,11 +315,9 @@ class TestWriteJsonResult {
writer.finishRecordSet();
}
- final byte[] data = baos.toByteArray();
-
final String expected = "[{\"id\":\"1\",\"name\":\"John\"}]";
- final String output = new String(data, StandardCharsets.UTF_8);
+ final String output = baos.toString(StandardCharsets.UTF_8);
assertEquals(expected, output);
}
@@ -346,11 +340,9 @@ class TestWriteJsonResult {
writer.finishRecordSet();
}
- final byte[] data = baos.toByteArray();
-
final String expected = "[{\"id\":\"1\",\"name\":null}]";
- final String output = new String(data, StandardCharsets.UTF_8);
+ final String output = baos.toString(StandardCharsets.UTF_8);
assertEquals(expected, output);
}
@@ -373,11 +365,9 @@ class TestWriteJsonResult {
writer.finishRecordSet();
}
- final byte[] data = baos.toByteArray();
-
final String expected = "[{\"id\":\"1\"}]";
- final String output = new String(data, StandardCharsets.UTF_8);
+ final String output = baos.toString(StandardCharsets.UTF_8);
assertEquals(expected, output);
}
@@ -401,11 +391,9 @@ class TestWriteJsonResult {
writer.finishRecordSet();
}
- final byte[] data = baos.toByteArray();
-
final String expected = "[{\"id\":\"1\",\"name\":null}]";
- final String output = new String(data, StandardCharsets.UTF_8);
+ final String output = baos.toString(StandardCharsets.UTF_8);
assertEquals(expected, output);
}
@@ -429,11 +417,9 @@ class TestWriteJsonResult {
writer.finishRecordSet();
}
- final byte[] data = baos.toByteArray();
-
final String expected = "[{\"id\":\"1\",\"dob\":\"1/1/1970\"}]";
- final String output = new String(data, StandardCharsets.UTF_8);
+ final String output = baos.toString(StandardCharsets.UTF_8);
assertEquals(expected, output);
}
@@ -456,7 +442,7 @@ class TestWriteJsonResult {
writer.finishRecordSet();
}
- assertEquals("[{\"id\":\"1\",\"name\":null}]", new
String(baos.toByteArray(), StandardCharsets.UTF_8));
+ assertEquals("[{\"id\":\"1\",\"name\":null}]",
baos.toString(StandardCharsets.UTF_8));
baos.reset();
try (
@@ -467,7 +453,7 @@ class TestWriteJsonResult {
writer.finishRecordSet();
}
- assertEquals("[{\"id\":\"1\"}]", new String(baos.toByteArray(),
StandardCharsets.UTF_8));
+ assertEquals("[{\"id\":\"1\"}]",
baos.toString(StandardCharsets.UTF_8));
baos.reset();
try (final WriteJsonResult writer = new
WriteJsonResult(Mockito.mock(ComponentLog.class), schema, new
SchemaNameAsAttribute(), baos, false,
@@ -478,7 +464,7 @@ class TestWriteJsonResult {
writer.finishRecordSet();
}
- assertEquals("[{\"id\":\"1\"}]", new String(baos.toByteArray(),
StandardCharsets.UTF_8));
+ assertEquals("[{\"id\":\"1\"}]",
baos.toString(StandardCharsets.UTF_8));
// set an explicit null value
values.put("name", null);
@@ -492,7 +478,7 @@ class TestWriteJsonResult {
writer.finishRecordSet();
}
- assertEquals("[{\"id\":\"1\",\"name\":null}]", new
String(baos.toByteArray(), StandardCharsets.UTF_8));
+ assertEquals("[{\"id\":\"1\",\"name\":null}]",
baos.toString(StandardCharsets.UTF_8));
baos.reset();
try (
@@ -503,7 +489,7 @@ class TestWriteJsonResult {
writer.finishRecordSet();
}
- assertEquals("[{\"id\":\"1\"}]", new String(baos.toByteArray(),
StandardCharsets.UTF_8));
+ assertEquals("[{\"id\":\"1\"}]",
baos.toString(StandardCharsets.UTF_8));
baos.reset();
try (final WriteJsonResult writer = new
WriteJsonResult(Mockito.mock(ComponentLog.class), schema, new
SchemaNameAsAttribute(), baos, false,
@@ -514,7 +500,7 @@ class TestWriteJsonResult {
writer.finishRecordSet();
}
- assertEquals("[{\"id\":\"1\",\"name\":null}]", new
String(baos.toByteArray(), StandardCharsets.UTF_8));
+ assertEquals("[{\"id\":\"1\",\"name\":null}]",
baos.toString(StandardCharsets.UTF_8));
}
@@ -551,12 +537,10 @@ class TestWriteJsonResult {
writer.write(rs);
}
- final byte[] data = baos.toByteArray();
-
final long dateTime = date.getTime();
final String expected =
String.format("{\"timestamp\":37293723,\"time\":37293723,\"date\":%d}\n{\"timestamp\":37293999,\"time\":37293999,\"date\":%d}",
dateTime, dateTime);
- final String output = new String(data, StandardCharsets.UTF_8);
+ final String output = baos.toString(StandardCharsets.UTF_8);
assertEquals(expected, output);
}
@@ -581,11 +565,9 @@ class TestWriteJsonResult {
writer.finishRecordSet();
}
- final byte[] data = baos.toByteArray();
-
final String expected = "[{\"path\":[\"10.2.1.3\"]}]";
- final String output = new String(data, StandardCharsets.UTF_8);
+ final String output = baos.toString(StandardCharsets.UTF_8);
assertEquals(expected, output);
}
@@ -627,9 +609,7 @@ class TestWriteJsonResult {
writer.finishRecordSet();
}
- final byte[] data = baos.toByteArray();
-
- final String output = new String(data, StandardCharsets.UTF_8);
+ final String output = baos.toString(StandardCharsets.UTF_8);
assertEquals(json, output);
}
diff --git
a/nifi-framework-bundle/nifi-framework-extensions/nifi-framework-zookeeper-bundle/nifi-framework-zookeeper-leader-election/src/main/java/org/apache/nifi/framework/cluster/leader/zookeeper/CuratorACLProviderFactory.java
b/nifi-framework-bundle/nifi-framework-extensions/nifi-framework-zookeeper-bundle/nifi-framework-zookeeper-leader-election/src/main/java/org/apache/nifi/framework/cluster/leader/zookeeper/CuratorACLProviderFactory.java
index 3d4dc242295..310d21bb091 100644
---
a/nifi-framework-bundle/nifi-framework-extensions/nifi-framework-zookeeper-bundle/nifi-framework-zookeeper-leader-election/src/main/java/org/apache/nifi/framework/cluster/leader/zookeeper/CuratorACLProviderFactory.java
+++
b/nifi-framework-bundle/nifi-framework-extensions/nifi-framework-zookeeper-bundle/nifi-framework-zookeeper-leader-election/src/main/java/org/apache/nifi/framework/cluster/leader/zookeeper/CuratorACLProviderFactory.java
@@ -46,7 +46,7 @@ public class CuratorACLProviderFactory {
if (!StringUtils.isEmpty(config.getAuthPrincipal())) {
- final String realm =
config.getAuthPrincipal().substring(config.getAuthPrincipal().indexOf('@') + 1,
config.getAuthPrincipal().length());
+ final String realm =
config.getAuthPrincipal().substring(config.getAuthPrincipal().indexOf('@') + 1);
final String[] user = config.getAuthPrincipal().substring(0,
config.getAuthPrincipal().indexOf('@')).split("/");
final String host = user.length == 2 ? user[1] : null;
final String instance = user[0];
diff --git
a/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/test/java/org/apache/nifi/cluster/coordination/http/replication/io/TestJsonEntitySerializer.java
b/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/test/java/org/apache/nifi/cluster/coordination/http/replication/io/TestJsonEntitySerializer.java
index 99e113672cc..8e3f3be5d54 100644
---
a/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/test/java/org/apache/nifi/cluster/coordination/http/replication/io/TestJsonEntitySerializer.java
+++
b/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/test/java/org/apache/nifi/cluster/coordination/http/replication/io/TestJsonEntitySerializer.java
@@ -60,7 +60,7 @@ public class TestJsonEntitySerializer {
serializer.serialize(processor, baos);
- final String serialized = new String(baos.toByteArray(),
StandardCharsets.UTF_8);
+ final String serialized = baos.toString(StandardCharsets.UTF_8);
assertEquals("{\"id\":\"123\",\"component\":{\"config\":{\"properties\":{\"key\":\"value\"}}}}",
serialized);
}
}
@@ -91,7 +91,7 @@ public class TestJsonEntitySerializer {
bulletin.setBulletin(bulletinDto);
serializer.serialize(bulletin, baos);
- final String serialized = new String(baos.toByteArray(),
StandardCharsets.UTF_8);
+ final String serialized = baos.toString(StandardCharsets.UTF_8);
assertEquals("{\"bulletin\":{\"category\":\"test\",\"level\":\"INFO\",\"timestamp\":\""
+ formattedTimestamp + "\"}}", serialized);
}
}
diff --git
a/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/java/org/apache/nifi/controller/repository/StandardProcessSessionIT.java
b/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/java/org/apache/nifi/controller/repository/StandardProcessSessionIT.java
index 9077fd6225d..296111e634e 100644
---
a/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/java/org/apache/nifi/controller/repository/StandardProcessSessionIT.java
+++
b/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/java/org/apache/nifi/controller/repository/StandardProcessSessionIT.java
@@ -1254,7 +1254,7 @@ public class StandardProcessSessionIT {
// should be OK
ByteArrayOutputStream os = new ByteArrayOutputStream();
session.exportTo(flowFile, os);
- assertEquals("Hello World", new String(os.toByteArray()));
+ assertEquals("Hello World", os.toString());
os.close();
// should throw ProcessException because of IOException (from
processor code)
diff --git
a/nifi-registry/nifi-registry-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/service/mapper/ExtensionMappings.java
b/nifi-registry/nifi-registry-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/service/mapper/ExtensionMappings.java
index 45291c5ee7a..4da95f9be49 100644
---
a/nifi-registry/nifi-registry-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/service/mapper/ExtensionMappings.java
+++
b/nifi-registry/nifi-registry-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/service/mapper/ExtensionMappings.java
@@ -173,7 +173,7 @@ public class ExtensionMappings {
final String extensionContent;
try (final ByteArrayOutputStream out = new ByteArrayOutputStream()) {
extensionSerializer.serialize(extension, out);
- extensionContent = new String(out.toByteArray(),
StandardCharsets.UTF_8);
+ extensionContent = out.toString(StandardCharsets.UTF_8);
} catch (IOException e) {
throw new SerializationException("Unable to serialize extension",
e);
}
diff --git
a/nifi-registry/nifi-registry-core/nifi-registry-framework/src/test/java/org/apache/nifi/registry/provider/extension/TestFileSystemBundlePersistenceProvider.java
b/nifi-registry/nifi-registry-core/nifi-registry-framework/src/test/java/org/apache/nifi/registry/provider/extension/TestFileSystemBundlePersistenceProvider.java
index f67e7a3ec22..016ca29b4ee 100644
---
a/nifi-registry/nifi-registry-core/nifi-registry-framework/src/test/java/org/apache/nifi/registry/provider/extension/TestFileSystemBundlePersistenceProvider.java
+++
b/nifi-registry/nifi-registry-core/nifi-registry-framework/src/test/java/org/apache/nifi/registry/provider/extension/TestFileSystemBundlePersistenceProvider.java
@@ -140,9 +140,9 @@ public class TestFileSystemBundlePersistenceProvider {
verifyBundleVersion(bundleStorageDir, versionCoordinate, newContent);
// retrieved content should be updated
- try (final OutputStream out = new ByteArrayOutputStream()) {
+ try (final ByteArrayOutputStream out = new ByteArrayOutputStream()) {
fileSystemBundleProvider.getBundleVersionContent(versionCoordinate, out);
- final String retrievedContent = new
String(((ByteArrayOutputStream) out).toByteArray(), StandardCharsets.UTF_8);
+ final String retrievedContent =
out.toString(StandardCharsets.UTF_8);
assertEquals(newContent, retrievedContent);
}
}
@@ -159,17 +159,17 @@ public class TestFileSystemBundlePersistenceProvider {
final BundleVersionCoordinate versionCoordinate2 =
getVersionCoordinate(BUCKET_ID, GROUP_ID, ARTIFACT_ID, SECOND_VERSION, type);
createBundleVersion(fileSystemBundleProvider, versionCoordinate2,
content2);
- try (final OutputStream out = new ByteArrayOutputStream()) {
+ try (final ByteArrayOutputStream out = new ByteArrayOutputStream()) {
fileSystemBundleProvider.getBundleVersionContent(versionCoordinate1, out);
- final String retrievedContent1 = new
String(((ByteArrayOutputStream) out).toByteArray(), StandardCharsets.UTF_8);
+ final String retrievedContent1 =
out.toString(StandardCharsets.UTF_8);
assertEquals(content1, retrievedContent1);
}
- try (final OutputStream out = new ByteArrayOutputStream()) {
+ try (final ByteArrayOutputStream out = new ByteArrayOutputStream()) {
fileSystemBundleProvider.getBundleVersionContent(versionCoordinate2, out);
- final String retrievedContent2 = new
String(((ByteArrayOutputStream) out).toByteArray(), StandardCharsets.UTF_8);
+ final String retrievedContent2 =
out.toString(StandardCharsets.UTF_8);
assertEquals(content2, retrievedContent2);
}
}
diff --git
a/nifi-registry/nifi-registry-core/nifi-registry-framework/src/test/java/org/apache/nifi/registry/service/extension/docs/TestHtmlExtensionDocWriter.java
b/nifi-registry/nifi-registry-core/nifi-registry-framework/src/test/java/org/apache/nifi/registry/service/extension/docs/TestHtmlExtensionDocWriter.java
index 35c19121068..c4daebb0dac 100644
---
a/nifi-registry/nifi-registry-core/nifi-registry-framework/src/test/java/org/apache/nifi/registry/service/extension/docs/TestHtmlExtensionDocWriter.java
+++
b/nifi-registry/nifi-registry-core/nifi-registry-framework/src/test/java/org/apache/nifi/registry/service/extension/docs/TestHtmlExtensionDocWriter.java
@@ -75,7 +75,7 @@ public class TestHtmlExtensionDocWriter {
final ByteArrayOutputStream out = new ByteArrayOutputStream();
docWriter.write(metadata, extension, out);
- final String docsResult = new String(out.toByteArray(),
StandardCharsets.UTF_8);
+ final String docsResult = out.toString(StandardCharsets.UTF_8);
assertNotNull(docsResult);
XmlValidator.assertXmlValid(docsResult);
diff --git
a/nifi-registry/nifi-registry-core/nifi-registry-properties/src/main/java/org/apache/nifi/registry/properties/util/IdentityMappingUtil.java
b/nifi-registry/nifi-registry-core/nifi-registry-properties/src/main/java/org/apache/nifi/registry/properties/util/IdentityMappingUtil.java
index 5b67923ad92..6bd832d6021 100644
---
a/nifi-registry/nifi-registry-core/nifi-registry-properties/src/main/java/org/apache/nifi/registry/properties/util/IdentityMappingUtil.java
+++
b/nifi-registry/nifi-registry-core/nifi-registry-properties/src/main/java/org/apache/nifi/registry/properties/util/IdentityMappingUtil.java
@@ -192,7 +192,7 @@ public class IdentityMappingUtil {
final StringBuilder sb = new StringBuilder(value.length() + 1);
final int groupStart = backRefMatcher.start(1);
- sb.append(value.substring(0, groupStart - 1));
+ sb.append(value, 0, groupStart - 1);
sb.append("\\");
sb.append(value.substring(groupStart - 1));
value = sb.toString();
diff --git
a/nifi-system-tests/nifi-system-test-extensions-bundle/nifi-system-test-extensions/src/main/java/org/apache/nifi/processors/tests/system/VerifyContents.java
b/nifi-system-tests/nifi-system-test-extensions-bundle/nifi-system-test-extensions/src/main/java/org/apache/nifi/processors/tests/system/VerifyContents.java
index 9454e968cd3..d54507d2c0a 100644
---
a/nifi-system-tests/nifi-system-test-extensions-bundle/nifi-system-test-extensions/src/main/java/org/apache/nifi/processors/tests/system/VerifyContents.java
+++
b/nifi-system-tests/nifi-system-test-extensions-bundle/nifi-system-test-extensions/src/main/java/org/apache/nifi/processors/tests/system/VerifyContents.java
@@ -82,7 +82,7 @@ public class VerifyContents extends AbstractProcessor {
final ByteArrayOutputStream baos = new ByteArrayOutputStream()) {
StreamUtils.copy(in, baos);
- contents = new String(baos.toByteArray(), StandardCharsets.UTF_8);
+ contents = baos.toString(StandardCharsets.UTF_8);
} catch (final Exception e) {
throw new ProcessException(e);
}
