[
https://issues.apache.org/jira/browse/NIFI-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294370#comment-14294370
]
ASF GitHub Bot commented on NIFI-305:
-------------------------------------
GitHub user gresockj opened a pull request:
https://github.com/apache/incubator-nifi/pull/12
NIFI-305: Refactoring base class from MergeContent to allow more binning
processors
Pulled out the binning logic from MergeContent into a superclass for
binning processors. Basically all of the min/max properties were moved to
BinFiles. Mostly focused on ensuring that the functionality was preserved from
MergeContent, but there is certainly room for improvement in producing a more
elegantly extensible class.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gresockj/incubator-nifi NIFI-305
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-nifi/pull/12.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12
----
commit 98afcce0dc3672fe04e2130ac72b9a201e17ba1a
Author: gresockj <[email protected]>
Date: 2015-01-27T22:32:38Z
NIFI-305: Refactoring superclass BinFiles from MergeContent
commit ad40903458cd2bbf98284d693a057519d8bbf775
Author: gresockj <[email protected]>
Date: 2015-01-27T22:51:16Z
NIFI-305: Minor documentation update
----
> Refactor base class from MergeContent
> -------------------------------------
>
> Key: NIFI-305
> URL: https://issues.apache.org/jira/browse/NIFI-305
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Core Framework
> Affects Versions: 0.0.1
> Reporter: Joseph Gresock
> Priority: Minor
>
> The binning logic in MergeContent is extremely useful, and could be pulled
> out into an abstract superclass. This would allow other processors to
> perform binning logic without being tied to a merged flow file. For example,
> a processor may want to submit a batch request to a database like Solr, or to
> a REST endpoint.
> The vast majority of the code in MergeContent would remain in the concrete
> class, but there are several points, such as the BinManager usage, that could
> be abstracted for easy extensibility.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
