[ 
https://issues.apache.org/jira/browse/NIFI-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14305138#comment-14305138
 ] 

Mark Payne edited comment on NIFI-317 at 2/4/15 2:27 PM:
---------------------------------------------------------

+1: Code looks good.

I am a bit concerned that saving the image as an .svg rather than a .png will 
be problematic for some. I think PNG is much more widely known image format and 
is very well supported in pretty much all operating systems. While an .svg file 
can be opened by Chrome, IE, and Firefox, the thumbnail will not be shown in a 
Windows folder, and it cannot be easily edited with out-of-the-box software 
like MS Paint, should the user want to quickly highlight or add some sort of 
emphasis to the image, etc.

This does allow us to avoid the extra dependencies, though. We can re-evaluate 
if it becomes a problem later.


was (Author: markap14):
+1: Code looks good.

> Add support for exporting lineage graph as SVG
> ----------------------------------------------
>
>                 Key: NIFI-317
>                 URL: https://issues.apache.org/jira/browse/NIFI-317
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core UI
>            Reporter: Matt Gilman
>            Assignee: Matt Gilman
>            Priority: Minor
>         Attachments: 0001-NIFI-317.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to