[ 
https://issues.apache.org/jira/browse/NIFI-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14365650#comment-14365650
 ] 

Joseph Witt commented on NIFI-121:
----------------------------------

I evaluated the and its implications in detail and I analyzed the code and the 
benefits of making this change work.  The core challenge is that this is a 
really specific case:
- Merging where the result is only a single output file (which was the original 
input file) doing Binary Concatenation when there is no header and is no footer.

Given how specific a case this is and that if that were happening it would only 
be because there was a timeout going there is arguably very little if any 
throughput/efficiency gain to be had.  It does not appear to justify the 
complexity of changes required to MergeContent which is already a pretty 
complicated processor.  Perhaps we can revisit this over time if this becomes 
an issue.  Thank you for the PR/contribution.  There are plenty of remaining 
things to dive into and we'd be happy to help. 

> Merge content could be more efficient in the edge case of a single merge item
> -----------------------------------------------------------------------------
>
>                 Key: NIFI-121
>                 URL: https://issues.apache.org/jira/browse/NIFI-121
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Matt Gilman
>            Priority: Minor
>
> When MergeContent is configured to perform Binary Concatenation, if 
> generating bundle of 1 FlowFile, should just Clone original FLowFile instead 
> of copying data



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to