[ 
https://issues.apache.org/jira/browse/NIFI-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14372805#comment-14372805
 ] 

Dan Bress commented on NIFI-309:
--------------------------------

Joe, thanks.  Glad you like this.

Your patch looks good to me.  The only thing I don't understand is I see a lot 
of changes  where it looks like nothing changed(including tab/whitespace):

e.g.
{noformat}
@@ -194,12 +194,12 @@ public class HtmlDocumentationWriter implements 
DocumentationWriter {
      */
     protected void writeAdditionalBodyInfo(final ConfigurableComponent 
configurableComponent,
             final XMLStreamWriter xmlStreamWriter) throws XMLStreamException {
-
+
     }
 
     /**
-     * Writes the tags attached to a ConfigurableComponent.
-     * 
+     * Writes the tags attached to a ConfigurableComponent.
+     * 
      * @param configurableComponent
      * @param xmlStreamWriter
      * @throws XMLStreamException
{noformat}

What is going on there?  I noticed when I rebased it would give me some weird 
merge conflicts with stuff like this.  Any way for me to prevent this going 
forward?

> Support additional documentation annotations
> --------------------------------------------
>
>                 Key: NIFI-309
>                 URL: https://issues.apache.org/jira/browse/NIFI-309
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Core Framework, Documentation & Website
>    Affects Versions: 0.0.1
>            Reporter: Dan Bress
>            Assignee: Dan Bress
>            Priority: Trivial
>         Attachments: NIFI-309-Patch-After-PR40.patch
>
>
> Additional documentation only annotations should be added to better describe 
> ConfigurableComponents.  These annotations are:
> DynamicProperties - this would indicate whether a component supports dynamic 
> properties or not, and provides a description.  This could be used by the UI 
> to determine whether or not to allow dynamic properties.  It could also be 
> reflected in the documentation.
> DynamicRelationships - this would indicate whether a component has dynamic 
> relationships, like RouteOnAttribute and DistributeLoad do.  This could be 
> reflected in the documentation.
> ReadsAttribute - indicates what attributes a Processor reads certain FlowFile 
> attributes on incoming FlowFiles.  This would be reflected in the 
> documentation.
> WritesAttribute - indicates what attributes a Processor creates on outgoing 
> FlowFile attributes.  This would be reflected in the documentation.
> SeeAlso - Provides a mechanism to link one configurable component to another. 
>  E.g. PutFile & GetFile.  This would be used in the documentation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to