[
https://issues.apache.org/jira/browse/NIFI-271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14372844#comment-14372844
]
Joseph Witt commented on NIFI-271:
----------------------------------
Proposal:
1) Do what Benson said.
2) In that nifi-parent ensure checkstyle is always run and thus
consistent across any nifi item. Fail the build if any violations.
3) In that nifi-parent ensure check-licenses is always run and if any
fails - fail the build.
Commentary:
- This is not as forgiving as Sean suggested but it also does not
preclude us from doing the QC bot to check higher order items.
- This is more in-line with Adam's suggestion but gives the
contributor direct feedback on what is wrong that they can resolve on
their own without us rejecting their PR. This I am guessing was
Adam's real intent anyway.
- I will go through an make sure all existing code is in-line with the
checkstyle form that we will create. That will require very loud
music and good drinks but whatever - about as much fun as it was
getting all the licensing squared away.
> factor out a released common parent pom
> ---------------------------------------
>
> Key: NIFI-271
> URL: https://issues.apache.org/jira/browse/NIFI-271
> Project: Apache NiFi
> Issue Type: Task
> Reporter: Benson Margulies
>
> Arguably, there are a number of pieces of configuration and taste that are in
> common between the 'nifi' and the 'maven-plugins' tree. If we wanted to apply
> DRY to this, we would add a 'parent' directory, put a pom in there, and
> release _that_ first.
> Or, on the other hand, we might feel that this is overkill. I don't think
> it's a good idea to go here for 0.0.1 of anything, so I'm just writing this
> for future digestion.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
